Fix CS

.github/workflows/build.yml

@@ -6,7 +6,7 @@ on:
             - 'dependabot/**'
     pull_request: ~
     release:
-        types: [created]
+        types: [ created ]
     schedule:
         -
             cron: "0 1 * * 6" # Run at 1am every Saturday
@@ -21,11 +21,11 @@ jobs:
         strategy:
             fail-fast: false
             matrix:
-                php: ["8.2", "8.3"]
-                symfony: ["^6.4", "^7.0"]
-                sylius: ["^1.12"]
-                node: ["16.x"]
-                mysql: ["5.7", "8.0"]
+                php: [ "8.2", "8.3" ]
+                symfony: [ "^6.4", "^7.0" ]
+                sylius: [ "^1.12" ]
+                node: [ "16.x" ]
+                mysql: [ "5.7", "8.0" ]
 
         env:
             APP_ENV: test
@@ -160,6 +160,10 @@ jobs:
                 name: Validate database schema
                 run: (cd tests/Application && bin/console doctrine:schema:validate)
 
+            -
+                name: Check Coding Standard
+                run: vendor/bin/ecs
+
             -
                 name: Run PHPStan
                 run: vendor/bin/phpstan analyse -c phpstan.neon -l max src/

ecs.php

@@ -18,4 +18,3 @@
         VisibilityRequiredFixer::class => ['*Spec.php'],
     ]);
 };
-

src/CommandHandler/Wishlist/AddProductToWishlistHandler.php

@@ -29,7 +29,7 @@ final class AddProductToWishlistHandler implements MessageHandlerInterface
     public function __construct(
         WishlistProductFactoryInterface $wishlistProductFactory,
         ProductRepositoryInterface $productRepository,
-        ObjectManager $wishlistManager
+        ObjectManager $wishlistManager,
     ) {
         $this->wishlistProductFactory = $wishlistProductFactory;
         $this->productRepository = $productRepository;
@@ -45,7 +45,7 @@ public function __invoke(AddProductToWishlist $addProductToWishlist): WishlistIn
 
         if (null === $product) {
             throw new ProductNotFoundException(
-                sprintf('The Product %s does not exist', $productId)
+                sprintf('The Product %s does not exist', $productId),
             );
         }
 

src/CommandHandler/Wishlist/AddProductVariantToWishlistHandler.php

@@ -29,7 +29,7 @@ final class AddProductVariantToWishlistHandler implements MessageHandlerInterfac
     public function __construct(
         WishlistProductFactoryInterface $wishlistProductFactory,
         ProductVariantRepositoryInterface $productVariantRepository,
-        ObjectManager $wishlistManager
+        ObjectManager $wishlistManager,
     ) {
         $this->wishlistProductFactory = $wishlistProductFactory;
         $this->productVariantRepository = $productVariantRepository;
@@ -45,7 +45,7 @@ public function __invoke(AddProductVariantToWishlist $addProductVariantToWishlis
 
         if (null === $variant) {
             throw new ProductVariantNotFoundException(
-                sprintf('The ProductVariant %s does not exist', $variantId)
+                sprintf('The ProductVariant %s does not exist', $variantId),
             );
         }
 

src/CommandHandler/Wishlist/CreateWishlistHandler.php

@@ -33,7 +33,7 @@ public function __construct(
         TokenStorageInterface $tokenStorage,
         WishlistFactoryInterface $wishlistFactory,
         ShopUserWishlistResolverInterface $shopUserWishlistResolver,
-        ObjectManager $wishlistManager
+        ObjectManager $wishlistManager,
     ) {
         $this->tokenStorage = $tokenStorage;
         $this->wishlistFactory = $wishlistFactory;

src/CommandHandler/Wishlist/RemoveProductFromWishlistHandler.php

@@ -34,7 +34,7 @@ public function __construct(
         ProductRepositoryInterface $productRepository,
         WishlistRepositoryInterface $wishlistRepository,
         RepositoryInterface $wishlistProductRepository,
-        ObjectManager $wishlistManager
+        ObjectManager $wishlistManager,
     ) {
         $this->productRepository = $productRepository;
         $this->wishlistRepository = $wishlistRepository;
@@ -54,13 +54,13 @@ public function __invoke(RemoveProductFromWishlist $removeProductFromWishlist):
 
         if (null === $product || null === $wishlistProduct) {
             throw new ProductNotFoundException(
-                sprintf('The Product %s does not exist', $productId)
+                sprintf('The Product %s does not exist', $productId),
             );
         }
 
         if (null === $wishlist) {
             throw new WishlistNotFoundException(
-                sprintf('The Wishlist %s does not exist', $token)
+                sprintf('The Wishlist %s does not exist', $token),
             );
         }
 

src/CommandHandler/Wishlist/RemoveProductVariantFromWishlistHandler.php

@@ -34,7 +34,7 @@ public function __construct(
         WishlistRepositoryInterface $wishlistRepository,
         ProductVariantRepositoryInterface $productVariantRepository,
         RepositoryInterface $wishlistProductRepository,
-        ObjectManager $wishlistManager
+        ObjectManager $wishlistManager,
     ) {
         $this->wishlistRepository = $wishlistRepository;
         $this->productVariantRepository = $productVariantRepository;
@@ -54,13 +54,13 @@ public function __invoke(RemoveProductVariantFromWishlist $removeProductVariantF
 
         if (null === $variant || null === $wishlistProduct) {
             throw new ProductVariantNotFoundException(
-                sprintf('The Product %s does not exist', $variantId)
+                sprintf('The Product %s does not exist', $variantId),
             );
         }
 
         if (null === $wishlist) {
             throw new WishlistNotFoundException(
-                sprintf('The Wishlist %s does not exist', $token)
+                sprintf('The Wishlist %s does not exist', $token),
             );
         }
 

src/CommandHandler/Wishlist/RemoveWishlistHandler.php

@@ -24,7 +24,7 @@ final class RemoveWishlistHandler implements MessageHandlerInterface
 
     public function __construct(
         WishlistRepositoryInterface $wishlistRepository,
-        ObjectManager $wishlistManager
+        ObjectManager $wishlistManager,
     ) {
         $this->wishlistRepository = $wishlistRepository;
         $this->wishlistManager = $wishlistManager;
@@ -37,7 +37,7 @@ public function __invoke(RemoveWishlist $removeWishlist): void
 
         if (null === $wishlist) {
             throw new WishlistNotFoundException(
-                sprintf('The Wishlist %s does not exist', $token)
+                sprintf('The Wishlist %s does not exist', $token),
             );
         }
 

src/Context/WishlistContext.php

@@ -31,7 +31,7 @@ public function __construct(
         TokenStorageInterface $tokenStorage,
         WishlistRepositoryInterface $wishlistRepository,
         WishlistFactoryInterface $wishlistFactory,
-        string $wishlistCookieToken
+        string $wishlistCookieToken,
     ) {
         $this->tokenStorage = $tokenStorage;
         $this->wishlistRepository = $wishlistRepository;

src/Controller/Action/AddProductToWishlistAction.php

@@ -59,7 +59,7 @@ public function __construct(
         RequestStack $requestStack,
         TranslatorInterface $translator,
         UrlGeneratorInterface $urlGenerator,
-        string $wishlistCookieToken
+        string $wishlistCookieToken,
     ) {
         $this->tokenStorage = $tokenStorage;
         $this->productRepository = $productRepository;

src/Controller/Action/AddProductVariantToWishlistAction.php

@@ -59,7 +59,7 @@ public function __construct(
         RequestStack $requestStack,
         TranslatorInterface $translator,
         UrlGeneratorInterface $urlGenerator,
-        string $wishlistCookieToken
+        string $wishlistCookieToken,
     ) {
         $this->tokenStorage = $tokenStorage;
         $this->productVariantRepository = $productVariantRepository;

src/Controller/Action/ListWishlistProductsAction.php

@@ -53,7 +53,7 @@ public function __construct(
         EntityManagerInterface $cartManager,
         RequestStack $requestStack,
         TranslatorInterface $translator,
-        Environment $twigEnvironment
+        Environment $twigEnvironment,
     ) {
         $this->wishlistContext = $wishlistContext;
         $this->cartContext = $cartContext;
@@ -80,7 +80,6 @@ public function __invoke(Request $request): Response
         $form->handleRequest($request);
 
         if ($form->isSubmitted() && $form->isValid()) {
-
             if ($this->handleCartItems($form)) {
                 $this->flashBag->add('success', $this->translator->trans('bitbag_sylius_wishlist_plugin.ui.added_to_cart'));
             } else {
@@ -91,7 +90,7 @@ public function __invoke(Request $request): Response
                 $this->twigEnvironment->render('@BitBagSyliusWishlistPlugin/WishlistDetails/index.html.twig', [
                     'wishlist' => $wishlist,
                     'form' => $form->createView(),
-                ])
+                ]),
             );
         }
 
@@ -103,7 +102,7 @@ public function __invoke(Request $request): Response
             $this->twigEnvironment->render('@BitBagSyliusWishlistPlugin/WishlistDetails/index.html.twig', [
                 'wishlist' => $wishlist,
                 'form' => $form->createView(),
-            ])
+            ]),
         );
     }
 

src/Controller/Action/RemoveProductFromWishlistAction.php

@@ -45,7 +45,7 @@ public function __construct(
         EntityManagerInterface $wishlistProductManager,
         RequestStack $requestStack,
         TranslatorInterface $translator,
-        UrlGeneratorInterface $urlGenerator
+        UrlGeneratorInterface $urlGenerator,
     ) {
         $this->wishlistContext = $wishlistContext;
         $this->productRepository = $productRepository;

src/Controller/Action/RemoveProductVariantFromWishlistAction.php

@@ -45,7 +45,7 @@ public function __construct(
         EntityManagerInterface $wishlistProductManager,
         RequestStack $requestStack,
         TranslatorInterface $translator,
-        UrlGeneratorInterface $urlGenerator
+        UrlGeneratorInterface $urlGenerator,
     ) {
         $this->wishlistContext = $wishlistContext;
         $this->productVariantRepository = $productVariantRepository;

src/Controller/Action/RenderHeaderTemplateAction.php

@@ -34,7 +34,7 @@ public function __invoke(Request $request): Response
         return new Response(
             $this->twigEnvironment->render('@BitBagSyliusWishlistPlugin/Common/widget.html.twig', [
                 'wishlist' => $wishlist,
-            ])
+            ]),
         );
     }
 }

src/Controller/OrderItemController.php

@@ -35,7 +35,7 @@ public function addAction(Request $request): Response
         $form = $this->getFormFactory()->create(
             $configuration->getFormType(),
             $this->createAddToCartCommand($cart, $orderItem),
-            $configuration->getFormOptions()
+            $configuration->getFormOptions(),
         );
 
         $form->handleRequest($request);

src/EventListener/MergeUserWishlistItemsListener.php

@@ -36,7 +36,7 @@ public function __construct(
         WishlistRepositoryInterface $wishlistRepository,
         WishlistFactoryInterface $wishlistFactory,
         ObjectManager $wishlistManager,
-        string $wishlistCookieToken
+        string $wishlistCookieToken,
     ) {
         $this->wishlistRepository = $wishlistRepository;
         $this->wishlistFactory = $wishlistFactory;

src/Form/Type/AddProductsToCartType.php

@@ -36,7 +36,7 @@ public function __construct(
         AddToCartCommandFactoryInterface $addToCartCommandFactory,
         CartItemFactoryInterface $cartItemFactory,
         OrderItemQuantityModifierInterface $orderItemQuantityModifier,
-        array $validationGroups
+        array $validationGroups,
     ) {
         $this->addToCartCommandFactory = $addToCartCommandFactory;
         $this->cartItemFactory = $cartItemFactory;
@@ -58,7 +58,7 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
                     'product' => $wishlistProduct->getProduct(),
                     'data' => $this->addToCartCommandFactory->createWithCartAndCartItem(
                         $options['cart'],
-                        $this->createCartItem($wishlistProduct)
+                        $this->createCartItem($wishlistProduct),
                     ),
                     'is_wishlist' => true,
                 ])

src/Resolver/ShopUserWishlistResolver.php

@@ -23,7 +23,7 @@ final class ShopUserWishlistResolver implements ShopUserWishlistResolverInterfac
 
     public function __construct(
         WishlistRepositoryInterface $wishlistRepository,
-        WishlistFactoryInterface $wishlistFactory
+        WishlistFactoryInterface $wishlistFactory,
     ) {
         $this->wishlistRepository = $wishlistRepository;
         $this->wishlistFactory = $wishlistFactory;

tests/Behat/Context/Api/WishlistContext.php

@@ -53,7 +53,7 @@ public function __construct(
         WishlistRepositoryInterface $wishlistRepository,
         UserRepositoryInterface $userRepository,
         ClientInterface $client,
-        RouterInterface $router
+        RouterInterface $router,
     ) {
         $this->client = $client;
         $this->wishlistRepository = $wishlistRepository;
@@ -86,7 +86,7 @@ public function userIsAuthenticated(string $email, string $password): void
             [
                 'headers' => $headers,
                 'body' => json_encode($body),
-            ]
+            ],
         );
         Assert::eq($response->getStatusCode(), 200);
 
@@ -116,7 +116,7 @@ public function userHasAWishlist(): void
         $response = $this->client->request(
             self::POST,
             sprintf('%s%s', self::$domain, $uri),
-            $this->getOptions(self::POST, [])
+            $this->getOptions(self::POST, []),
         );
 
         $jsonBody = json_decode((string) $response->getBody());
@@ -157,9 +157,10 @@ public function userShouldHaveProductInTheWishlist(ProductInterface $product): b
         }
 
         throw new \Exception(
-            sprintf('Product %s was not found in the wishlist',
-                $product->getName()
-            )
+            sprintf(
+                'Product %s was not found in the wishlist',
+                $product->getName(),
+            ),
         );
     }
 
@@ -190,9 +191,10 @@ public function userShouldHaveProductVariantInTheWishlist(ProductVariantInterfac
         }
 
         throw new \Exception(
-            sprintf('Product variant %s was not found in the wishlist',
-                $variant->getName()
-            )
+            sprintf(
+                'Product variant %s was not found in the wishlist',
+                $variant->getName(),
+            ),
         );
     }
 
@@ -209,7 +211,7 @@ public function userRemovesProductFromTheWishlist(ProductInterface $product): vo
         $response = $this->client->request(
             self::DELETE,
             sprintf('%s%s', self::$domain, $uri),
-            $this->getOptions(self::DELETE, [])
+            $this->getOptions(self::DELETE, []),
         );
 
         Assert::eq($response->getStatusCode(), 204);
@@ -250,7 +252,7 @@ public function userRemovesProductVariantFromTheWishlist(ProductVariantInterface
         $response = $this->client->request(
             self::DELETE,
             sprintf('%s%s', self::$domain, $uri),
-            $this->getOptions(self::DELETE)
+            $this->getOptions(self::DELETE),
         );
 
         Assert::eq($response->getStatusCode(), 204);
@@ -340,7 +342,7 @@ private function addProductToTheWishlist(WishlistInterface $wishlist, ProductInt
         return $this->client->request(
             self::PATCH,
             sprintf('%s%s', self::$domain, $uri),
-            $this->getOptions(self::PATCH, $body)
+            $this->getOptions(self::PATCH, $body),
         );
     }
 
@@ -357,7 +359,7 @@ private function addProductVariantToTheWishlist(WishlistInterface $wishlist, Pro
         return $this->client->request(
             self::PATCH,
             sprintf('%s%s', self::$domain, $uri),
-            $this->getOptions(self::PATCH, $body)
+            $this->getOptions(self::PATCH, $body),
         );
     }
 
@@ -374,7 +376,7 @@ private function removeProductFromTheWishlist(WishlistInterface $wishlist, Produ
         return $this->client->request(
             self::DELETE,
             sprintf('%s%s', self::$domain, $uri),
-            $this->getOptions(self::DELETE)
+            $this->getOptions(self::DELETE),
         );
     }
 }

tests/Behat/Context/Setup/WishlistContext.php

@@ -52,7 +52,7 @@ public function __construct(
         FactoryInterface $productTaxonFactory,
         EntityManagerInterface $productTaxonManager,
         CookieSetterInterface $cookieSetter,
-        string $wishlistCookieToken
+        string $wishlistCookieToken,
     ) {
         $this->productRepository = $productRepository;
         $this->wishlistContext = $wishlistContext;