Fix PHPStan

webgriffe · May 13, 2024 · f0380cf · f0380cf
1 parent f166037
commit f0380cf
Show file tree

Hide file tree

Showing 11 changed files with 29 additions and 2 deletions.
diff --git a/phpstan.neon b/phpstan.neon
@@ -1,12 +1,11 @@
 parameters:
     level: max
     reportUnmatchedIgnoredErrors: false
-    checkMissingIterableValueType: false
     paths:
         - src
         - tests/Behat
 
-    excludes_analyse:
+    excludePaths:
         # Makes PHPStan crash
         - 'src/DependencyInjection/Configuration.php'
 
@@ -16,3 +15,5 @@ parameters:
 
     ignoreErrors:
         - '/Parameter #1 \$configuration of method Symfony\\Component\\DependencyInjection\\Extension\\Extension::processConfiguration\(\) expects Symfony\\Component\\Config\\Definition\\ConfigurationInterface, Symfony\\Component\\Config\\Definition\\ConfigurationInterface\|null given\./'
+        -
+            identifier: missingType.iterableValue
diff --git a/src/Command/IndexCommand.php b/src/Command/IndexCommand.php
@@ -19,6 +19,9 @@
 
 final class IndexCommand extends Command
 {
+    /**
+     * @param ChannelRepositoryInterface<ChannelInterface> $channelRepository
+     */
     public function __construct(
         private readonly ChannelRepositoryInterface $channelRepository,
         private readonly MessageBusInterface $messageBus,

diff --git a/src/Controller/ProductController.php b/src/Controller/ProductController.php
@@ -34,6 +34,9 @@
  */
 final class ProductController extends AbstractController implements ProductControllerInterface
 {
+    /**
+     * @param TaxonRepositoryInterface<TaxonInterface> $taxonRepository
+     */
     public function __construct(
         private readonly TaxonRepositoryInterface $taxonRepository,
         private readonly LocaleContextInterface $localeContext,

diff --git a/src/EventSubscriber/ProductEventSubscriber.php b/src/EventSubscriber/ProductEventSubscriber.php
@@ -18,6 +18,9 @@
 
 final readonly class ProductEventSubscriber implements EventSubscriberInterface
 {
+    /**
+     * @param ChannelRepositoryInterface<ChannelInterface> $channelRepository
+     */
     public function __construct(
         private MessageBusInterface $messageBus,
         private LoggerInterface $logger,

diff --git a/src/EventSubscriber/ProductVariantSubscriber.php b/src/EventSubscriber/ProductVariantSubscriber.php
@@ -19,6 +19,9 @@
 
 final readonly class ProductVariantSubscriber implements EventSubscriberInterface
 {
+    /**
+     * @param ChannelRepositoryInterface<ChannelInterface> $channelRepository
+     */
     public function __construct(
         private MessageBusInterface $messageBus,
         private LoggerInterface $logger,

diff --git a/src/MessageHandler/CreateIndexHandler.php b/src/MessageHandler/CreateIndexHandler.php
@@ -13,6 +13,9 @@
 
 final readonly class CreateIndexHandler
 {
+    /**
+     * @param ChannelRepositoryInterface<ChannelInterface> $channelRepository
+     */
     public function __construct(
         private ChannelRepositoryInterface $channelRepository,
         private DocumentTypeProviderInterface $documentTypeProvider,

diff --git a/src/MessageHandler/RemoveDocumentIfExistsHandler.php b/src/MessageHandler/RemoveDocumentIfExistsHandler.php
@@ -13,6 +13,9 @@
 
 final readonly class RemoveDocumentIfExistsHandler
 {
+    /**
+     * @param ChannelRepositoryInterface<ChannelInterface> $channelRepository
+     */
     public function __construct(
         private ChannelRepositoryInterface $channelRepository,
         private DocumentTypeProviderInterface $documentTypeProvider,

diff --git a/src/MessageHandler/UpsertDocumentHandler.php b/src/MessageHandler/UpsertDocumentHandler.php
@@ -13,6 +13,9 @@
 
 final readonly class UpsertDocumentHandler
 {
+    /**
+     * @param ChannelRepositoryInterface<ChannelInterface> $channelRepository
+     */
     public function __construct(
         private ChannelRepositoryInterface $channelRepository,
         private DocumentTypeProviderInterface $documentTypeProvider,

diff --git a/src/Parser/ElasticsearchProductDocumentParser.php b/src/Parser/ElasticsearchProductDocumentParser.php
@@ -40,6 +40,7 @@ final class ElasticsearchProductDocumentParser implements DocumentParserInterfac
 
     /**
      * @param FactoryInterface<ProductImageInterface> $productImageFactory
+     * @param ProductVariantFactoryInterface<ProductVariantInterface> $productVariantFactory
      * @param FactoryInterface<ChannelPricingInterface> $channelPricingFactory
      * @param FactoryInterface<CatalogPromotionInterface> $catalogPromotionFactory
      * @param FactoryInterface<ProductOptionInterface> $productOptionFactory

diff --git a/tests/Behat/Context/Setup/ElasticsearchContext.php b/tests/Behat/Context/Setup/ElasticsearchContext.php
@@ -12,6 +12,9 @@
 
 final readonly class ElasticsearchContext implements Context
 {
+    /**
+     * @param ChannelRepositoryInterface<ChannelInterface> $channelRepository
+     */
     public function __construct(
         private ChannelRepositoryInterface $channelRepository,
         private DocumentTypeProviderInterface $documentTypeProvider,

diff --git a/tests/Behat/Context/Setup/ProductAttributeContext.php b/tests/Behat/Context/Setup/ProductAttributeContext.php
@@ -24,6 +24,7 @@
      * @param RepositoryInterface<ProductAttributeInterface> $productAttributeRepository
      * @param FactoryInterface<ProductAttributeValueInterface> $productAttributeValueFactory
      * @param FactoryInterface<ProductAttributeTranslationInterface> $productAttributeTranslationFactory
+     * @param AttributeFactoryInterface<ProductAttributeInterface> $productAttributeFactory
      */
     public function __construct(
         private RepositoryInterface $productAttributeRepository,