Pass taxon to sort helper (#5)

* Fix README * Pass taxon to sort helper method --------- Co-authored-by: Lorenzo Ruozzi <[email protected]>
webgriffe · Jul 4, 2024 · 06be08a · 06be08a
1 parent 9e257ad
commit 06be08a
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -44,7 +44,7 @@
 
 6. Make your ProductAttribute and ProductOption entities implements the FilterableInterface. You can implement it by using our ready DoctrineORMFilterableTrait. For example:
    ```php
-use Webgriffe\SyliusElasticsearchPlugin\Doctrine\ORM\FilterableTrait;use Webgriffe\SyliusElasticsearchPlugin\Model\FilterableInterface;
+   use Webgriffe\SyliusElasticsearchPlugin\Doctrine\ORM\FilterableTrait;use Webgriffe\SyliusElasticsearchPlugin\Model\FilterableInterface;
 
    class ProductAttribute implements FilterableInterface
    {

diff --git a/src/Controller/ProductController.php b/src/Controller/ProductController.php
@@ -69,7 +69,7 @@ public function __invoke(Request $request, string $slug): Response
 
         /** @var array<string, string> $sorting */
         $sorting = $request->query->all('sorting');
-        $sorting = $this->sortHelper->retrieveTaxonSorting($sorting);
+        $sorting = $this->sortHelper->retrieveTaxonSorting($taxon, $sorting);
         $size = $request->query->getInt('limit', $this->taxonDefaultPageLimit);
         $page = $request->query->getInt('page', 1);
 

diff --git a/src/Helper/SortHelper.php b/src/Helper/SortHelper.php
@@ -4,14 +4,16 @@
 
 namespace Webgriffe\SyliusElasticsearchPlugin\Helper;
 
+use Sylius\Component\Core\Model\TaxonInterface;
+
 final class SortHelper implements SortHelperInterface
 {
     public function retrieveSearchSorting(array $sortingQueryParams = []): array
     {
         return $sortingQueryParams; // If empty it will sort by _score desc as default
     }
 
-    public function retrieveTaxonSorting(array $sortingQueryParams = []): array
+    public function retrieveTaxonSorting(TaxonInterface $taxon, array $sortingQueryParams = []): array
     {
         if ($sortingQueryParams === []) {
             return ['position' => 'asc'];

diff --git a/src/Helper/SortHelperInterface.php b/src/Helper/SortHelperInterface.php
@@ -4,6 +4,8 @@
 
 namespace Webgriffe\SyliusElasticsearchPlugin\Helper;
 
+use Sylius\Component\Core\Model\TaxonInterface;
+
 interface SortHelperInterface
 {
     /**
@@ -18,5 +20,5 @@ public function retrieveSearchSorting(array $sortingQueryParams = []): array;
      *
      * @return array<string, string>
      */
-    public function retrieveTaxonSorting(array $sortingQueryParams = []): array;
+    public function retrieveTaxonSorting(TaxonInterface $taxon, array $sortingQueryParams = []): array;
 }