Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A ResizeObserver HD-DPI example #371

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

greggman
Copy link
Collaborator

@greggman greggman commented Mar 7, 2024

#356

I'm not sure if adding image-rendering fits here. Maybe that should be a separate example?

@greggman greggman requested a review from kainino0x March 7, 2024 05:20
@greggman greggman force-pushed the resizeobserver-sample branch from ab99174 to b961617 Compare March 7, 2024 08:22
@kainino0x
Copy link
Collaborator

I'm not sure if adding image-rendering fits here. Maybe that should be a separate example?

Probably. The only reason to put it here would be if we want to demo image-rendering at exact scales (like 1/2x, 1/4x of the native display resolution), but I don't think that's needed.

Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sample/resizeObserverHDDPI/index.html Show resolved Hide resolved
sample/resizeObserverHDDPI/main.ts Show resolved Hide resolved
greggman added 2 commits March 8, 2024 12:24
I'm not sure if adding image-rendering fits here. Maybe
that should be a separate example?
@greggman greggman force-pushed the resizeobserver-sample branch from b961617 to 519c8b4 Compare March 8, 2024 20:25
@greggman greggman enabled auto-merge (squash) March 8, 2024 20:25
@greggman greggman merged commit 9044129 into webgpu:main Mar 8, 2024
1 check passed
@greggman greggman deleted the resizeobserver-sample branch March 8, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants