Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize Sample List #358

Merged
merged 22 commits into from
Feb 29, 2024
Merged

Conversation

cmhhelgeson
Copy link
Contributor

@cmhhelgeson cmhhelgeson commented Feb 28, 2024

Refer to #357

image

@cmhhelgeson cmhhelgeson marked this pull request as draft February 28, 2024 19:19
@cmhhelgeson cmhhelgeson marked this pull request as ready for review February 28, 2024 21:32
@cmhhelgeson
Copy link
Contributor Author

This is ready for review, albeit I imagine there will be a lot of discussion around implementation, styling, whether categories should be collapsable, and how various samples should be collected and categorized.

src/components/SampleCategory.module.css Outdated Show resolved Hide resolved
src/components/SampleCategory.module.css Show resolved Hide resolved
src/pages/MainLayout.module.css Outdated Show resolved Hide resolved
src/components/SampleCategory.module.css Show resolved Hide resolved
src/pages/samples/[slug].tsx Show resolved Hide resolved
Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % any open comments

src/components/SampleCategory.module.css Outdated Show resolved Hide resolved
src/pages/samples/[slug].tsx Outdated Show resolved Hide resolved
src/pages/samples/[slug].tsx Show resolved Hide resolved
src/pages/samples/[slug].tsx Outdated Show resolved Hide resolved
src/pages/samples/[slug].tsx Outdated Show resolved Hide resolved
src/pages/samples/[slug].tsx Show resolved Hide resolved
@cmhhelgeson
Copy link
Contributor Author

This is good to go, just need somebody to merge it in.

Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kainino0x kainino0x merged commit 5424f6f into webgpu:main Feb 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants