[pull] master from netdata:master

packaging/installer/netdata-updater.sh

@@ -551,6 +551,10 @@ else:
     commit_date="$(python3 -c "${python_version_check}" < "${commit_check_file}")"
   fi
 
+  if [ -z "${NETDATA_TMPDIR_PATH}" ]; then
+    rm -rf "${ndtmpdir}" >&3 2>&3
+  fi
+
   if [ -z "${commit_date}" ] ; then
     return 0
   elif [ "$(uname)" = "Linux" ]; then
@@ -582,11 +586,13 @@ self_update() {
     if _safe_download "https://raw.githubusercontent.com/netdata/netdata/master/packaging/installer/netdata-updater.sh" ./netdata-updater.sh; then
       chmod +x ./netdata-updater.sh || exit 1
       export ENVIRONMENT_FILE="${ENVIRONMENT_FILE}"
-      force_update=""
-      [ "$NETDATA_FORCE_UPDATE" = "1" ] && force_update="--force-update"
-      interactive=""
-      [ "$INTERACTIVE" = "0" ] && interactive="--non-interactive"
-      exec ./netdata-updater.sh --not-running-from-cron --no-updater-self-update "$force_update" "$interactive" --tmpdir-path "$(pwd)"
+
+      cmd="./netdata-updater.sh --not-running-from-cron --no-updater-self-update"
+      [ "$NETDATA_FORCE_UPDATE" = "1" ] && cmd="$cmd --force-update"
+      [ "$INTERACTIVE" = "0" ] && cmd="$cmd --non-interactive"
+      cmd="$cmd --tmpdir-path $(pwd)"
+
+      exec $cmd
     else
       error "Failed to download newest version of updater script, continuing with current version."
     fi

src/go/plugin/go.d/README.md

@@ -144,7 +144,6 @@ All capabilities are set automatically during Netdata installation using the [of
 | [web_log](https://github.com/netdata/netdata/tree/master/src/go/plugin/go.d/collector/weblog)                        |         Apache/NGINX          |
 | [wireguard](https://github.com/netdata/netdata/tree/master/src/go/plugin/go.d/collector/wireguard)                   |           WireGuard           |
 | [whoisquery](https://github.com/netdata/netdata/tree/master/src/go/plugin/go.d/collector/whoisquery)                 |         Domain Expiry         |
-| [windows](https://github.com/netdata/netdata/tree/master/src/go/plugin/go.d/collector/windows)                       |            Windows            |
 | [x509check](https://github.com/netdata/netdata/tree/master/src/go/plugin/go.d/collector/x509check)                   |     Digital Certificates      |
 | [zfspool](https://github.com/netdata/netdata/tree/master/src/go/plugin/go.d/collector/zfspool)                       |           ZFS Pools           |
 | [zookeeper](https://github.com/netdata/netdata/tree/master/src/go/plugin/go.d/collector/zookeeper)                   |           ZooKeeper           |

src/go/plugin/go.d/collector/init.go

@@ -121,7 +121,6 @@ import (
 	_ "github.com/netdata/netdata/go/plugins/plugin/go.d/collector/w1sensor"
 	_ "github.com/netdata/netdata/go/plugins/plugin/go.d/collector/weblog"
 	_ "github.com/netdata/netdata/go/plugins/plugin/go.d/collector/whoisquery"
-	_ "github.com/netdata/netdata/go/plugins/plugin/go.d/collector/windows"
 	_ "github.com/netdata/netdata/go/plugins/plugin/go.d/collector/wireguard"
 	_ "github.com/netdata/netdata/go/plugins/plugin/go.d/collector/x509check"
 	_ "github.com/netdata/netdata/go/plugins/plugin/go.d/collector/zfspool"