[pull] master from netdata:master

CHANGELOG.md

@@ -6,6 +6,7 @@
 
 **Merged pull requests:**
 
+- fix\(build\): fix building go.d on 32bit [\#19156](https://github.com/netdata/netdata/pull/19156) ([ilyam8](https://github.com/ilyam8))
 - fix\(go.d\): correct sd dir [\#19155](https://github.com/netdata/netdata/pull/19155) ([ilyam8](https://github.com/ilyam8))
 - fix\(go.d\): correct unlockall impl [\#19154](https://github.com/netdata/netdata/pull/19154) ([ilyam8](https://github.com/ilyam8))
 - fix\(go.d\): unlock job files on quit/restart [\#19153](https://github.com/netdata/netdata/pull/19153) ([ilyam8](https://github.com/ilyam8))
@@ -446,7 +447,6 @@
 - Correctly include Windows installer in release creation. [\#18609](https://github.com/netdata/netdata/pull/18609) ([Ferroin](https://github.com/Ferroin))
 - feat: HW req for onprem installation. [\#18608](https://github.com/netdata/netdata/pull/18608) ([M4itee](https://github.com/M4itee))
 - WEB SERVER: retry sending data when errno is EAGAIN [\#18607](https://github.com/netdata/netdata/pull/18607) ([ktsaou](https://github.com/ktsaou))
-- Publish Windows installers on nightly builds. [\#18603](https://github.com/netdata/netdata/pull/18603) ([Ferroin](https://github.com/Ferroin))
 
 ## [v1.47.5](https://github.com/netdata/netdata/tree/v1.47.5) (2024-10-24)
 

CMakeLists.txt

@@ -944,6 +944,10 @@ set(LIBNETDATA_FILES
         src/libnetdata/os/system_memory.h
         src/libnetdata/socket/nd-poll.c
         src/libnetdata/socket/nd-poll.h
+        src/libnetdata/locks/spinlock.c
+        src/libnetdata/locks/spinlock.h
+        src/libnetdata/locks/rw-spinlock.c
+        src/libnetdata/locks/rw-spinlock.h
 )
 
 set(LIBH2O_FILES
@@ -1037,8 +1041,8 @@ set(DAEMON_FILES
         src/daemon/daemon.h
         src/daemon/libuv_workers.c
         src/daemon/libuv_workers.h
-        src/daemon/telemetry/telemetry.c
-        src/daemon/telemetry/telemetry.h
+        src/daemon/pulse/pulse.c
+        src/daemon/pulse/pulse.h
         src/daemon/analytics.c
         src/daemon/analytics.h
         src/daemon/main.c
@@ -1068,36 +1072,36 @@ set(DAEMON_FILES
         src/daemon/dyncfg/dyncfg-internals.h
         src/daemon/dyncfg/dyncfg-intercept.c
         src/daemon/dyncfg/dyncfg-tree.c
-        src/daemon/telemetry/telemetry-http-api.c
-        src/daemon/telemetry/telemetry-http-api.h
-        src/daemon/telemetry/telemetry-queries.c
-        src/daemon/telemetry/telemetry-queries.h
-        src/daemon/telemetry/telemetry-ingestion.c
-        src/daemon/telemetry/telemetry-ingestion.h
-        src/daemon/telemetry/telemetry-ml.c
-        src/daemon/telemetry/telemetry-ml.h
-        src/daemon/telemetry/telemetry-gorilla.c
-        src/daemon/telemetry/telemetry-gorilla.h
-        src/daemon/telemetry/telemetry-daemon.c
-        src/daemon/telemetry/telemetry-daemon.h
-        src/daemon/telemetry/telemetry-daemon-memory.c
-        src/daemon/telemetry/telemetry-daemon-memory.h
-        src/daemon/telemetry/telemetry-sqlite3.c
-        src/daemon/telemetry/telemetry-sqlite3.h
-        src/daemon/telemetry/telemetry-dbengine.c
-        src/daemon/telemetry/telemetry-dbengine.h
-        src/daemon/telemetry/telemetry-string.c
-        src/daemon/telemetry/telemetry-string.h
-        src/daemon/telemetry/telemetry-heartbeat.c
-        src/daemon/telemetry/telemetry-heartbeat.h
-        src/daemon/telemetry/telemetry-dictionary.c
-        src/daemon/telemetry/telemetry-dictionary.h
-        src/daemon/telemetry/telemetry-workers.c
-        src/daemon/telemetry/telemetry-workers.h
-        src/daemon/telemetry/telemetry-trace-allocations.c
-        src/daemon/telemetry/telemetry-trace-allocations.h
-        src/daemon/telemetry/telemetry-aral.c
-        src/daemon/telemetry/telemetry-aral.h
+        src/daemon/pulse/pulse-http-api.c
+        src/daemon/pulse/pulse-http-api.h
+        src/daemon/pulse/pulse-queries.c
+        src/daemon/pulse/pulse-queries.h
+        src/daemon/pulse/pulse-ingestion.c
+        src/daemon/pulse/pulse-ingestion.h
+        src/daemon/pulse/pulse-ml.c
+        src/daemon/pulse/pulse-ml.h
+        src/daemon/pulse/pulse-gorilla.c
+        src/daemon/pulse/pulse-gorilla.h
+        src/daemon/pulse/pulse-daemon.c
+        src/daemon/pulse/pulse-daemon.h
+        src/daemon/pulse/pulse-daemon-memory.c
+        src/daemon/pulse/pulse-daemon-memory.h
+        src/daemon/pulse/pulse-sqlite3.c
+        src/daemon/pulse/pulse-sqlite3.h
+        src/daemon/pulse/pulse-dbengine.c
+        src/daemon/pulse/pulse-dbengine.h
+        src/daemon/pulse/pulse-string.c
+        src/daemon/pulse/pulse-string.h
+        src/daemon/pulse/pulse-heartbeat.c
+        src/daemon/pulse/pulse-heartbeat.h
+        src/daemon/pulse/pulse-dictionary.c
+        src/daemon/pulse/pulse-dictionary.h
+        src/daemon/pulse/pulse-workers.c
+        src/daemon/pulse/pulse-workers.h
+        src/daemon/pulse/pulse-trace-allocations.c
+        src/daemon/pulse/pulse-trace-allocations.h
+        src/daemon/pulse/pulse-aral.c
+        src/daemon/pulse/pulse-aral.h
         src/daemon/config/netdata-conf-db.c
         src/daemon/config/netdata-conf-db.h
         src/daemon/config/netdata-conf.h
@@ -1543,6 +1547,8 @@ set(STREAMING_PLUGIN_FILES
         src/streaming/stream-receiver-connection.c
         src/streaming/stream-sender-commit.h
         src/streaming/stream-traffic-types.h
+        src/streaming/stream-circular-buffer.c
+        src/streaming/stream-circular-buffer.h
 )
 
 set(WEB_PLUGIN_FILES

packaging/version

@@ -1 +1 @@
-v2.0.0-182-nightly
+v2.0.0-184-nightly

src/aclk/aclk_query.c

@@ -16,7 +16,7 @@ struct pending_req_list {
 };
 
 static struct pending_req_list *pending_req_list_head = NULL;
-static SPINLOCK pending_req_list_lock = NETDATA_SPINLOCK_INITIALIZER;
+static SPINLOCK pending_req_list_lock = SPINLOCK_INITIALIZER;
 
 void aclk_config_get_query_scope(void) {
     const char *s = config_get(CONFIG_SECTION_CLOUD, "scope", "full");

src/aclk/https_client.c

@@ -6,7 +6,7 @@
 
 #include "aclk_util.h"
 
-#include "daemon/telemetry/telemetry.h"
+#include "daemon/pulse/pulse.h"
 
 static const char *http_req_type_to_str(http_req_type_t req) {
     switch (req) {

src/claim/claim-with-api.c

@@ -361,7 +361,7 @@ static bool send_curl_request(const char *machine_guid, const char *hostname, co
 }
 
 bool claim_agent(const char *url, const char *token, const char *rooms, const char *proxy, bool insecure) {
-    static SPINLOCK spinlock = NETDATA_SPINLOCK_INITIALIZER;
+    static SPINLOCK spinlock = SPINLOCK_INITIALIZER;
     spinlock_lock(&spinlock);
 
     if (!check_and_generate_certificates()) {
@@ -411,7 +411,7 @@ bool claim_agent_from_environment(void) {
 
 bool claim_agent_from_claim_conf(void) {
     static struct config claim_config = APPCONFIG_INITIALIZER;
-    static SPINLOCK spinlock = NETDATA_SPINLOCK_INITIALIZER;
+    static SPINLOCK spinlock = SPINLOCK_INITIALIZER;
     bool ret = false;
 
     spinlock_lock(&spinlock);

src/claim/claim_id.c

@@ -7,7 +7,7 @@ static struct {
     ND_UUID claim_uuid;
     ND_UUID claim_uuid_saved;
 } claim = {
-    .spinlock = NETDATA_SPINLOCK_INITIALIZER,
+    .spinlock = SPINLOCK_INITIALIZER,
 };
 
 void claim_id_clear_previous_working(void) {

src/collectors/cgroups.plugin/cgroup-network.c

@@ -554,7 +554,7 @@ static void read_from_spawned(SPAWN_INSTANCE *si, const char *name __maybe_unuse
     }
     fclose(fp);
     spawn_server_instance_read_fd_unset(si);
-    spawn_server_exec_kill(spawn_server, si);
+    spawn_server_exec_kill(spawn_server, si, 0);
 }
 
 void detect_veth_interfaces_spawn(pid_t pid) {

src/collectors/ebpf.plugin/ebpf_apps.c

@@ -307,7 +307,7 @@ int ebpf_read_apps_groups_conf(struct ebpf_target **agdt, struct ebpf_target **a
 #define MAX_CMDLINE 16384
 
 Pvoid_t ebpf_pid_judyL = NULL;
-SPINLOCK ebpf_pid_spinlock = NETDATA_SPINLOCK_INITIALIZER;
+SPINLOCK ebpf_pid_spinlock = SPINLOCK_INITIALIZER;
 
 void ebpf_pid_del(pid_t pid)
 {

src/collectors/freeipmi.plugin/freeipmi_plugin.c

@@ -1959,7 +1959,7 @@ int main (int argc, char **argv) {
     struct ipmi_collection_thread sensors_data = {
             .type = IPMI_COLLECT_TYPE_SENSORS,
             .freq_s = update_every,
-            .spinlock = NETDATA_SPINLOCK_INITIALIZER,
+            .spinlock = SPINLOCK_INITIALIZER,
             .debug = debug,
             .state = {
                     .debug = debug,
@@ -1974,7 +1974,7 @@ int main (int argc, char **argv) {
     }, sel_data = {
             .type = IPMI_COLLECT_TYPE_SEL,
             .freq_s = update_every_sel,
-            .spinlock = NETDATA_SPINLOCK_INITIALIZER,
+            .spinlock = SPINLOCK_INITIALIZER,
             .debug = debug,
             .state = {
                     .debug = debug,

src/collectors/proc.plugin/proc_net_dev_renames.c

@@ -15,7 +15,7 @@ static void dictionary_netdev_rename_delete_cb(const DICTIONARY_ITEM *item __may
 }
 
 void netdev_renames_init(void) {
-    static SPINLOCK spinlock = NETDATA_SPINLOCK_INITIALIZER;
+    static SPINLOCK spinlock = SPINLOCK_INITIALIZER;
 
     spinlock_lock(&spinlock);
     if(!netdev_renames) {

src/collectors/statsd.plugin/statsd.c

@@ -2654,7 +2654,7 @@ void *statsd_main(void *ptr) {
     RRDSET *st_pcharts = NULL;
     RRDDIM *rd_pcharts = NULL;
 
-    if(telemetry_enabled) {
+    if(pulse_enabled) {
         st_metrics = rrdset_create_localhost(
             "netdata",
             "statsd_metrics",
@@ -2851,7 +2851,7 @@ void *statsd_main(void *ptr) {
         if(unlikely(!service_running(SERVICE_COLLECTORS)))
             break;
 
-        if(telemetry_enabled) {
+        if(pulse_enabled) {
             rrddim_set_by_pointer(st_metrics, rd_metrics_gauge,        (collected_number)statsd.gauges.metrics);
             rrddim_set_by_pointer(st_metrics, rd_metrics_counter,      (collected_number)statsd.counters.metrics);
             rrddim_set_by_pointer(st_metrics, rd_metrics_timer,        (collected_number)statsd.timers.metrics);

src/collectors/systemd-journal.plugin/systemd-journal-files.c

@@ -704,7 +704,7 @@ int filenames_compar(const void *a, const void *b) {
 }
 
 void journal_files_registry_update(void) {
-    static SPINLOCK spinlock = NETDATA_SPINLOCK_INITIALIZER;
+    static SPINLOCK spinlock = SPINLOCK_INITIALIZER;
 
     if(spinlock_trylock(&spinlock)) {
         usec_t scan_monotonic_ut = now_monotonic_usec();

src/collectors/tc.plugin/plugin_tc.c

@@ -1135,7 +1135,7 @@ void *tc_main(void *ptr) {
         }
 
         // fgets() failed or loop broke
-        int code = spawn_popen_kill(tc_child_instance);
+        int code = spawn_popen_kill(tc_child_instance, 0);
         tc_child_instance = NULL;
 
         if(unlikely(device)) {

src/collectors/windows-events.plugin/windows-events-providers.c

@@ -75,7 +75,7 @@ static struct {
     ARAL *aral_providers;
     ARAL *aral_handles;
 } pbc = {
-        .spinlock = NETDATA_SPINLOCK_INITIALIZER,
+        .spinlock = SPINLOCK_INITIALIZER,
 };
 
 static void provider_load_list(PROVIDER_META_HANDLE *h, WEVT_VARIANT *content, WEVT_VARIANT *property,

src/collectors/windows-events.plugin/windows-events-sources.c

@@ -484,7 +484,7 @@ WEVT_SOURCE_TYPE categorize_channel(const wchar_t *channel_path, const char **pr
 }
 
 void wevt_sources_scan(void) {
-    static SPINLOCK spinlock = NETDATA_SPINLOCK_INITIALIZER;
+    static SPINLOCK spinlock = SPINLOCK_INITIALIZER;
     LPWSTR channel = NULL;
     EVT_HANDLE hChannelEnum = NULL;
 

src/daemon/buildinfo.c

@@ -1263,7 +1263,7 @@ __attribute__((constructor)) void initialize_build_info(void) {
 int get_system_info(struct rrdhost_system_info *system_info);
 static void populate_system_info(void) {
     static bool populated = false;
-    static SPINLOCK spinlock = NETDATA_SPINLOCK_INITIALIZER;
+    static SPINLOCK spinlock = SPINLOCK_INITIALIZER;
 
     if(populated)
         return;

src/daemon/common.h

@@ -19,7 +19,7 @@ extern "C" {
 #include "daemon/config/netdata-conf.h"
 #include "daemon/dyncfg/dyncfg.h"
 
-#include "daemon/telemetry/telemetry.h"
+#include "daemon/pulse/pulse.h"
 
 // health monitoring and alarm notifications
 #include "health/health.h"

src/daemon/config/netdata-conf-backwards-compatibility.c

@@ -181,14 +181,26 @@ void netdata_conf_backwards_compatibility(void) {
     config_move(CONFIG_SECTION_GLOBAL,  "enable zero metrics",
                 CONFIG_SECTION_DB,      "enable zero metrics");
 
-    config_move("global statistics",        "update every",
-                CONFIG_SECTION_TELEMETRY,   "update every");
+    // ----------------------------------------------------------------------------------------------------------------
+    // global statistics -> telemetry -> pulse
 
     config_move(CONFIG_SECTION_PLUGINS, "netdata monitoring",
-                CONFIG_SECTION_PLUGINS, "netdata telemetry");
+                CONFIG_SECTION_PLUGINS, "netdata pulse");
+
+    config_move(CONFIG_SECTION_PLUGINS, "netdata telemetry",
+                CONFIG_SECTION_PLUGINS, "netdata pulse");
 
     config_move(CONFIG_SECTION_PLUGINS, "netdata monitoring extended",
-                CONFIG_SECTION_TELEMETRY, "extended telemetry");
+                CONFIG_SECTION_PULSE,   "extended");
+
+    config_move("telemetry",            "extended telemetry",
+                CONFIG_SECTION_PULSE,   "extended");
+
+    config_move("global statistics",    "update every",
+                CONFIG_SECTION_PULSE,   "update every");
+
+    config_move("telemetry",            "update every",
+                CONFIG_SECTION_PULSE,   "update every");
 
 
     // ----------------------------------------------------------------------------------------------------------------

src/daemon/config/netdata-conf-db.c

@@ -145,8 +145,11 @@ void netdata_conf_dbengine_init(const char *hostname) {
     OS_SYSTEM_MEMORY sm = os_system_memory(true);
     if(sm.ram_total_bytes && sm.ram_available_bytes && sm.ram_total_bytes > sm.ram_available_bytes) {
         // calculate the default out of memory protection size
+        uint64_t keep_free = sm.ram_total_bytes / 10;
+        if(keep_free > 5ULL * 1024 * 1024 * 1024)
+            keep_free = 5ULL * 1024 * 1024 * 1024;
         char buf[64];
-        size_snprintf(buf, sizeof(buf), sm.ram_total_bytes / 10, "B", false);
+        size_snprintf(buf, sizeof(buf), keep_free, "B", false);
         size_parse(buf, &dbengine_out_of_memory_protection, "B");
     }
 

src/daemon/main.c

@@ -1424,14 +1424,14 @@ int netdata_main(int argc, char **argv) {
             default_stacksize = 1 * 1024 * 1024;
 
 #ifdef NETDATA_INTERNAL_CHECKS
-        telemetry_enabled = true;
-        telemetry_extended_enabled = true;
+        pulse_enabled = true;
+        pulse_extended_enabled = true;
 #endif
 
-        telemetry_extended_enabled =
-            config_get_boolean(CONFIG_SECTION_TELEMETRY, "extended telemetry", telemetry_extended_enabled);
+        pulse_extended_enabled =
+            config_get_boolean(CONFIG_SECTION_PULSE, "extended", pulse_extended_enabled);
 
-        if(telemetry_extended_enabled)
+        if(pulse_extended_enabled)
             // this has to run before starting any other threads that use workers
             workers_utilization_enable();