[pull] master from netdata:master

.codacy.yml

@@ -6,19 +6,19 @@ exclude_paths:
   - src/collectors/python.d.plugin/python_modules/third_party/**
   - contrib/**
   - packaging/makeself/**
-  - web/gui/css/**
-  - web/gui/lib/**
-  - web/gui/old/**
-  - web/gui/src/**
-  - web/gui/v1/**
-  - web/gui/v2/**
-  - web/gui/main.js
+  - src/web/gui/css/**
+  - src/web/gui/lib/**
+  - src/web/gui/old/**
+  - src/web/gui/src/**
+  - src/web/gui/v1/**
+  - src/web/gui/v2/**
+  - src/web/gui/main.js
   - tests/**
   - aclk/tests/**
   - src/libnetdata/libjudy/**
   - src/database/sqlite/sqlite3.c
   - src/ml/dlib/**
-  - web/server/h2o/libh2o/**
+  - src/web/server/h2o/libh2o/**
   - build/**
   - build_external/**
   - packaging/**

.codeclimate.yml

@@ -84,10 +84,10 @@ exclude_patterns:
   - ".githooks/"
   - "tests/"
   - "m4/"
-  - "web/css/"
-  - "web/lib/"
-  - "web/fonts/"
-  - "web/old/"
+  - "src/web/css/"
+  - "src/web/lib/"
+  - "src/web/fonts/"
+  - "src/web/old/"
   - "collectors/python.d.plugin/python_modules/pyyaml2/"
   - "collectors/python.d.plugin/python_modules/pyyaml3/"
   - "collectors/python.d.plugin/python_modules/urllib3/"

.github/CODEOWNERS

@@ -19,6 +19,7 @@ src/exporting/ @thiagoftsm
 src/daemon/ @thiagoftsm @vkalintiris
 src/database/ @thiagoftsm @vkalintiris
 docs/ @tkatsoulas @Ancairon
+src/go/ @ilyam8
 src/health/ @thiagoftsm @vkalintiris
 src/health/health.d/ @thiagoftsm
 src/health/notifications/ @Ferroin @thiagoftsm
@@ -29,8 +30,8 @@ src/registry/ @novykh
 src/streaming/ @thiagoftsm
 system/ @Ferroin @tkatsoulas
 tests/ @Ferroin @vkalintiris @tkatsoulas
-web/ @thiagoftsm @vkalintiris
-web/gui/ @novykh
+src/web/ @thiagoftsm @vkalintiris
+src/web/gui/ @novykh
 src/logsmanagement/ @thiagoftsm
 
 # Ownership by filetype (overwrites ownership by directory)

.github/codeql/python-config.yml

@@ -1,10 +1,9 @@
 paths-ignore:
   - .github
   - build_external/
-  - ml/dlib
-  - ml/json
+  - src/ml/dlib
   - tests/api
-  - web/gui
+  - src/web/gui
   - src/collectors/python.d.plugin/python_modules/pyyaml*
   - src/collectors/python.d.plugin/python_modules/third_party
   - src/collectors/python.d.plugin/python_modules/urllib3

.github/dependabot.yml

@@ -7,3 +7,9 @@ updates:
     labels:
       - "no changelog"
       - "area/ci"
+  - package-ecosystem: gomod
+    directory: /src/go/collectors/go.d.plugin
+    schedule:
+      interval: weekly
+    labels:
+      - "area/go"

.github/labeler.yml

@@ -66,7 +66,7 @@ area/docs:
               - "*.md"
               - "**/*.md"
               - "**/*.mdx"
-              - diagrams/**
+              - docs/diagrams/**
 
 # -----------------collectors----------------------
 
@@ -75,6 +75,7 @@ area/collectors:
       - changed-files:
           - any-glob-to-any-file:
               - src/collectors/**
+              - src/go/collectors/go.d.plugin/**
 
 collectors/plugins.d:
   - any:
@@ -136,6 +137,12 @@ collectors/freeipmi:
           - any-glob-to-any-file:
               - src/collectors/freeipmi.plugin/**
 
+collectors/go.d.plugin:
+  - any:
+      - changed-files:
+          - any-glob-to-any-file:
+              - src/go/collectors/go.d.plugin/**
+
 collectors/idlejitter:
   - any:
       - changed-files:
@@ -216,6 +223,12 @@ collectors/xenstat:
 
 # ----------------/collectors----------------------
 
+area/go:
+  - any:
+      - changed-files:
+          - any-glob-to-any-file:
+              - src/go/**
+
 area/health:
   - any:
       - changed-files:
@@ -265,14 +278,12 @@ area/tests:
               - tests/**
               - src/daemon/unit_test*
               - coverity-scan.sh
-              - cppcheck.sh
-              - netdata.cppcheck
 
 area/web:
   - any:
       - changed-files:
           - any-glob-to-any-file:
-              - web/**
+              - src/web/**
 
 area/logs-management:
   - any:

.github/workflows/build.yml

@@ -61,16 +61,17 @@ jobs:
             src/aclk/aclk-schemas/
             src/ml/dlib/
             src/fluent-bit/
-            web/server/h2o/libh2o/
+            src/web/server/h2o/libh2o/
           files_ignore: |
             netdata.spec.in
             **/*.md
-      - name: List all modified files in pattern
+      - name: List all changed files in pattern
+        continue-on-error: true
         env:
-          ALL_MODIFIED_FILES: ${{ steps.check-files.outputs.all_modified_files }}
+          ALL_CHANGED_FILES: ${{ steps.check-files.outputs.all_changed_files }}
         run: |
-          for file in ${ALL_MODIFIED_FILES}; do
-            echo "$file was modified"
+          for file in ${ALL_CHANGED_FILES}; do
+            echo "$file was changed"
           done
       - name: Check Run
         id: check-run

.github/workflows/checks.yml

@@ -49,16 +49,17 @@ jobs:
             src/aclk/aclk-schemas/
             src/ml/dlib/
             src/fluent-bit/
-            web/server/h2o/libh2o/
+            src/web/server/h2o/libh2o/
           files_ignore: |
             netdata.spec.in
             **/*.md
-      - name: List all modified files in pattern
+      - name: List all changed files in pattern
+        continue-on-error: true
         env:
-          ALL_MODIFIED_FILES: ${{ steps.check-files.outputs.all_modified_files }}
+          ALL_CHANGED_FILES: ${{ steps.check-files.outputs.all_changed_files }}
         run: |
-          for file in ${ALL_MODIFIED_FILES}; do
-            echo "$file was modified"
+          for file in ${ALL_CHANGED_FILES}; do
+            echo "$file was changed"
           done
       - name: Check Run
         id: check-run

.github/workflows/codeql.yml

@@ -21,6 +21,7 @@ jobs:
     outputs:
       cpp: ${{ steps.cpp.outputs.run }}
       python: ${{ steps.python.outputs.run }}
+      go: ${{ steps.go.outputs.run }}
     steps:
       - name: Clone repository
         uses: actions/checkout@v4
@@ -66,6 +67,19 @@ jobs:
           else
             echo "run=true" >> "${GITHUB_OUTPUT}"
           fi
+      - name: Check for Go changes
+        id: go
+        run: |
+          if [ "${{ steps.always.outputs.run }}" = "false" ]; then
+            if git diff --name-only origin/${{ github.base_ref }} HEAD | grep -Eq 'src/go/*\.go' ; then
+              echo "run=true" >> "${GITHUB_OUTPUT}"
+              echo '::notice::Go code has changed, need to run CodeQL.'
+            else
+              echo "run=false" >> "${GITHUB_OUTPUT}"
+            fi
+          else
+            echo "run=true" >> "${GITHUB_OUTPUT}"
+          fi
 
   analyze-cpp:
     name: Analyze C/C++
@@ -116,3 +130,33 @@ jobs:
         uses: github/codeql-action/analyze@v3
         with:
           category: "/language:python"
+
+  analyze-go:
+    name: Analyze Go
+    runs-on: ubuntu-latest
+    needs: prepare
+    if: needs.prepare.outputs.go == 'true'
+    strategy:
+      matrix:
+        tree:
+          - src/go/collectors/go.d.plugin
+    permissions:
+      security-events: write
+    steps:
+      - name: Git clone repository
+        uses: actions/checkout@v4
+        with:
+          submodules: recursive
+          fetch-depth: 0
+      - name: Initialize CodeQL
+        uses: github/codeql-action/init@v3
+        with:
+          languages: go
+      - name: Autobuild
+        uses: github/codeql-action/autobuild@v3
+        with:
+          working-directory: ${{ matrix.tree }}
+      - name: Run CodeQL
+        uses: github/codeql-action/analyze@v3
+        with:
+          category: "/language:go"

.github/workflows/dashboard-pr.yml

@@ -25,7 +25,7 @@ jobs:
       - name: Update Files
         id: update
         run: |
-          web/gui/bundle_dashboard_v1.py ${{ github.event.inputs.dashboard_version }}
+          src/web/gui/bundle_dashboard_v1.py ${{ github.event.inputs.dashboard_version }}
       - name: Create Pull Request
         id: pr
         uses: peter-evans/create-pull-request@v6

.github/workflows/docker.yml

@@ -55,16 +55,17 @@ jobs:
             src/aclk/aclk-schemas/
             src/ml/dlib/
             src/fluent-bit/
-            web/server/h2o/libh2o/
+            src/web/server/h2o/libh2o/
           files_ignore: |
             netdata.spec.in
             **/*.md
-      - name: List all modified files in pattern
+      - name: List all changed files in pattern
+        continue-on-error: true
         env:
-          ALL_MODIFIED_FILES: ${{ steps.check-files.outputs.all_modified_files }}
+          ALL_CHANGED_FILES: ${{ steps.check-files.outputs.all_changed_files }}
         run: |
-          for file in ${ALL_MODIFIED_FILES}; do
-            echo "$file was modified"
+          for file in ${ALL_CHANGED_FILES}; do
+            echo "$file was changed"
           done
       - name: Check Run
         id: check-run

.github/workflows/packaging.yml

@@ -65,15 +65,16 @@ jobs:
             src/aclk/aclk-schemas/
             src/ml/dlib/
             src/fluent-bit/
-            web/server/h2o/libh2o/
+            src/web/server/h2o/libh2o/
           files_ignore: |
             **/*.md
-      - name: List all modified files in pattern
+      - name: List all changed files in pattern
+        continue-on-error: true
         env:
-          ALL_MODIFIED_FILES: ${{ steps.check-files.outputs.all_modified_files }}
+          ALL_CHANGED_FILES: ${{ steps.check-files.outputs.all_changed_files }}
         run: |
-          for file in ${ALL_MODIFIED_FILES}; do
-            echo "$file was modified"
+          for file in ${ALL_CHANGED_FILES}; do
+            echo "$file was changed"
           done
       - name: Check Run
         id: check-run

.github/workflows/review.yml

@@ -17,6 +17,7 @@ jobs:
       actionlint: ${{ steps.actionlint.outputs.run }}
       clangformat: ${{ steps.clangformat.outputs.run }}
       flake8: ${{ steps.flake8.outputs.run }}
+      golangci-lint: ${{ steps.golangci-lint.outputs.run }}
       hadolint: ${{ steps.hadolint.outputs.run }}
       shellcheck: ${{ steps.shellcheck.outputs.run }}
       yamllint: ${{ steps.yamllint.outputs.run }}
@@ -59,6 +60,17 @@ jobs:
           else
             echo "run=false" >> "${GITHUB_OUTPUT}"
           fi
+      - name: Check files for golangci-lint
+        id: golangci-lint
+        run: |
+          if [ "${{ contains(github.event.pull_request.labels.*.name, 'run-ci/golangci-lint') }}" = "true" ]; then
+            echo "run=true" >> "${GITHUB_OUTPUT}"
+          elif git diff --name-only origin/${{ github.base_ref }} HEAD -- | grep -Eq '.*\.go' ; then
+            echo "run=true" >> $GITHUB_OUTPUT
+            echo 'Go code has changed, need to run golangci-lint.'
+          else
+            echo "run=false" >> $GITHUB_OUTPUT
+          fi
       - name: Check files for hadolint
         id: hadolint
         run: |
@@ -164,6 +176,26 @@ jobs:
           github_token: ${{ secrets.GITHUB_TOKEN }}
           reporter: github-pr-check
 
+  golangci-lint:
+    name: golangci-lint
+    needs: prep-review
+    if: needs.prep-review.outputs.golangci-lint == 'true'
+    strategy:
+      matrix:
+        tree:
+          - src/go/collectors/go.d.plugin
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+      - name: Run golangci-lint
+        uses: reviewdog/action-golangci-lint@v2
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          reporter: github-pr-check
+          golangci_lint_flags: '--timeout=10m'
+          workdir: ${{ matrix.tree }}
+
   hadolint:
     name: hadolint
     needs: prep-review