[pull] master from netdata:master #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* Run the agent as a Windows service.
This commit contains the boilerplate code for running the agent as a
Windows service.
We start the agent's main as a separate thread, although this is not
strictly required based on my experiments. We need similar logic for
calling netdata's exit function when someone wants to stop the agent.
However, at this point we need to resolve the issue of gaps when
running the agent as a service. It seems that sleeping for one second
with `sleep(1)`, actually sleeps for 2 to 4 seconds on my setup.
Once we resolve this, the work that remains concerns packaging: ie.
installing the binaries at the proper places so that the relevant
DLLs are found.
To test this PR you need to:
- Build the agent: ./packaging/utils/compile-on-windows.sh
- Install the files: `ninja -C build/ install`
- Copy the main binary: `cp ./build/netdata /usr/bin/`
- (Only once) Create the netdata service: `sc.exe config Netdata binPath="C:\msys64\usr\bin\netdata"`
- Start the service: `sc.exe start Netdata`
A couple notes:
- The health and the spawn client have been disabled for the time
being. They will be re-enabled once we finish the agent-as-service
issue and the packaging.
- Last time I checked, the agent crashes after a while when using
dbengine. In order to have something that works correctly, you
should specify memory-mode ram in your netdata.conf.
* Add windows version for sleep_usec_with_now
* Split install prefix from runtime prefix
These paths are always the same for non-Windows
systems. On Windows, RFS is the top-level
installation path.
With the current setup, Netdata will be installed
at C:\msys64\opt\netdata at packaging time. However,
the layout of the application means that when the
agent starts, it'll look as if everything was installed
at /.
* Do not use mold linker on Windows.
* Use modern UI for installer.
* Make the service delayed-auto
* Use mutexes instead of spinlocks.
* Update service handling logic.
* Add proper ifdefs for spinlock implementation.
* Initialize analytics spinlock
* Add a macro to build the agent as regular cli tool.
* Add makensis dependency
* Let installer know it's installing Netdata.
* Disable pluginsd on Windows
When pluginsd is enabled, the agent freezes approximately
20% of the time during startup.
* Add service description.
* Return pthread_join result
* Print tag when we fail to join a thread.
* Do not use mutexes instead of spinlocks.
* Assorted changes to service/main code.
* Rework service functions.
With the current implementation we are not getting any
MUTEX_LOCK errors and thread joining succeeds.
The only case where joining fails is the parallel initialization
of dbengine threads, which we can easily avoid by serializing
the initialization step.
* Rework main functions
This will allow someone to run the agent either as a service
or as a command-line tool.
* Change runtime prefix only when building for packaging.
* Install binaries and dlls.
* Make netdata claiming through UI work correctly.
* Fix netdata path
* restruture go.d * update gitignore * update ci files * update gen_docs_integrations.py * update link in go.d conf files * update go.d modules metadata files * update metadata files * update packaging * add log files * integrations commit * update get-go-version.py * go fmt * fix packaging * update go.d readme --------- Co-authored-by: Fotis Voutsas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )