Improved query target cleanup (netdata#17038)

Clear smh to avoid possible double metric release
webfutureiorepo · Feb 20, 2024 · e1eca05 · e1eca05
1 parent 58464f5
commit e1eca05
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/database/contexts/query_target.c b/src/database/contexts/query_target.c
@@ -346,8 +346,10 @@ static bool query_metric_add(QUERY_TARGET_LOCALS *qtl, QUERY_NODE *qn, QUERY_CON
 
     // cleanup anything we allocated to the retention we will not use
     for(size_t tier = 0; tier < storage_tiers ;tier++) {
-        if (tier_retention[tier].smh)
+        if (tier_retention[tier].smh) {
             tier_retention[tier].eng->api.metric_release(tier_retention[tier].smh);
+            tier_retention[tier].smh = NULL;
+        }
     }
 
     return false;