Skip to content

Commit

Permalink
fix prometeus export: missing comma before "instance" label (netdata#…
Browse files Browse the repository at this point in the history
  • Loading branch information
ilyam8 authored Jul 2, 2024
1 parent ef58162 commit c573ad7
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/exporting/prometheus/prometheus.c
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ static int print_host_variables_callback(const DICTIONARY_ITEM *item __maybe_unu
opts->prefix,
opts->name,
label_pre,
opts->labels,
(opts->labels[0] == ',') ? &opts->labels[1] : opts->labels,
label_post,
value,
opts->now * 1000ULL);
Expand All @@ -414,7 +414,7 @@ static int print_host_variables_callback(const DICTIONARY_ITEM *item __maybe_unu
opts->prefix,
opts->name,
label_pre,
opts->labels,
(opts->labels[0] == ',') ? &opts->labels[1] : opts->labels,
label_post,
value);

Expand Down Expand Up @@ -875,7 +875,7 @@ static void rrd_stats_api_v1_charts_allmetrics_prometheus(
.host = host,
.wb = wb,
.plabels_buffer = plabels_buffer,
.labels = (labels[0] == ',') ? &labels[1] : labels,
.labels = labels, // FIX: very misleading name and poor implementation of adding the "instance" label
.exporting_options = exporting_options,
.output_options = output_options,
.prefix = prefix,
Expand Down

0 comments on commit c573ad7

Please sign in to comment.