Skip to content

Commit

Permalink
Remove RRDSET_FLAG_DETAIL. (netdata#18837)
Browse files Browse the repository at this point in the history
  • Loading branch information
@vkalintiris
vkalintiris authored Oct 21, 2024
1 parent decaca5 commit ac76c5f
Show file tree
Hide file tree
Showing 35 changed files with 5 additions and 253 deletions.
2 changes: 0 additions & 2 deletions src/collectors/common-contexts/disk-avgsz.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ static inline void common_disk_avgsz(ND_DISK_AVGSZ *d, const char *id, const cha
, RRDSET_TYPE_AREA
);

rrdset_flag_set(d->st_avgsz, RRDSET_FLAG_DETAIL);

d->rd_avgsz_reads = rrddim_add(d->st_avgsz, "reads", NULL, 1, 1024, RRD_ALGORITHM_ABSOLUTE);
d->rd_avgsz_writes = rrddim_add(d->st_avgsz, "writes", NULL, -1, 1024, RRD_ALGORITHM_ABSOLUTE);

Expand Down
2 changes: 0 additions & 2 deletions src/collectors/common-contexts/disk-await.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ static inline void common_disk_await(ND_DISK_AWAIT *d, const char *id, const cha
, RRDSET_TYPE_LINE
);

rrdset_flag_set(d->st_await, RRDSET_FLAG_DETAIL);

d->rd_await_reads = rrddim_add(d->st_await, "reads", NULL, 1, 1000, RRD_ALGORITHM_ABSOLUTE);
d->rd_await_writes = rrddim_add(d->st_await, "writes", NULL, -1, 1000, RRD_ALGORITHM_ABSOLUTE);

Expand Down
2 changes: 0 additions & 2 deletions src/collectors/common-contexts/disk-busy.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ static inline void common_disk_busy(ND_DISK_BUSY *d, const char *id, const char
, RRDSET_TYPE_AREA
);

rrdset_flag_set(d->st_busy, RRDSET_FLAG_DETAIL);

d->rd_busy = rrddim_add(d->st_busy, "busy", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);

if(cb)
Expand Down
2 changes: 0 additions & 2 deletions src/collectors/common-contexts/disk-iotime.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ static inline void common_disk_iotime(ND_DISK_IOTIME *d, const char *id, const c
, RRDSET_TYPE_AREA
);

rrdset_flag_set(d->st_iotime, RRDSET_FLAG_DETAIL);

d->rd_reads_ms = rrddim_add(d->st_iotime, "reads", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
d->rd_writes_ms = rrddim_add(d->st_iotime, "writes", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);

Expand Down
2 changes: 0 additions & 2 deletions src/collectors/common-contexts/disk-svctm.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ static inline void common_disk_svctm(ND_DISK_SVCTM *d, const char *id, const cha
, RRDSET_TYPE_LINE
);

rrdset_flag_set(d->st_svctm, RRDSET_FLAG_DETAIL);

d->rd_svctm = rrddim_add(d->st_svctm, "svctm", NULL, 1, 1000, RRD_ALGORITHM_ABSOLUTE);

if(cb)
Expand Down
2 changes: 0 additions & 2 deletions src/collectors/common-contexts/disk-util.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ static inline void common_disk_util(ND_DISK_UTIL *d, const char *id, const char
, RRDSET_TYPE_AREA
);

rrdset_flag_set(d->st_util, RRDSET_FLAG_DETAIL);

d->rd_util = rrddim_add(d->st_util, "utilization", NULL, 1, 1, RRD_ALGORITHM_ABSOLUTE);

if(cb)
Expand Down
2 changes: 0 additions & 2 deletions src/collectors/common-contexts/mem-pgfaults.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ static inline void common_mem_pgfaults(uint64_t minor, uint64_t major, int updat
, RRDSET_TYPE_LINE
);

rrdset_flag_set(st_pgfaults, RRDSET_FLAG_DETAIL);

rd_minor = rrddim_add(st_pgfaults, "minor", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
rd_major = rrddim_add(st_pgfaults, "major", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
}
Expand Down
2 changes: 0 additions & 2 deletions src/collectors/common-contexts/mem-swap.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ static inline void common_mem_swap(uint64_t free_bytes, uint64_t used_bytes, int
, RRDSET_TYPE_STACKED
);

rrdset_flag_set(st_system_swap, RRDSET_FLAG_DETAIL);

rd_free = rrddim_add(st_system_swap, "free", NULL, 1, 1024 * 1024, RRD_ALGORITHM_ABSOLUTE);
rd_used = rrddim_add(st_system_swap, "used", NULL, 1, 1024 * 1024, RRD_ALGORITHM_ABSOLUTE);
}
Expand Down
2 changes: 0 additions & 2 deletions src/collectors/common-contexts/system-interrupts.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ static inline void common_interrupts(uint64_t interrupts, int update_every, char
, update_every
, RRDSET_TYPE_LINE);

rrdset_flag_set(st_intr, RRDSET_FLAG_DETAIL);

rd_interrupts = rrddim_add(st_intr, "interrupts", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
}

Expand Down
14 changes: 0 additions & 14 deletions src/collectors/freebsd.plugin/freebsd_devstat.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -393,8 +393,6 @@ int do_kern_devstat(int update_every, usec_t dt) {
RRDSET_TYPE_LINE
);

rrdset_flag_set(dm->st_ops, RRDSET_FLAG_DETAIL);

dm->rd_ops_in = rrddim_add(dm->st_ops, "reads", NULL, 1, 1,
RRD_ALGORITHM_INCREMENTAL);
dm->rd_ops_out = rrddim_add(dm->st_ops, "writes", NULL, -1, 1,
Expand Down Expand Up @@ -428,8 +426,6 @@ int do_kern_devstat(int update_every, usec_t dt) {
RRDSET_TYPE_LINE
);

rrdset_flag_set(dm->st_qops, RRDSET_FLAG_DETAIL);

dm->rd_qops = rrddim_add(dm->st_qops, "operations", NULL, 1, 1, RRD_ALGORITHM_ABSOLUTE);
}

Expand All @@ -453,8 +449,6 @@ int do_kern_devstat(int update_every, usec_t dt) {
RRDSET_TYPE_AREA
);

rrdset_flag_set(dm->st_util, RRDSET_FLAG_DETAIL);

dm->rd_util = rrddim_add(dm->st_util, "utilization", NULL, 1, 10,
RRD_ALGORITHM_INCREMENTAL);
}
Expand All @@ -479,8 +473,6 @@ int do_kern_devstat(int update_every, usec_t dt) {
RRDSET_TYPE_LINE
);

rrdset_flag_set(dm->st_iotime, RRDSET_FLAG_DETAIL);

dm->rd_iotime_in = rrddim_add(dm->st_iotime, "reads", NULL, 1, 1,
RRD_ALGORITHM_INCREMENTAL);
dm->rd_iotime_out = rrddim_add(dm->st_iotime, "writes", NULL, -1, 1,
Expand Down Expand Up @@ -518,8 +510,6 @@ int do_kern_devstat(int update_every, usec_t dt) {
RRDSET_TYPE_LINE
);

rrdset_flag_set(dm->st_await, RRDSET_FLAG_DETAIL);

dm->rd_await_in = rrddim_add(dm->st_await, "reads", NULL, 1, 1,
RRD_ALGORITHM_ABSOLUTE);
dm->rd_await_out = rrddim_add(dm->st_await, "writes", NULL, -1, 1,
Expand Down Expand Up @@ -577,8 +567,6 @@ int do_kern_devstat(int update_every, usec_t dt) {
RRDSET_TYPE_AREA
);

rrdset_flag_set(dm->st_avagsz, RRDSET_FLAG_DETAIL);

dm->rd_avagsz_in = rrddim_add(dm->st_avagsz, "reads", NULL, 1, KILO_FACTOR,
RRD_ALGORITHM_ABSOLUTE);
dm->rd_avagsz_out = rrddim_add(dm->st_avagsz, "writes", NULL, -1, KILO_FACTOR,
Expand Down Expand Up @@ -627,8 +615,6 @@ int do_kern_devstat(int update_every, usec_t dt) {
RRDSET_TYPE_LINE
);

rrdset_flag_set(dm->st_svctm, RRDSET_FLAG_DETAIL);

dm->rd_svctm = rrddim_add(dm->st_svctm, "svctm", NULL, 1, 1,
RRD_ALGORITHM_ABSOLUTE);
}
Expand Down
10 changes: 0 additions & 10 deletions src/collectors/freebsd.plugin/freebsd_getifaddrs.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -297,8 +297,6 @@ int do_getifaddrs(int update_every, usec_t dt) {
RRDSET_TYPE_LINE
);

rrdset_flag_set(st, RRDSET_FLAG_DETAIL);

rd_packets_in = rrddim_add(st, "received", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
rd_packets_out = rrddim_add(st, "sent", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
rd_packets_m_in = rrddim_add(st, "multicast_received", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
Expand Down Expand Up @@ -464,8 +462,6 @@ int do_getifaddrs(int update_every, usec_t dt) {
RRDSET_TYPE_LINE
);

rrdset_flag_set(ifm->st_packets, RRDSET_FLAG_DETAIL);

ifm->rd_packets_in = rrddim_add(ifm->st_packets, "received", NULL, 1, 1,
RRD_ALGORITHM_INCREMENTAL);
ifm->rd_packets_out = rrddim_add(ifm->st_packets, "sent", NULL, -1, 1,
Expand Down Expand Up @@ -499,8 +495,6 @@ int do_getifaddrs(int update_every, usec_t dt) {
RRDSET_TYPE_LINE
);

rrdset_flag_set(ifm->st_errors, RRDSET_FLAG_DETAIL);

ifm->rd_errors_in = rrddim_add(ifm->st_errors, "inbound", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
ifm->rd_errors_out = rrddim_add(ifm->st_errors, "outbound", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
}
Expand All @@ -526,8 +520,6 @@ int do_getifaddrs(int update_every, usec_t dt) {
RRDSET_TYPE_LINE
);

rrdset_flag_set(ifm->st_drops, RRDSET_FLAG_DETAIL);

ifm->rd_drops_in = rrddim_add(ifm->st_drops, "inbound", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
#if __FreeBSD__ >= 11
ifm->rd_drops_out = rrddim_add(ifm->st_drops, "outbound", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
Expand Down Expand Up @@ -557,8 +549,6 @@ int do_getifaddrs(int update_every, usec_t dt) {
RRDSET_TYPE_LINE
);

rrdset_flag_set(ifm->st_events, RRDSET_FLAG_DETAIL);

ifm->rd_events_coll = rrddim_add(ifm->st_events, "collisions", NULL, -1, 1,
RRD_ALGORITHM_INCREMENTAL);
}
Expand Down
1 change: 0 additions & 1 deletion src/collectors/freebsd.plugin/freebsd_ipfw.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,6 @@ int do_ipfw(int update_every, usec_t dt) {
update_every,
RRDSET_TYPE_STACKED
);
rrdset_flag_set(st_mem, RRDSET_FLAG_DETAIL);

rd_dyn_mem = rrddim_add(st_mem, "dynamic", NULL, 1, 1, RRD_ALGORITHM_ABSOLUTE);
rd_stat_mem = rrddim_add(st_mem, "static", NULL, 1, 1, RRD_ALGORITHM_ABSOLUTE);
Expand Down
27 changes: 0 additions & 27 deletions src/collectors/freebsd.plugin/freebsd_sysctl.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,6 @@ int do_vm_vmtotal(int update_every, usec_t dt) {
update_every,
RRDSET_TYPE_AREA
);
rrdset_flag_set(st, RRDSET_FLAG_DETAIL);

rd = rrddim_add(st, "used", NULL, system_pagesize, MEGA_FACTOR, RRD_ALGORITHM_ABSOLUTE);
}
Expand Down Expand Up @@ -798,8 +797,6 @@ int do_vm_stats_sys_v_forks(int update_every, usec_t dt) {
RRDSET_TYPE_LINE
);

rrdset_flag_set(st, RRDSET_FLAG_DETAIL);

rd = rrddim_add(st, "started", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
}

Expand Down Expand Up @@ -871,8 +868,6 @@ int do_vm_swap_info(int update_every, usec_t dt) {
RRDSET_TYPE_STACKED
);

rrdset_flag_set(st, RRDSET_FLAG_DETAIL);

rd_free = rrddim_add(st, "free", NULL, system_pagesize, MEGA_FACTOR, RRD_ALGORITHM_ABSOLUTE);
rd_used = rrddim_add(st, "used", NULL, system_pagesize, MEGA_FACTOR, RRD_ALGORITHM_ABSOLUTE);
}
Expand Down Expand Up @@ -1081,8 +1076,6 @@ int do_vm_stats_sys_v_pgfaults(int update_every, usec_t dt) {
RRDSET_TYPE_LINE
);

rrdset_flag_set(st, RRDSET_FLAG_DETAIL);

rd_memory = rrddim_add(st, "memory", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
rd_io_requiring = rrddim_add(st, "io_requiring", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
rd_cow = rrddim_add(st, "cow", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
Expand Down Expand Up @@ -1756,8 +1749,6 @@ int do_net_inet_tcp_stats(int update_every, usec_t dt) {
RRDSET_TYPE_LINE
);

rrdset_flag_set(st, RRDSET_FLAG_DETAIL);

rd_in_errs = rrddim_add(st, "InErrs", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
rd_in_csum_errs = rrddim_add(st, "InCsumErrors", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
rd_retrans_segs = rrddim_add(st, "RetransSegs", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
Expand Down Expand Up @@ -1795,8 +1786,6 @@ int do_net_inet_tcp_stats(int update_every, usec_t dt) {
RRDSET_TYPE_LINE
);

rrdset_flag_set(st, RRDSET_FLAG_DETAIL);

rd_estab_resets = rrddim_add(st, "EstabResets", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
rd_active_opens = rrddim_add(st, "ActiveOpens", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
rd_passive_opens = rrddim_add(st, "PassiveOpens", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
Expand Down Expand Up @@ -1971,8 +1960,6 @@ int do_net_inet_tcp_stats(int update_every, usec_t dt) {
RRDSET_TYPE_LINE
);

rrdset_flag_set(st, RRDSET_FLAG_DETAIL);

rd_rcvce = rrddim_add(st, "InCEPkts", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
#if __FreeBSD_version < 1400074
rd_ect0 = rrddim_add(st, "ECT0Pkts", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
Expand Down Expand Up @@ -2082,8 +2069,6 @@ int do_net_inet_udp_stats(int update_every, usec_t dt) {
RRDSET_TYPE_LINE
);

rrdset_flag_set(st, RRDSET_FLAG_DETAIL);

rd_in_errors = rrddim_add(st, "InErrors", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
rd_no_ports = rrddim_add(st, "NoPorts", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
rd_recv_buf_errors = rrddim_add(st, "RcvbufErrors", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
Expand Down Expand Up @@ -2332,8 +2317,6 @@ int do_net_inet_ip_stats(int update_every, usec_t dt) {
RRDSET_TYPE_LINE
);

rrdset_flag_set(st, RRDSET_FLAG_DETAIL);

rd_ok = rrddim_add(st, "FragOKs", "ok", 1, 1, RRD_ALGORITHM_INCREMENTAL);
rd_fails = rrddim_add(st, "FragFails", "failed", -1, 1, RRD_ALGORITHM_INCREMENTAL);
rd_created = rrddim_add(st, "FragCreates", "created", 1, 1, RRD_ALGORITHM_INCREMENTAL);
Expand Down Expand Up @@ -2365,8 +2348,6 @@ int do_net_inet_ip_stats(int update_every, usec_t dt) {
RRDSET_TYPE_LINE
);

rrdset_flag_set(st, RRDSET_FLAG_DETAIL);

rd_ok = rrddim_add(st, "ReasmOKs", "ok", 1, 1, RRD_ALGORITHM_INCREMENTAL);
rd_failed = rrddim_add(st, "ReasmFails", "failed", -1, 1, RRD_ALGORITHM_INCREMENTAL);
rd_all = rrddim_add(st, "ReasmReqds", "all", 1, 1, RRD_ALGORITHM_INCREMENTAL);
Expand Down Expand Up @@ -2400,8 +2381,6 @@ int do_net_inet_ip_stats(int update_every, usec_t dt) {
RRDSET_TYPE_LINE
);

rrdset_flag_set(st, RRDSET_FLAG_DETAIL);

rd_in_discards = rrddim_add(st, "InDiscards", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
rd_out_discards = rrddim_add(st, "OutDiscards", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
rd_in_hdr_errors = rrddim_add(st, "InHdrErrors", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
Expand Down Expand Up @@ -2519,8 +2498,6 @@ int do_net_inet6_ip6_stats(int update_every, usec_t dt) {
RRDSET_TYPE_LINE
);

rrdset_flag_set(st, RRDSET_FLAG_DETAIL);

rd_ok = rrddim_add(st, "ok", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
rd_failed = rrddim_add(st, "failed", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
rd_all = rrddim_add(st, "all", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
Expand Down Expand Up @@ -2554,8 +2531,6 @@ int do_net_inet6_ip6_stats(int update_every, usec_t dt) {
RRDSET_TYPE_LINE
);

rrdset_flag_set(st, RRDSET_FLAG_DETAIL);

rd_ok = rrddim_add(st, "ok", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
rd_failed = rrddim_add(st, "failed", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
rd_timeout = rrddim_add(st, "timeout", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
Expand Down Expand Up @@ -2593,8 +2568,6 @@ int do_net_inet6_ip6_stats(int update_every, usec_t dt) {
RRDSET_TYPE_LINE
);

rrdset_flag_set(st, RRDSET_FLAG_DETAIL);

rd_in_discards = rrddim_add(st, "InDiscards", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
rd_out_discards = rrddim_add(st, "OutDiscards", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
rd_in_hdr_errors = rrddim_add(st, "InHdrErrors", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
Expand Down
Loading

0 comments on commit ac76c5f

Please sign in to comment.