[pull] master from netdata:master #791
Triggered via pull request
September 9, 2024 21:27
pull[bot]
Status
Success
Total duration
10m 51s
Artifacts
–
review.yml
on: pull_request
Prepare Review Jobs
31s
actionlint
38s
flake8
0s
hadolint
0s
shellcheck
2m 21s
yamllint
50s
Matrix: golangci-lint
Annotations
4 errors
|
yamllint:
src/go/plugin/go.d/modules/apcupsd/metadata.yaml#L88
[yamllint] reported by reviewdog 🐶
[error] trailing spaces (trailing-spaces)
Raw Output:
./src/go/plugin/go.d/modules/apcupsd/metadata.yaml:88:1: [error] trailing spaces (trailing-spaces)
|
|
yamllint:
src/go/plugin/go.d/modules/apcupsd/metadata.yaml#L94
[yamllint] reported by reviewdog 🐶
[error] trailing spaces (trailing-spaces)
Raw Output:
./src/go/plugin/go.d/modules/apcupsd/metadata.yaml:94:1: [error] trailing spaces (trailing-spaces)
|
|
yamllint:
src/go/plugin/go.d/modules/apcupsd/metadata.yaml#L175
[yamllint] reported by reviewdog 🐶
[error] truthy value should be one of [false, no, true, yes] (truthy)
Raw Output:
./src/go/plugin/go.d/modules/apcupsd/metadata.yaml:175:25: [error] truthy value should be one of [false, no, true, yes] (truthy)
|
|
golangci-lint (src/go):
plugin/go.d/modules/apcupsd/collect.go#L131
[golangci] reported by reviewdog 🐶
S1012: should use `time.Since` instead of `time.Now().Sub` (gosimple)
Raw Output:
plugin/go.d/modules/apcupsd/collect.go:131:19: S1012: should use `time.Since` instead of `time.Now().Sub` (gosimple)
secsAgo := int64(time.Now().Sub(date).Seconds())
^
|