Forward port "always decorate Symfonys config_cache_factory service with WfdMetaConfigCacheFactory" to master for 4.0.x (Case 171239)
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d always The WfdMetaConfigCacheFactory creates a cache that checks its freshness by: 1. checking the "inner" cache with Symfony means 2. if that is still fresh, the WfdMetaConfigCache queries the wfd_meta table in regard to the registered wfdMeta-resources like a DoctrineEntityClassResource for a Page entity. Previously, the decoration only took place when `always_expire_wfd_meta_resources` was not set. This effectively disabled checking the wfdMeta-resources, at least in production environments. (The fact that one probably shouldn't use this configuration setting in production is another story.) This should not break anything, as the decoration used to happen always before the `always_expire_wfd_meta_resources` config setting was introduced in c7a2e2b.
"version = 3.9.0" seems slightly better than "3.14.0", as the deprecation was introduced (in another form) in 3.9.0 already.
…gcachefactory Always decorate Symfonys `config_cache_factory` service with `WfdMetaConfigCacheFactory` (Case 171239)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port of #45