Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always expire wfdMeta resources in test per default #37

Closed

Conversation

relthyg
Copy link
Member

@relthyg relthyg commented Mar 12, 2024

We set

    webfactory_wfd_meta.always_expire_wfd_meta_resources: true

in our Symfony-default-config in https://github.com/webfactory/webfactory-symfony-default-config/pull/14, but we can't actually do that, because this triggers an error in projects not using webfactory/wfdmeta-bundle (see https://github.com/webfactory/webfactory-symfony-default-config/pull/17)

This PR sets the configuration parameter webfactory_wfd_meta.always_expire_wfd_meta_resources to true as default in test environments end keeps it false everywhere else.

Closes #35

@relthyg relthyg requested a review from mpdude March 12, 2024 14:59
Copy link
Member

@mpdude mpdude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to say, but I don't like this approach. This is not how the Symfony configuration mechanism works or what typical Configuration classes look like, and it hard-codes the assumption about the name of an environment variable and the environment name into that class.

The env variable name or environment name may be the Symfony default or best practice, but that is just a convention.

@relthyg relthyg closed this Mar 22, 2024
@mpdude mpdude deleted the always_expire_wfd_meta_resources_in_test_per_default branch March 22, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try to expire wfd_meta-based caches immediately per default in test-environment
2 participants