Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow doctrine/persistence:^3.1 #38

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Allow doctrine/persistence:^3.1 #38

merged 2 commits into from
Apr 4, 2024

Conversation

relthyg
Copy link
Member

@relthyg relthyg commented Mar 22, 2024 •
edited
Loading

As this is needed by symfony/doctrine-bridge:7.0.

@relthyg relthyg changed the base branch from master to 3.x March 22, 2024 09:23
@relthyg relthyg changed the title doctrine persistence 3 Allow doctrine/persistence:^3.1 Mar 22, 2024
@relthyg
Copy link
Member Author

relthyg commented Mar 22, 2024

Ich habe keine Idee, wie ich den einen Test fixen kann, der failt. Vielleicht haben @mpdude oder @FabianSchmick eine?

@relthyg relthyg changed the base branch from 3.x to attribute-support March 25, 2024 13:53
@mpdude
Copy link
Member

mpdude commented Mar 26, 2024

Ich habe das schon mal irgendwo gesehen… 🤔

@mpdude
Copy link
Member

mpdude commented Mar 26, 2024 •
edited
Loading

Vielleicht war es in der Vorbereitung neuer Features, die insb. über #28, #30 #31 im 3.x Branch gelandet sind… aber der Branch kann auch noch kein Persistence 3.x…

@relthyg
Copy link
Member Author

relthyg commented Mar 27, 2024

Die in Version 3.0 von doctrine/persistence eingeführteRuntimeReflectionProperty hat gegenüber der ReflectionProperty noch die zusätzliche Eigenschaft key, welche beim Aufruf von sleep() im Test nicht übertragen wird (und auch nicht übertragen werden kann, weil sie private ist), darum sind die beiden Objekte im TranslatableClassMetadataTest::can_be_serialized_and_retrieved() nicht mehr gleich.

@mpdude
Allow doctrine/persistence:^3.1
af2c29f 
as `symfony/doctrine-bridge:^7.0` needs this
@mpdude mpdude force-pushed the doctrine-persistence-3 branch from a7fae36 to af2c29f Compare April 4, 2024 12:53
@mpdude mpdude changed the base branch from attribute-support to master April 4, 2024 12:53
@mpdude mpdude marked this pull request as draft April 4, 2024 12:53
@mpdude
Copy link
Member

mpdude commented Apr 4, 2024

doctrine/persistence#307 is the reason for those new property types. I think we should use these also after serialization/unserialization of our metadata, so this needs to be investigated.

@mpdude mpdude marked this pull request as ready for review April 4, 2024 14:44
@webfactory webfactory deleted a comment from relthyg Apr 4, 2024
@mpdude mpdude merged commit 9720756 into master Apr 4, 2024
6 checks passed
@mpdude mpdude deleted the doctrine-persistence-3 branch April 4, 2024 14:51
mpdude pushed a commit that referenced this pull request Apr 24, 2024
@relthyg @mpdude
Allow doctrine/persistence ^3.1 (backport to 3.x)
ca4c378 
This backports #38 to the 3.x branch.
@mpdude mpdude mentioned this pull request Apr 24, 2024
Merged
mpdude added a commit that referenced this pull request Apr 24, 2024
@mpdude
Allow doctrine/persistence ^3.1 (backport to 3.x) (#67)
edb88a6 
This backports #38 to the 3.x branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@relthyg @mpdude