Support cargo workspace inheritance #98
Conversation
| pub fn github(badge: cargo_toml::Badge) -> String { | ||
| let repo = badge.repository; | ||
| // TODO: support workflow option. | ||
| let workflow = "main"; // BADGE_WORKFLOW_DEFAULT |
There was a problem hiding this comment.
That's a problem. cargo_toml does not support [badge.github] field.
But badge section is deprecated, so I am hesitant to make a PR to cargo_toml.
There was a problem hiding this comment.
The badge should be removed from cargo-readme following cargo_toml recommandation.
The badges, if the maintainer want them, should be placed into a template (README.tpl) like that:
# {{crate}}
{{readme}}
@webern what do you think of this solution? I think it should considered as breaking change tho
There was a problem hiding this comment.
Sounds good to me. Fewer things for this code to worry about.
There was a problem hiding this comment.
Are there any modifications I can make to this PR?
There was a problem hiding this comment.
I don't think there is anything you can do without breaking
There was a problem hiding this comment.
Thanks!
What can I do to merge this PR?
There was a problem hiding this comment.
Hello,
For this PR I would completely remove the badges from the generation and update the doc to explain how to add them in the README.tpl, it is a breaking but I don't see another alternative. WDYT?
There was a problem hiding this comment.
It would be good.
The Cargo.toml spec is changing and badges are already deprecated.
yassun7010
changed the title
Related #81.
I rewrite using cargo_toml crate for workspace inheritance.