Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): improve extraction of item labels and description #26

Merged
merged 1 commit into from
May 29, 2024

Conversation

musicEnfanthen
Copy link
Member

This PR improves the extraction of the item label descriptions by not relying on a detection of parenthesis delimiter, but on the detection of a sketch siglum. If a (bold) sketch siglum is detected, the siglum is used as label and the content in parentheses is used as description, otherwise the full entry is used as description without any label.

@musicEnfanthen
Copy link
Member Author

Example:

Input:
Screenshot 2024-05-28 170803

Output:
Screenshot 2024-05-28 170719

@musicEnfanthen musicEnfanthen requested a review from masthom May 28, 2024 15:17
Copy link

@masthom masthom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@musicEnfanthen musicEnfanthen merged commit f2e8e4e into webern-unibas-ch:main May 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants