Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(edition): add disclaimer button to WE textcritics #2076

Merged

Conversation

musicEnfanthen
Copy link
Member

This PR moves the workedition disclaimer into a separate component to reuse it where needed. It also adds the disclaimer to the tka for work editions.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.90%. Comparing base (dab4478) to head (02d9dc3).
Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2076      +/-   ##
===========================================
+ Coverage    80.87%   80.90%   +0.03%     
===========================================
  Files          269      270       +1     
  Lines         4177     4185       +8     
  Branches       620      621       +1     
===========================================
+ Hits          3378     3386       +8     
  Misses         785      785              
  Partials        14       14              
Flag Coverage Δ
unittests 80.90% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...-workeditions/disclaimer-workeditions.component.ts 100.00% <100.00%> (ø)
src/app/shared/shared.module.ts 100.00% <ø> (ø)
...ort/textcritics-list/textcritics-list.component.ts 100.00% <100.00%> (ø)
...t-nav-item/edition-svg-sheet-nav-item.component.ts 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dab4478...02d9dc3. Read the comment docs.

@musicEnfanthen musicEnfanthen merged commit 8d39588 into webern-unibas-ch:develop Dec 17, 2024
16 checks passed
@musicEnfanthen musicEnfanthen deleted the feature/disclaimer branch December 17, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants