Skip to content

Commit

Permalink
Merge pull request #2079 from webern-unibas-ch/dependabot/npm_and_yar…
Browse files Browse the repository at this point in the history 
…n/develop/ng-bootstrap/ng-bootstrap-18.0.0

build(deps): bump @ng-bootstrap/ng-bootstrap from 17.0.1 to 18.0.0
  • Loading branch information
@musicEnfanthen
musicEnfanthen authored Dec 23, 2024
2 parents 2c4081b + 176a5c2 commit 4122786
Show file tree
Hide file tree
Showing 5 changed files with 47 additions and 47 deletions.
2 changes: 1 addition & 1 deletion eslint.config.mjs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,12 @@ export default typescriptEslint.config(
rules: {
'@angular-eslint/component-class-suffix': 'error',
'@angular-eslint/directive-class-suffix': 'error',
'@angular-eslint/no-host-metadata-property': 'error',
'@angular-eslint/no-input-rename': 'error',
'@angular-eslint/no-inputs-metadata-property': 'error',
'@angular-eslint/no-output-on-prefix': 'error',
'@angular-eslint/no-output-rename': 'error',
'@angular-eslint/no-outputs-metadata-property': 'error',
'@angular-eslint/prefer-standalone': 'off',
'@angular-eslint/use-lifecycle-interface': 'error',
'@angular-eslint/use-pipe-transform-interface': 'error',
'@typescript-eslint/consistent-type-definitions': 'error',
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
"@fortawesome/angular-fontawesome": "^1.0.0",
"@fortawesome/free-solid-svg-icons": "^6.7.2",
"@kolkov/ngx-gallery": "2.0.1",
"@ng-bootstrap/ng-bootstrap": "^17.0.1",
"@ng-bootstrap/ng-bootstrap": "^18.0.0",
"@popperjs/core": "^2.11.8",
"bootstrap": "^5.3.3",
"codemirror": "^6.0.1",
Expand Down
38 changes: 19 additions & 19 deletions ...tail/edition-graph/graph-visualizer/construct-results/construct-results.component.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -906,11 +906,11 @@ describe('ConstructResultsComponent (DONE)', () => {
});

it('... should be triggered from ngbAccordionBody', () => {
expectSpyCall(isQueryResultNotEmptySpy, 2, expectedQueryResult[0]);
expectSpyCall(isQueryResultNotEmptySpy, 3, expectedQueryResult[0]);
});

it('... should be triggered by change of queryResult', () => {
expectSpyCall(isQueryResultNotEmptySpy, 2, expectedQueryResult[0]);
expectSpyCall(isQueryResultNotEmptySpy, 3, expectedQueryResult[0]);

// Mock another queryResult
const anotherQueryResult = {
Expand All @@ -921,24 +921,24 @@ describe('ConstructResultsComponent (DONE)', () => {
component.queryResult$ = observableOf([anotherQueryResult]);
detectChangesOnPush(fixture);

expectSpyCall(isQueryResultNotEmptySpy, 3, anotherQueryResult[0]);
expectSpyCall(isQueryResultNotEmptySpy, 4, anotherQueryResult[0]);
});

describe('... should return false if ...', () => {
it('... queryResult is empty array', () => {
expectSpyCall(isQueryResultNotEmptySpy, 2, expectedQueryResult[0]);
expectSpyCall(isQueryResultNotEmptySpy, 3, expectedQueryResult[0]);

// Mock empty response
const emptyQueryResult = [];
component.queryResult$ = observableOf(emptyQueryResult);
detectChangesOnPush(fixture);

expectSpyCall(isQueryResultNotEmptySpy, 3, emptyQueryResult);
expectSpyCall(isQueryResultNotEmptySpy, 4, emptyQueryResult);
expectToBe(component.isQueryResultNotEmpty(emptyQueryResult), false);
});

it('... queryResult.subject is undefined or empty string', () => {
expectSpyCall(isQueryResultNotEmptySpy, 2, expectedQueryResult[0]);
expectSpyCall(isQueryResultNotEmptySpy, 3, expectedQueryResult[0]);

// Mock undefined response
const undefinedQueryResult = {
Expand All @@ -949,7 +949,7 @@ describe('ConstructResultsComponent (DONE)', () => {
component.queryResult$ = observableOf([undefinedQueryResult]);
detectChangesOnPush(fixture);

expectSpyCall(isQueryResultNotEmptySpy, 3, undefinedQueryResult[0]);
expectSpyCall(isQueryResultNotEmptySpy, 4, undefinedQueryResult[0]);
expectToBe(component.isQueryResultNotEmpty([undefinedQueryResult]), false);

// Mock empty response
Expand All @@ -961,12 +961,12 @@ describe('ConstructResultsComponent (DONE)', () => {
component.queryResult$ = observableOf([emptyQueryResult]);
detectChangesOnPush(fixture);

expectSpyCall(isQueryResultNotEmptySpy, 5, emptyQueryResult[0]);
expectSpyCall(isQueryResultNotEmptySpy, 6, emptyQueryResult[0]);
expectToBe(component.isQueryResultNotEmpty([emptyQueryResult]), false);
});

it('... queryResult.predicate is undefined or empty string', () => {
expectSpyCall(isQueryResultNotEmptySpy, 2, expectedQueryResult[0]);
expectSpyCall(isQueryResultNotEmptySpy, 3, expectedQueryResult[0]);

// Mock undefined response
const undefinedQueryResult = {
Expand All @@ -977,7 +977,7 @@ describe('ConstructResultsComponent (DONE)', () => {
component.queryResult$ = observableOf([undefinedQueryResult]);
detectChangesOnPush(fixture);

expectSpyCall(isQueryResultNotEmptySpy, 3, undefinedQueryResult[0]);
expectSpyCall(isQueryResultNotEmptySpy, 4, undefinedQueryResult[0]);
expectToBe(component.isQueryResultNotEmpty([undefinedQueryResult]), false);

// Mock empty response
Expand All @@ -989,12 +989,12 @@ describe('ConstructResultsComponent (DONE)', () => {
component.queryResult$ = observableOf([emptyQueryResult]);
detectChangesOnPush(fixture);

expectSpyCall(isQueryResultNotEmptySpy, 5, emptyQueryResult[0]);
expectSpyCall(isQueryResultNotEmptySpy, 6, emptyQueryResult[0]);
expectToBe(component.isQueryResultNotEmpty([emptyQueryResult]), false);
});

it('... queryResult.object is undefined or empty string', () => {
expectSpyCall(isQueryResultNotEmptySpy, 2, expectedQueryResult[0]);
expectSpyCall(isQueryResultNotEmptySpy, 3, expectedQueryResult[0]);

// Mock undefined response
const undefinedQueryResult = {
Expand All @@ -1005,7 +1005,7 @@ describe('ConstructResultsComponent (DONE)', () => {
component.queryResult$ = observableOf([undefinedQueryResult]);
detectChangesOnPush(fixture);

expectSpyCall(isQueryResultNotEmptySpy, 3, undefinedQueryResult[0]);
expectSpyCall(isQueryResultNotEmptySpy, 4, undefinedQueryResult[0]);
expectToBe(component.isQueryResultNotEmpty([undefinedQueryResult]), false);

// Mock empty response
Expand All @@ -1017,33 +1017,33 @@ describe('ConstructResultsComponent (DONE)', () => {
component.queryResult$ = observableOf([emptyQueryResult]);
detectChangesOnPush(fixture);

expectSpyCall(isQueryResultNotEmptySpy, 5, emptyQueryResult[0]);
expectSpyCall(isQueryResultNotEmptySpy, 6, emptyQueryResult[0]);
expectToBe(component.isQueryResultNotEmpty([emptyQueryResult]), false);
});

it('... queryResult.subject, queryResult.predicate and queryResult.object are undefined or empty string', () => {
expectSpyCall(isQueryResultNotEmptySpy, 2, expectedQueryResult[0]);
expectSpyCall(isQueryResultNotEmptySpy, 3, expectedQueryResult[0]);

// Mock undefined response
const undefinedQueryResult = { subject: undefined, predicate: undefined, object: undefined };
component.queryResult$ = observableOf([undefinedQueryResult]);
detectChangesOnPush(fixture);

expectSpyCall(isQueryResultNotEmptySpy, 3, undefinedQueryResult[0]);
expectSpyCall(isQueryResultNotEmptySpy, 4, undefinedQueryResult[0]);
expectToBe(component.isQueryResultNotEmpty([undefinedQueryResult]), false);

// Mock empty response
const emptyQueryResult = { subject: '', predicate: '', object: '' };
component.queryResult$ = observableOf([emptyQueryResult]);
detectChangesOnPush(fixture);

expectSpyCall(isQueryResultNotEmptySpy, 5, emptyQueryResult[0]);
expectSpyCall(isQueryResultNotEmptySpy, 6, emptyQueryResult[0]);
expectToBe(component.isQueryResultNotEmpty([emptyQueryResult]), false);
});
});

it('... should return true if queryResult is not empty', () => {
expectSpyCall(isQueryResultNotEmptySpy, 2, expectedQueryResult[0]);
expectSpyCall(isQueryResultNotEmptySpy, 3, expectedQueryResult[0]);

// Mock non-empty response
const nonEmptyQueryResult = {
Expand All @@ -1054,7 +1054,7 @@ describe('ConstructResultsComponent (DONE)', () => {
component.queryResult$ = observableOf([nonEmptyQueryResult]);
detectChangesOnPush(fixture);

expectSpyCall(isQueryResultNotEmptySpy, 3, nonEmptyQueryResult[0]);
expectSpyCall(isQueryResultNotEmptySpy, 4, nonEmptyQueryResult[0]);
expectToBe(component.isQueryResultNotEmpty([nonEmptyQueryResult]), true);
});
});
Expand Down
34 changes: 17 additions & 17 deletions ...ion-detail/edition-graph/graph-visualizer/select-results/select-results.component.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -668,11 +668,11 @@ describe('SelectResultsComponent (DONE)', () => {
});

it('... should be triggered from ngbAccordionBody', () => {
expectSpyCall(isQueryResultNotEmptySpy, 2, expectedQueryResult[0]);
expectSpyCall(isQueryResultNotEmptySpy, 3, expectedQueryResult[0]);
});

it('... should be triggered by change of queryResult', () => {
expectSpyCall(isQueryResultNotEmptySpy, 2, expectedQueryResult);
expectSpyCall(isQueryResultNotEmptySpy, 3, expectedQueryResult);

// Mock another queryResult
const queryResult = {
Expand All @@ -683,88 +683,88 @@ describe('SelectResultsComponent (DONE)', () => {

detectChangesOnPush(fixture);

expectSpyCall(isQueryResultNotEmptySpy, 3, queryResult);
expectSpyCall(isQueryResultNotEmptySpy, 4, queryResult);
});

describe('... should return false if ...', () => {
it('... queryResult.head is undefined', () => {
expectSpyCall(isQueryResultNotEmptySpy, 2, expectedQueryResult);
expectSpyCall(isQueryResultNotEmptySpy, 3, expectedQueryResult);

// Mock undefined response
const undefinedQueryResult = { head: undefined, body: { bindings: [{ test: 'Test' }] } };
component.queryResult$ = observableOf(undefinedQueryResult);
detectChangesOnPush(fixture);

expectSpyCall(isQueryResultNotEmptySpy, 3, undefinedQueryResult);
expectSpyCall(isQueryResultNotEmptySpy, 4, undefinedQueryResult);
expectToBe(component.isQueryResultNotEmpty(undefinedQueryResult), false);
});

it('... queryResult.body is undefined', () => {
expectSpyCall(isQueryResultNotEmptySpy, 2, expectedQueryResult);
expectSpyCall(isQueryResultNotEmptySpy, 3, expectedQueryResult);

// Mock undefined response
const undefinedQueryResult = { head: { vars: ['Test'] }, body: undefined };
component.queryResult$ = observableOf(undefinedQueryResult);
detectChangesOnPush(fixture);

expectSpyCall(isQueryResultNotEmptySpy, 3, undefinedQueryResult);
expectSpyCall(isQueryResultNotEmptySpy, 4, undefinedQueryResult);
expectToBe(component.isQueryResultNotEmpty(undefinedQueryResult), false);
});

it('... queryResult.head and queryResult.body are undefined', () => {
expectSpyCall(isQueryResultNotEmptySpy, 2, expectedQueryResult);
expectSpyCall(isQueryResultNotEmptySpy, 3, expectedQueryResult);

// Mock undefined response
const undefinedQueryResult = { head: undefined, body: undefined };
component.queryResult$ = observableOf(undefinedQueryResult);
detectChangesOnPush(fixture);

expectSpyCall(isQueryResultNotEmptySpy, 3, undefinedQueryResult);
expectSpyCall(isQueryResultNotEmptySpy, 4, undefinedQueryResult);
expectToBe(component.isQueryResultNotEmpty(undefinedQueryResult), false);
});

it('... queryResult.head.vars is empty array', () => {
expectSpyCall(isQueryResultNotEmptySpy, 2, expectedQueryResult);
expectSpyCall(isQueryResultNotEmptySpy, 3, expectedQueryResult);

// Mock empty response
const emptyQueryResult = { head: { vars: [] }, body: { bindings: [{ testKey: 'TestValue' }] } };
component.queryResult$ = observableOf(emptyQueryResult);

detectChangesOnPush(fixture);

expectSpyCall(isQueryResultNotEmptySpy, 3, emptyQueryResult);
expectSpyCall(isQueryResultNotEmptySpy, 4, emptyQueryResult);
expectToBe(component.isQueryResultNotEmpty(emptyQueryResult), false);
});

it('... queryResult.body.bindings is empty array', () => {
expectSpyCall(isQueryResultNotEmptySpy, 2, expectedQueryResult);
expectSpyCall(isQueryResultNotEmptySpy, 3, expectedQueryResult);

// Mock empty response
const emptyQueryResult = { head: { vars: ['TestHeader'] }, body: { bindings: [] } };
component.queryResult$ = observableOf(emptyQueryResult);

detectChangesOnPush(fixture);

expectSpyCall(isQueryResultNotEmptySpy, 3, emptyQueryResult);
expectSpyCall(isQueryResultNotEmptySpy, 4, emptyQueryResult);
expectToBe(component.isQueryResultNotEmpty(emptyQueryResult), false);
});

it('... queryResult.head.vars & queryResult.body.bindings are empty arrays', () => {
expectSpyCall(isQueryResultNotEmptySpy, 2, expectedQueryResult);
expectSpyCall(isQueryResultNotEmptySpy, 3, expectedQueryResult);

// Mock empty response
const emptyQueryResult = { head: { vars: [] }, body: { bindings: [] } };
component.queryResult$ = observableOf(emptyQueryResult);

detectChangesOnPush(fixture);

expectSpyCall(isQueryResultNotEmptySpy, 3, emptyQueryResult);
expectSpyCall(isQueryResultNotEmptySpy, 4, emptyQueryResult);
expectToBe(component.isQueryResultNotEmpty(emptyQueryResult), false);
});
});

it('... should return true if queryResult.head.vars && queryResult.body.bindings is not empty (length > 0)', () => {
expectSpyCall(isQueryResultNotEmptySpy, 2, expectedQueryResult);
expectSpyCall(isQueryResultNotEmptySpy, 3, expectedQueryResult);

// Mock non-empty response
const nonEmptyQueryResult = {
Expand All @@ -774,7 +774,7 @@ describe('SelectResultsComponent (DONE)', () => {
component.queryResult$ = observableOf(nonEmptyQueryResult);
detectChangesOnPush(fixture);

expectSpyCall(isQueryResultNotEmptySpy, 3, nonEmptyQueryResult);
expectSpyCall(isQueryResultNotEmptySpy, 4, nonEmptyQueryResult);
expectToBe(component.isQueryResultNotEmpty(nonEmptyQueryResult), true);
});
});
Expand Down
18 changes: 9 additions & 9 deletions yarn.lock
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3536,19 +3536,19 @@ __metadata:
languageName: node
linkType: hard

"@ng-bootstrap/ng-bootstrap@npm:^17.0.1":
version: 17.0.1
resolution: "@ng-bootstrap/ng-bootstrap@npm:17.0.1"
"@ng-bootstrap/ng-bootstrap@npm:^18.0.0":
version: 18.0.0
resolution: "@ng-bootstrap/ng-bootstrap@npm:18.0.0"
dependencies:
tslib: "npm:^2.3.0"
peerDependencies:
"@angular/common": ^18.0.0
"@angular/core": ^18.0.0
"@angular/forms": ^18.0.0
"@angular/localize": ^18.0.0
"@angular/common": ^19.0.0
"@angular/core": ^19.0.0
"@angular/forms": ^19.0.0
"@angular/localize": ^19.0.0
"@popperjs/core": ^2.11.8
rxjs: ^6.5.3 || ^7.4.0
checksum: 10c0/9892a7b99596491f9144669c6ccc28574160ed79e6c7045fea9c922cac0896dc02b6de00cc115ae1830f46233a5fafbca5af985533a02085e409769ff7c210af
checksum: 10c0/289b6793116a69422b72d64950315f987db1f3e5b0059655853176cb2970748c9c4b575cc8856fee5acf6446372d52fbfa8fc928c98d5258c7515d3ee4503451
languageName: node
linkType: hard

Expand Down Expand Up @@ -5875,7 +5875,7 @@ __metadata:
"@fortawesome/angular-fontawesome": "npm:^1.0.0"
"@fortawesome/free-solid-svg-icons": "npm:^6.7.2"
"@kolkov/ngx-gallery": "npm:2.0.1"
"@ng-bootstrap/ng-bootstrap": "npm:^17.0.1"
"@ng-bootstrap/ng-bootstrap": "npm:^18.0.0"
"@popperjs/core": "npm:^2.11.8"
"@types/d3": "npm:^7.4.3"
"@types/jasmine": "npm:~5.1.4"
Expand Down

0 comments on commit 4122786

Please sign in to comment.