Skip to content
This repository has been archived by the owner on Dec 18, 2019. It is now read-only.

Retries per file #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

shackijj
Copy link
Contributor

@shackijj shackijj commented Dec 10, 2018

Proposed changes

This PR resolves #2484.

I took commits from PR 2930 which was closed due to migration v4 to a separate repository.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have proposed the same patch to the new v5 repository

Further comments

Reviewers: @christian-bromann

bennieswart and others added 4 commits December 10, 2018 15:55
Previously only test-level and suite-level retries were available, which
are fine in most cases. In any test which involves state, such as on a
server or in a db, the state may be left invalid once the test fails the
first time. Any subsequent retries may have no chance of passing due to
the invalid state they would have to start with.

A new browser instance is created for each specfile, which makes this an
ideal place to hook and setup any other states (server, db). Retries on
this level would mean that the whole setup process could simply be
repeated as if it were for a new specfile, with the results of the
failing specfile (that is to be retried) being discarded.
This allows the reporter to set the start and end properties of
runnables to the time the event happened as opposed to the time the
reporter got notified of the event.
@jsf-clabot
Copy link

jsf-clabot commented Dec 10, 2018

CLA assistant check
All committers have signed the CLA.

@shackijj
Copy link
Contributor Author

shackijj commented Jan 9, 2019

@christian-bromann should unit tests be launched automatically for this PR?

@BorisOsipov
Copy link

Close\reopen to trigger CI

@shackijj
Copy link
Contributor Author

@BorisOsipov
The tests fail with the following error:
Error: Could not start Sauce Connect. Exit code 1 signal: null at ChildProcess.<anonymous> (node_modules/sauce-connect-launcher/lib/sauce-connect-launcher.js:559:12) at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)

Could you please check credentials on CI?

@BorisOsipov
Copy link

@shackijj unfortunately, tests won't work on Travis. I disabled them. See #6 (comment)

@shackijj
Copy link
Contributor Author

shackijj commented Jan 25, 2019

@christian-bromann @BorisOsipov
If the tests are disabled, what should be done to merge this PR?

@wendywww
Copy link

wendywww commented Mar 9, 2019

Given the situation that this PR isnt' merging to boneyard master soon, I need to use this feature by make my own package...

QUESTION: If I fork and do npm package, anything/steps I need to modify/add to make it work in order to have it work the same as webdriverio out of box(simply just npm install solving the problem)?

What I tried, pack this and remove the previous webdriverio and install the newly made package. It throws message as : Error: Cannot find module '../build/lib/cli.js'
Much appreciated for any help!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants