Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug where the arguments were ignored during logger setup #95

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Fix a bug where the arguments were ignored during logger setup #95

merged 1 commit into from
Sep 13, 2024

Conversation

moredatapls
Copy link
Contributor

Fixes #93

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

moredatapls
moredatapls commented Jun 5, 2024
View reviewed changes
main.go

// parses and validates the arguments
func parseArguments() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarCloud complains about the complexity of this method but I would prefer to not refactor this now

@mblaschke mblaschke merged commit 311c553 into webdevops:main Sep 13, 2024
2 of 3 checks passed
@moredatapls moredatapls deleted the fix-ignored-options-during-logger-setup branch September 13, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mblaschke mblaschke mblaschke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Arguments are getting ignored during logger setup
2 participants
@moredatapls @mblaschke