[SPARKL-166] Fix ZipUtil so zips created are readale in Windows

[cdeptula]

No description provided.

[lucboudreau]

Build Commands:

Build:

1. rm -r ~/.kettle; rm -r ~/.pentaho; echo removed hidden folders
2. ant -Djunit.jvmargs=-XX:PermSize=256m -f cpk-core/build.xml clean-all resolve jacoco jacoco-integration checkstyle publish-local

Cleanup:

rm -r ~/.ivy2/local || echo no publish local to remove

Changed files:

cpk-core/src/pt/webdetails/cpk/utils/ZipUtil.java
cpk-core/test-src/pt/webdetails/cpk/utils/ZipUtilTest.java

Checkstyle violations:

See: https://github.com/pentaho/pentaho-coding-standards

File cpk-core/src/pt/webdetails/cpk/utils/ZipUtil.java

1. Message: File does not end with a newline. at Line: 0 Column: None

File cpk-core/test-src/pt/webdetails/cpk/utils/ZipUtilTest.java

1. Message: 'member def modifier' have incorrect indentation level 4, expected level should be 2. at Line: 16 Column: None
2. Message: 'method def modifier' have incorrect indentation level 4, expected level should be 2. at Line: 18 Column: None
3. Message: 'method def' child have incorrect indentation level 8, expected level should be 4. at Line: 20 Column: None
4. Message: 'method def rcurly' have incorrect indentation level 4, expected level should be 2. at Line: 21 Column: None
5. Message: 'method def modifier' have incorrect indentation level 4, expected level should be 2. at Line: 23 Column: None
6. Message: 'member def type' have incorrect indentation level 8, expected level should be 4. at Line: 25 Column: None
7. Message: 'method def' child have incorrect indentation level 8, expected level should be 4. at Line: 25 Column: None
8. Message: 'member def type' have incorrect indentation level 8, expected level should be 4. at Line: 26 Column: None
9. Message: 'method def' child have incorrect indentation level 8, expected level should be 4. at Line: 26 Column: None
10. Message: '(' is not followed by whitespace. at Line: 27 Column: 55
11. Message: ')' is not preceded with whitespace. at Line: 27 Column: 66
12. Message: 'method def' child have incorrect indentation level 8, expected level should be 4. at Line: 27 Column: None
13. Message: '(' is not followed by whitespace. at Line: 28 Column: 76
14. Message: ')' is not preceded with whitespace. at Line: 28 Column: 84
15. Message: 'member def type' have incorrect indentation level 8, expected level should be 4. at Line: 28 Column: None
16. Message: 'method def' child have incorrect indentation level 8, expected level should be 4. at Line: 28 Column: None
17. Message: 'method def' child have incorrect indentation level 8, expected level should be 4. at Line: 29 Column: None
18. Message: 'method def rcurly' have incorrect indentation level 4, expected level should be 2. at Line: 30 Column: None
19. Message: Unused import - org.pentaho.di.trans.steps.systemdata.SystemData. at Line: 8 Column: 8

License header violations:

1. cpk-core/src/pt/webdetails/cpk/utils/ZipUtil.java
2. cpk-core/test-src/pt/webdetails/cpk/utils/ZipUtilTest.java

[pamval]

uggh, @graimundo can we fix these before merging this change ?

[buildguy]

❌ Build failed in 1h 32m 38s

Build command:

mvn clean verify -B -e -Daudit -amd

---

❗ No tests found!

Errors:

Filtered log (click to expand)

script returned exit code 1

ℹ️ This is an automatic message