-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[scoped-custom-element-registry] Add basic jsdom tests #530
base: master
Are you sure you want to change the base?
Conversation
…oped-custom-element-registry`
jsdom
tests
jsdom 20.0.2 contains the PR with the fix. |
I'm trying this out here: 39e3f06 |
Except for the formatting, the tests passed on that commit. I reformatted and pushed here. (These still won't pass until |
Added "Skip Changelog" label because there are no user-facing changes. |
jsdom currently has a bug where it reads the global custom elements registry by looking through the sandbox-facing
customElements
property of its global object. This means that scripts running in that context can break jsdom's custom elements implementation by overwriting or deleting thecustomElements
global.I'm making a PR to fix jsdom upstream. Once
jsdom
andjest-environment-jsdom
are released with updated versions, these tests should pass.Closes #459.