Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sample property in schema #107

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

sample property in schema #107

wants to merge 1 commit into from

Conversation

jogibear9988
Copy link
Contributor

No description provided.

@jogibear9988 jogibear9988 mentioned this pull request Jul 10, 2022
Open
@jogibear9988
Copy link
Contributor Author

Now there is a demo section, maybe this also could be part of it

@justinfagnani
Copy link
Collaborator

Edits should be made to schema.d.ts, not to schema.json which is generated from it.

Also, I think we need more consideration around which types have samples attached to them, and what exactly should be in the sample. Is it all types. Is it code, prose, a link?

I would rather discuss this in an issue than a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jogibear9988 @justinfagnani