Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: rm console.warn if scrypt not present #3045

Closed
wants to merge 1 commit into from

Conversation

CruzMolina
Copy link
Contributor

🙏

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 83.107% when pulling c6aa8fb on CruzMolina:patch-1 into 7d1b0ea on ethereum:1.x.

Copy link
Contributor

@gnidan gnidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please!

@michaelsbradleyjr
Copy link
Contributor

michaelsbradleyjr commented Aug 26, 2019

Already done in #3035, #3036. That warning is now only printed when installing web3.

I'm about to make a PR for the web3-js/scrypt-shim repo that will remove the runtime warning in the event of maxmem exceptions, since the true reason those may arise is now understood. I will also make a PR for this repo to remove the static tests (copied from go-ethereum's repo) that contain invalid kdf parameters.

@michaelsbradleyjr
Copy link
Contributor

Quick update on improvements to scrypt-shim: https://github.com/web3-js/scrypt-shim/compare/master...michaelsbradleyjr:refactor-per-rfc?expand=1.

I've done my best to be super-attentive to edge cases and whatnot. Last thing is to get the test suite into proper shape. PRs #3035, #3036 will be updated once that work is complete and the PR has been submitted for scrypt-shim.

@nivida
Copy link
Contributor

nivida commented Sep 5, 2019

I'm closing this PR because of the mentioned PRs for 1.x and 2.x from @michaelsbradleyjr

@nivida nivida closed this Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants