Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: website release does not need test-e2e #1875

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: website release does not need test-e2e #1875

wants to merge 1 commit into from

Conversation

gobengo
Copy link
Contributor

@gobengo gobengo commented Sep 9, 2022 •
edited
Loading

Motivation:

  • the e2e tests are getting in the way of this release step releasing a bugfix to prod
  • e2e tests are new. i think im the only person who really uses them atm. we dont need to block the release on them. they can just be a useful helper signal, not a blocker. when they are more stable and/or faster, we can consider blocking release on them (or just not)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

Website preview 🔗✨

build log

@gobengo gobengo marked this pull request as ready for review September 9, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olizilla olizilla Awaiting requested review from olizilla

@vasco-santos vasco-santos Awaiting requested review from vasco-santos

@yusefnapora yusefnapora Awaiting requested review from yusefnapora

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gobengo