webnn: replace DataError with TypeError #46845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec had been updated to throw TypeError for failed input validations: webmachinelearning/webnn#589. This CL replaces the last remaining DataErrors in lstm implementation and triangular wpt. Bug: 40206287 Change-Id: I73952ce5b407f2df1d9d3b22c0086638d092e811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5632940 Commit-Queue: Austin Sullivan <[email protected]> Reviewed-by: Austin Sullivan <[email protected]> Auto-Submit: Jiewei Qian <[email protected]> Cr-Commit-Position: refs/heads/main@{#1317381}
wpt-pr-bot
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec had been updated to throw TypeError for failed input
validations: webmachinelearning/webnn#589.
This CL replaces the last remaining DataErrors in lstm implementation and triangular wpt.
Bug: 40206287
Change-Id: I73952ce5b407f2df1d9d3b22c0086638d092e811
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5632940
Commit-Queue: Austin Sullivan <[email protected]>
Reviewed-by: Austin Sullivan <[email protected]>
Auto-Submit: Jiewei Qian <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1317381}