Add testdriver support for WebDriver BiDi #45823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadym-chromium
force-pushed
the
sadym/testdriver-bidi-implementation
branch
22 times, most recently
from
c8c1c2b to
1376a29
Compare
sadym-chromium
force-pushed
the
sadym/testdriver-bidi-implementation
branch
5 times, most recently
from
f053493 to
d28adf8
Compare
sadym-chromium
force-pushed
the
sadym/testdriver-bidi-implementation
branch
2 times, most recently
from
fb2013f to
b8390b8
Compare
wpt-pr-bot
requested review from
AutomatedTester,
ayuishii,
beaufortfrancois,
birtles,
boggydigital,
Brandr0id and
chrishtr
sadym-chromium
force-pushed
the
sadym/testdriver-bidi-implementation
branch
2 times, most recently
from
db2053f to
2f4f00d
Compare
alvestrand
removed request for
a team,
alvestrand,
aliams,
Brandr0id,
andypaicu,
ayuishii and
DanielRyanSmith
sadym-chromium
force-pushed
the
sadym/testdriver-bidi-implementation
branch
from
2f4f00d to
222b7ad
Compare
foolip
approved these changes
Aug 5, 2024
jonathan-j-lee
added a commit
to jonathan-j-lee/wpt
that referenced
this pull request
Sep 17, 2024
Starting in web-platform-tests#45823, `create_context_action()` wraps `create_action()` in `testdriver-extra.js`. Some methods still pass the old `create_action()` arguments to `create_context_action()`, which incorrectly assigns `__wptrunner_id` to the params object and not the `WindowProxy`. This causes `TestDriverProtocolPart.switch_to_window()` to fail to find the requested window [1]. [0]: https://github.com/web-platform-tests/wpt/blob/2a471e0d/tools/wptrunner/wptrunner/testdriver-extra.js#L85 [1]: https://wpt.fyi/results/device-posture/device-posture-clear.https.html?run_id=5117148234252288&run_id=5157553306861568&run_id=5072332666437632&run_id=5173437035446272
jonathan-j-lee
added a commit
that referenced
this pull request
Sep 17, 2024
Starting in #45823, `create_context_action()` wraps `create_action()` in `testdriver-extra.js`. Some methods still pass the old `create_action()` arguments to `create_context_action()`, which incorrectly assigns `__wptrunner_id` to the params object [0] and not the `WindowProxy`. This causes `TestDriverProtocolPart.switch_to_window()` to fail to find the requested window [1]. [0]: https://github.com/web-platform-tests/wpt/blob/2a471e0d/tools/wptrunner/wptrunner/testdriver-extra.js#L85 [1]: https://wpt.fyi/results/device-posture/device-posture-clear.https.html?run_id=5117148234252288&run_id=5157553306861568&run_id=5072332666437632&run_id=5173437035446272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement RFC 185: Add WebDriver BiDi support to testdriver.js. Based on #44649.
Addition to the RFC:
Open question:
infrastructure/webdriver/biditests?Blocked by:
Tue, Jun 11, 2024, when it reaches stable. Tracking.