Implement CloseWatcher integration for popovers #41080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 18, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4686066
branch
from
d1479cc
to
299a70d
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4686066
branch
from
299a70d
to
866157d
Compare
This is being integrated in this HTML spec PR which adds CloseWatchers: whatwg/html#9462 CloseWatcher is not enabled right now, so this patch should not make any behavior changes to stable chrome. This patch makes it so that pressing the escape key uses the document/window's closewatcher stack to find a popover to light dismiss rather than HandlePopoverLightDismiss hiding whatever the TopmostPopoverOrHint is. Hopefully they agree with each other. The behavior change for popovers is that the android back button can close popovers, and this gives popovers the grouping-without-user-activation behavior that dialogs have (with the flag enabled). If you open 5 popovers with a single user activation, then any close signal (including Esc on desktop) will close all 5 of those popovers, not just the topmost one. Bug: 1171318 Change-Id: I73740c3eb9c16b0883862ae259be4867b824a79c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4686066 Reviewed-by: Domenic Denicola <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1174590}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4686066
branch
from
866157d
to
5d0ce69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is being integrated in this HTML spec PR which adds CloseWatchers:
whatwg/html#9462
CloseWatcher is not enabled right now, so this patch should not make any
behavior changes to stable chrome.
This patch makes it so that pressing the escape key uses the
document/window's closewatcher stack to find a popover to light dismiss
rather than HandlePopoverLightDismiss hiding whatever the
TopmostPopoverOrHint is. Hopefully they agree with each other.
The behavior change for popovers is that the android back button can
close popovers, and this gives popovers the
grouping-without-user-activation behavior that dialogs have (with the
flag enabled). If you open 5 popovers with a single user activation,
then any close signal (including Esc on desktop) will close all 5 of
those popovers, not just the topmost one.
Bug: 1171318
Change-Id: I73740c3eb9c16b0883862ae259be4867b824a79c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4686066
Reviewed-by: Domenic Denicola <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1174590}