Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add webnn softmax tests #37254

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Add webnn softmax tests #37254

merged 1 commit into from
Jan 6, 2023

Conversation

BruceDai
Copy link
Contributor

@BruceDai BruceDai commented Nov 30, 2022 •
edited
Loading

@BruceDai BruceDai mentioned this pull request Nov 30, 2022
Merged
fdwr
fdwr reviewed Dec 1, 2022
View reviewed changes
webnn/resources/utils.js Outdated Show resolved Hide resolved
fdwr
fdwr reviewed Dec 1, 2022
View reviewed changes
Copy link

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment. Otherwise signed off.

@BruceDai BruceDai mentioned this pull request Dec 1, 2022
Closed
@BruceDai BruceDai force-pushed the add_webnn_softmax_tests branch from 884855f to 47919b7 Compare December 1, 2022 12:56
@BruceDai BruceDai force-pushed the add_webnn_softmax_tests branch from 47919b7 to a770bf0 Compare January 6, 2023 07:54
@BruceDai
Copy link
Contributor Author

BruceDai commented Jan 6, 2023

@Honry All checks passed, PTAL, thanks.

Honry
Honry approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@Honry Honry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Honry Honry merged commit c421063 into web-platform-tests:master Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Honry Honry Honry approved these changes

@fdwr fdwr fdwr approved these changes

@dontcallmedom dontcallmedom Awaiting requested review from dontcallmedom

Assignees

@dontcallmedom dontcallmedom

Labels
webnn wg-s_webmachinelearning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BruceDai @fdwr @Honry @dontcallmedom @wpt-pr-bot