[wasm] Enable and fix wasm exceptions WPTs #36607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 21, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3972061
branch
from
a50532e
to
01059b2
Compare
For most tests, expectations were deleted since the tests now pass. The getArg test was corrected to match the spec: https://webassembly.github.io/exception-handling/js-api/index.html#dom-exception-getarg The tag type test had its expectations updated, but is still (incorrectly) failing because the test also depends on the not-yet-shipped type reflection proposal. Updated the spec bug to bring this conversation back to the spec (WebAssembly/exception-handling#172). Bug: v8:11992 Change-Id: I979a9eb00219e0b9515d43bbeff6f80ac57df7c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3972061 Reviewed-by: Andreas Haas <[email protected]> Commit-Queue: Adam Klein <[email protected]> Cr-Commit-Position: refs/heads/main@{#1063368}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3972061
branch
from
01059b2
to
e5e5a2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For most tests, expectations were deleted since the tests now pass.
The getArg test was corrected to match the spec:
https://webassembly.github.io/exception-handling/js-api/index.html#dom-exception-getarg
The tag type test had its expectations updated, but is still
(incorrectly) failing because the test also depends on the not-yet-shipped
type reflection proposal. Updated the spec bug to bring this conversation
back to the spec (WebAssembly/exception-handling#172).
Bug: v8:11992
Change-Id: I979a9eb00219e0b9515d43bbeff6f80ac57df7c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3972061
Reviewed-by: Andreas Haas <[email protected]>
Commit-Queue: Adam Klein <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1063368}