Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP/1 parsing of responses without newlines after headers #27456

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

annevk
Copy link
Member

@annevk annevk commented Feb 3, 2021

[
"header: value\t",
"header: value ",
"header: value\f",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"" and "header: value\n" seems like the most important ones to test here.

Also seems worth testing "HTTP/1.1 200 OKAYISH" alone (no LF)

Per other comment, I'm concerned about large (HTTP-only) breakage from browsers actually enforcing this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I explicitly don't want to test header: value\n here as we do have interoperable behavior on not returning a network error there. Maybe that should change, but let's tackle that separately.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure? I'm pretty sure Chrome doesn't allow that over HTTPS.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I should create separate HTTPS tests then...

@domfarolino
Copy link
Member

Was just looking through PRs that were assigned to me on GitHub and came across this. What's the status?

@annevk
Copy link
Member Author

annevk commented Mar 12, 2023

As per above, this needs an HTTPS test. It might also need some reevaluation of the results across implementations given the time that has passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants