Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove PaymentAddress.regionCode tests" #15501

Merged
merged 1 commit into from
Apr 8, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ <h2>PaymentAddress interface</h2>
<button onclick="
const expectedAddress = {
country: 'AU',
regionCode: 'QLD',
addressLine: '55 test st',
city: 'Chapel Hill',
dependentLocality: '',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,11 @@ <h2>
The payment sheet shows "REGION ERROR" for the shipping address' region.
</button>
</li>
<li>
<button onclick="retryShowsShippingAddressMember(this, { regionCode: 'REGIONCODE ERROR' });">
The payment sheet shows "REGIONCODE ERROR" for the shipping address' region code.
</button>
</li>
<li>
<button onclick="retryShowsShippingAddressMember(this, { sortingCode: 'SORTINGCODE ERROR' });">
The payment sheet shows "SORTINGCODE ERROR" for the shipping address' sorting code.
Expand Down
3 changes: 0 additions & 3 deletions payment-request/historical.https.html
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@

// https://github.com/w3c/payment-request/pull/765
["languageCode", "PaymentAddress"],

// https://github.com/w3c/payment-request/pull/823
["regionCode", "PaymentAddress"],
].forEach(([member, interf]) => {
test(() => {
assert_false(member in window[interf].prototype);
Expand Down