Start running the parsed file lints against support files

This is largely motivated by ensuring that people aren't including testharnessreport.js in support files which are then included via fetch_tests_from_window, and most of the files changed here are removing redundant inclusions here. We also find a few other errors, such as testdriver-vendor.js being omitted and invalid values for <meta name=timeout>, which are also fixed. Finally, add a few things to the allowlist.
web-platform-tests · Sep 25, 2024 · f6f4163 · f6f4163
1 parent 754fa51
commit f6f4163
Show file tree

Hide file tree

Showing 143 changed files with 47 additions and 143 deletions.
diff --git a/appmanifest/protocol_handlers-member/resources/protocol_handlers_entry.html b/appmanifest/protocol_handlers-member/resources/protocol_handlers_entry.html
@@ -4,7 +4,6 @@
  <meta charset="utf-8">
  <title>Protocol Handling Web Platform Test - Pass</title>
  <script src="/resources/testharness.js"></script>
- <script src="/resources/testharnessreport.js"></script>
  <script>
  setup({ single_test: true });
  const urlParams = new URLSearchParams(window.location.search);

diff --git a/client-hints/sandbox/resources/embedded-popup-expect-hints.html b/client-hints/sandbox/resources/embedded-popup-expect-hints.html
@@ -2,7 +2,6 @@
 <html>
 <body>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="util.js"></script>
 <script>
 sandbox_popup_listener("/client-hints/resources/expect-client-hints-headers.html");

diff --git a/client-hints/sandbox/resources/embedded-popup-expect-no-hints.html b/client-hints/sandbox/resources/embedded-popup-expect-no-hints.html
@@ -2,7 +2,6 @@
 <html>
 <body>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="util.js"></script>
 <script>
 sandbox_popup_listener("/client-hints/resources/expect-no-client-hints-headers.html");

diff --git a/compute-pressure/resources/support-iframe.html b/compute-pressure/resources/support-iframe.html
@@ -2,7 +2,6 @@
 <meta charset="utf-8">
 <title>compute pressure iframe tester</title>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script>
 async function messageHandler(e) {
  if (e.data.command === 'start') {

diff --git a/content-security-policy/frame-ancestors/support/frame-in-frame.sub.html b/content-security-policy/frame-ancestors/support/frame-in-frame.sub.html
@@ -2,7 +2,6 @@
 <html>
 <body>
  <script src='/resources/testharness.js'></script>
- <script src='/resources/testharnessreport.js'></script>
  <script src='/content-security-policy/frame-ancestors/support/frame-ancestors-test.sub.js'></script>
 
  <span id="escape">{{GET[policy]}}</span>

diff --git a/content-security-policy/navigation/support/test_csp_self_window.sub.html b/content-security-policy/navigation/support/test_csp_self_window.sub.html
@@ -1,6 +1,5 @@
 <!DOCTYPE html>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 
 <span id="escape">{{GET[window_url]}}</span>
 

diff --git a/cookies/partitioned-cookies/resources/partitioned-cookies-cross-site-embed.html b/cookies/partitioned-cookies/resources/partitioned-cookies-cross-site-embed.html
@@ -3,7 +3,6 @@
 <meta name="timeout" content="long">
 <title>Test site embedded in a cross-site context</title>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="/common/get-host-info.sub.js"></script>
 <script src="/cookies/resources/cookie-helper.sub.js"></script>
 <script src="/cookies/partitioned-cookies/resources/test-helpers.js"></script>

diff --git a/cookies/partitioned-cookies/resources/partitioned-cookies-top-level-redirect.html b/cookies/partitioned-cookies/resources/partitioned-cookies-top-level-redirect.html
@@ -3,7 +3,6 @@
 <meta name="timeout" content="long">
 <title>Test partitioned cookie top level cross-site</title>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="/common/get-host-info.sub.js"></script>
 <script src="/cookies/resources/cookie-helper.sub.js"></script>
 <script src="/cookies/partitioned-cookies/resources/test-helpers.js"></script>

diff --git a/cookies/third-party-cookies/resources/third-party-cookies-cross-site-embed.html b/cookies/third-party-cookies/resources/third-party-cookies-cross-site-embed.html
@@ -3,7 +3,6 @@
 <meta name="timeout" content="long">
 <title>Test site embedded in a cross-site context</title>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="/common/get-host-info.sub.js"></script>
 <script src="/cookies/resources/cookie-helper.sub.js"></script>
 <script src="/cookies/third-party-cookies/resources/test-helpers.js"></script>

diff --git a/fenced-frame/resources/automatic-beacon-unfenced-page.html b/fenced-frame/resources/automatic-beacon-unfenced-page.html
@@ -2,7 +2,6 @@
 <title>Page navigated to by an _unfencedTop navigation</title>
 
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="utils.js"></script>
 <script src="/common/get-host-info.sub.js"></script>
 

diff --git a/fenced-frame/resources/background-fetch-inner.https.html b/fenced-frame/resources/background-fetch-inner.https.html
@@ -1,6 +1,5 @@
 <!DOCTYPE html>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="utils.js"></script>
 <title>Fenced frame content to report the result of background fetch</title>
 

diff --git a/fenced-frame/resources/background-fetch-sw-inner.https.html b/fenced-frame/resources/background-fetch-sw-inner.https.html
@@ -1,6 +1,5 @@
 <!DOCTYPE html>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="utils.js"></script>
 <title>Fenced frame content to report the result of background fetch in SW</title>
 

diff --git a/fenced-frame/resources/background-sync-inner.https.html b/fenced-frame/resources/background-sync-inner.https.html
@@ -1,6 +1,5 @@
 <!DOCTYPE html>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="utils.js"></script>
 <title>Fenced frame content to report the result of background sync's register</title>
 

diff --git a/fenced-frame/resources/background-sync-sw-inner.https.html b/fenced-frame/resources/background-sync-sw-inner.https.html
@@ -1,6 +1,5 @@
 <!DOCTYPE html>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="utils.js"></script>
 <title>Fenced frame content to report the result of background sync's register in SW</title>
 

diff --git a/fenced-frame/resources/ignore-child-fenced-frame-onload-event-inner.html b/fenced-frame/resources/ignore-child-fenced-frame-onload-event-inner.html
@@ -1,7 +1,6 @@
 <!DOCTYPE html>
 <title>child frame with delayed onload event</title>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="utils.js"></script>
 
 <body>

diff --git a/fenced-frame/resources/navigate-ancestor-from-nested-fenced-frame.https.html b/fenced-frame/resources/navigate-ancestor-from-nested-fenced-frame.https.html
@@ -1,7 +1,6 @@
 <!DOCTYPE html>
 <title>Navigate ancestor helper</title>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="utils.js"></script>
 
 <body>

diff --git a/fenced-frame/resources/navigate-ancestor-from-nested-iframe.https.html b/fenced-frame/resources/navigate-ancestor-from-nested-iframe.https.html
@@ -1,7 +1,6 @@
 <!DOCTYPE html>
 <title>Navigate ancestor helper from nested fenced frame</title>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="utils.js"></script>
 
 <body>

diff --git a/fenced-frame/resources/navigate-ancestor-test-runner.https.html b/fenced-frame/resources/navigate-ancestor-test-runner.https.html
@@ -1,7 +1,6 @@
 <!DOCTYPE html>
 <title>Test navigating an ancestor frame from within a fenced frame</title>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="utils.js"></script>
 
 <body>

diff --git a/fenced-frame/resources/permission-geolocation-test-runner.html b/fenced-frame/resources/permission-geolocation-test-runner.html
@@ -1,7 +1,6 @@
 <!DOCTYPE html>
 <title>Fenced frame content to report the result of navigator.geolocation.getCurrentPosition()</title>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="/resources/testdriver.js"></script>
 <script src="/resources/testdriver-vendor.js"></script>
 <script src="utils.js"></script>

diff --git a/fenced-frame/resources/window-navigation-204-inner.html b/fenced-frame/resources/window-navigation-204-inner.html
@@ -1,6 +1,5 @@
 <!DOCTYPE html>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="utils.js"></script>
 <title>Fenced frame content to report the value of window.navigation</title>
 

diff --git a/fetch/connection-pool/resources/network-partition-about-blank-checker.html b/fetch/connection-pool/resources/network-partition-about-blank-checker.html
@@ -4,7 +4,6 @@
  <meta charset="utf-8">
  <title>about:blank Network Partition Checker</title>
  <meta name="help" href="https://fetch.spec.whatwg.org/#network-partition-keys">
- <meta name="timeout" content="normal">
 </head>
 <body>
 <script>

diff --git a/fetch/connection-pool/resources/network-partition-checker.html b/fetch/connection-pool/resources/network-partition-checker.html
@@ -4,7 +4,6 @@
  <meta charset="utf-8">
  <title>Network Partition Checker</title>
  <meta name="help" href="https://fetch.spec.whatwg.org/#network-partition-keys">
- <meta name="timeout" content="normal">
  <script src="SUBRESOURCE_PREFIX:&dispatch=fetch_file&path=common/utils.js"></script>
  <script src="SUBRESOURCE_PREFIX:&dispatch=fetch_file&path=resources/testharness.js"></script>
  <script src="SUBRESOURCE_PREFIX:&dispatch=fetch_file&path=fetch/connection-pool/resources/network-partition-key.js"></script>

diff --git a/fetch/connection-pool/resources/network-partition-iframe-checker.html b/fetch/connection-pool/resources/network-partition-iframe-checker.html
@@ -4,7 +4,6 @@
  <meta charset="utf-8">
  <title>Iframe Network Partition Checker</title>
  <meta name="help" href="https://fetch.spec.whatwg.org/#network-partition-keys">
- <meta name="timeout" content="normal">
  <script src="SUBRESOURCE_PREFIX:&dispatch=fetch_file&path=common/utils.js"></script>
  <script src="SUBRESOURCE_PREFIX:&dispatch=fetch_file&path=resources/testharness.js"></script>
  <script src="SUBRESOURCE_PREFIX:&dispatch=fetch_file&path=fetch/connection-pool/resources/network-partition-key.js"></script>

diff --git a/fetch/connection-pool/resources/network-partition-worker-checker.html b/fetch/connection-pool/resources/network-partition-worker-checker.html
@@ -4,7 +4,6 @@
  <meta charset="utf-8">
  <title>Worker Network Partition Checker</title>
  <meta name="help" href="https://fetch.spec.whatwg.org/#network-partition-keys">
- <meta name="timeout" content="normal">
  <script src="SUBRESOURCE_PREFIX:&dispatch=fetch_file&path=common/utils.js"></script>
  <script src="SUBRESOURCE_PREFIX:&dispatch=fetch_file&path=resources/testharness.js"></script>
  <script src="SUBRESOURCE_PREFIX:&dispatch=fetch_file&path=fetch/connection-pool/resources/network-partition-key.js"></script>

diff --git a/fetch/http-cache/resources/split-cache-popup-with-iframe.html b/fetch/http-cache/resources/split-cache-popup-with-iframe.html
@@ -4,7 +4,6 @@
  <meta charset="utf-8">
  <title>HTTP Cache - helper</title>
  <meta name="help" href="https://fetch.spec.whatwg.org/#http-cache-partitions">
- <meta name="timeout" content="normal">
  <script src="/resources/testharness.js"></script>
  <script src="/common/get-host-info.sub.js"></script>
 </head>

diff --git a/fetch/http-cache/resources/split-cache-popup.html b/fetch/http-cache/resources/split-cache-popup.html
@@ -4,7 +4,6 @@
  <meta charset="utf-8">
  <title>HTTP Cache - helper</title>
  <meta name="help" href="https://fetch.spec.whatwg.org/#http-cache-partitions">
- <meta name="timeout" content="normal">
  <script src="/resources/testharness.js"></script>
  <script src="../http-cache.js"></script>
 </head>

diff --git a/focus/support/focus-event-after-switching-iframes-inner.html b/focus/support/focus-event-after-switching-iframes-inner.html
@@ -5,6 +5,7 @@
  <title>Focus event inner document</title>
 </head>
 <script src="/resources/testdriver.js"></script>
+<script src="/resources/testdriver-vendor.js"></script>
 <script src="/resources/testdriver-actions.js"></script>
 <body>
 <h1>Inner</h1>

diff --git a/...g-the-web/history-traversal/pagereveal/resources/order-in-prerender-activation-popup.html b/...g-the-web/history-traversal/pagereveal/resources/order-in-prerender-activation-popup.html
@@ -2,7 +2,6 @@
 <title>pagereveal event fires and in correct order on prerender activation (popup)</title>
 <link rel="author" href="mailto:[email protected]">
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="/speculation-rules/prerender/resources/utils.js"></script>
 <script>
 const params = new URLSearchParams(location.search);

diff --git a/intersection-observer/resources/observer-in-iframe-subframe.html b/intersection-observer/resources/observer-in-iframe-subframe.html
@@ -1,6 +1,5 @@
 <!DOCTYPE html>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="./intersection-observer-test-utils.js"></script>
 
 <style>

diff --git a/lint.ignore b/lint.ignore
@@ -75,6 +75,12 @@ AHEM COPY: fonts/Ahem.ttf
 # None of these are actually Ahem
 AHEM COPY: fonts/ahem-extra/AHEM_*.TTF
 
+## Ignore the testharness.js unit tests
+INVALID-TIMEOUT: resources/test/*
+TESTHARNESS-PATH: resources/test/*
+TESTHARNESSREPORT-IN-UNSUPPORTED-TYPE: resources/test/*
+TESTHARNESSREPORT-PATH: resources/test/*
+
 ## Test exclusions ##
 
 # Intentional use of CRLF
@@ -138,6 +144,12 @@ PARSE-FAILED: dom/nodes/Document-createElement-namespace-tests/minimal_html.xhtm
 PARSE-FAILED: dom/nodes/Document-createElement-namespace-tests/minimal_html.xml
 PARSE-FAILED: custom-elements/xhtml-crash.xhtml
 
+# Files that don't parse because UTF-32 support is gone
+PARSE-FAILED: encoding/resources/utf-32-little-endian-nobom.xml
+PARSE-FAILED: encoding/resources/utf-32-little-endian-bom.xml
+PARSE-FAILED: encoding/resources/utf-32-big-endian-nobom.xml
+PARSE-FAILED: encoding/resources/utf-32-big-endian-bom.xml
+
 # setTimeout usage (should probably mostly be fixed)
 SET TIMEOUT: *-manual.*
 SET TIMEOUT: annotation-model/scripts/ajv.min.js
@@ -461,6 +473,18 @@ INDENT TABS: css/mediaqueries/*
 INDENT TABS: css/selectors/*
 INDENT TABS: css/WOFF2/*
 
+## Templates can deal with certain things being wrong; we only care about the output
+INVALID-TIMEOUT: */templates/*
+NON-EXISTENT-REF: */*-template.html
+NON-EXISTENT-REF: */templates/*
+NON-EXISTENT-REF: css/css-images/tools/template-object-fit-test.html
+NON-EXISTENT-REF: css/css-images/tools/template-object-position-test.html
+REFERENCE-IN-OTHER-TYPE: */*-template.html
+REFERENCE-IN-OTHER-TYPE: */templates/*
+REFERENCE-IN-OTHER-TYPE: css/css-images/tools/template-object-fit-test.html
+REFERENCE-IN-OTHER-TYPE: css/css-images/tools/template-object-position-test.html
+TESTHARNESSREPORT-IN-UNSUPPORTED-TYPE: */templates/*
+TESTHARNESSREPORT-IN-UNSUPPORTED-TYPE: css/css-writing-modes/tools/generators/template.html
 
 ## Things we're stopping from getting worse
 CONSOLE: css/css-shapes/shape-outside/supported-shapes/support/test-utils.js
@@ -818,3 +842,12 @@ TESTDRIVER-IN-UNSUPPORTED-TYPE: payment-handler/change-shipping-option-manual.ht
 TESTDRIVER-IN-UNSUPPORTED-TYPE: payment-handler/payment-request-event-manual.https.html
 TESTDRIVER-IN-UNSUPPORTED-TYPE: payment-handler/supports-shipping-contact-delegation-manual.https.html
 TESTDRIVER-IN-UNSUPPORTED-TYPE: shadow-dom/crashtests/move-to-new-tree-1343016.html
+
+# Intentional use of testharness.js with an absolute URL
+TESTHARNESS-PATH: fetch/connection-pool/resources/network-partition-checker.html
+TESTHARNESS-PATH: fetch/connection-pool/resources/network-partition-iframe-checker.html
+TESTHARNESS-PATH: fetch/connection-pool/resources/network-partition-worker-checker.html
+
+# View Transitions tests include references relative to the original test URL
+NON-EXISTENT-REF: css/css-view-transitions/navigation/resources/*
+REFERENCE-IN-OTHER-TYPE: css/css-view-transitions/navigation/resources/*
diff --git a/loading/early-hints/resources/404-with-early-hints.html b/loading/early-hints/resources/404-with-early-hints.html
@@ -1,7 +1,6 @@
 <!DOCTYPE html>
 <meta charset=utf-8>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="early-hints-helpers.sub.js"></script>
 <body>
 <script>

diff --git a/loading/early-hints/resources/arbitrary-header-in-early-hints.html b/loading/early-hints/resources/arbitrary-header-in-early-hints.html
@@ -1,7 +1,6 @@
 <!DOCTYPE html>
 <meta charset=utf-8>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <body>
 <script>
 promise_test(async (t) => {

diff --git a/loading/early-hints/resources/coep-mismatch.html b/loading/early-hints/resources/coep-mismatch.html
@@ -1,7 +1,6 @@
 <!DOCTYPE html>
 <meta charset=utf-8>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="early-hints-helpers.sub.js"></script>
 <body>
 <script>

diff --git a/loading/early-hints/resources/csp-basic.html b/loading/early-hints/resources/csp-basic.html
@@ -1,7 +1,6 @@
 <!DOCTYPE html>
 <meta charset=utf-8>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="early-hints-helpers.sub.js"></script>
 <body>
 <script>

diff --git a/loading/early-hints/resources/csp-document-disallow.html b/loading/early-hints/resources/csp-document-disallow.html
@@ -2,7 +2,6 @@
 <meta charset=utf-8>
 <meta http-equiv="Content-Security-Policy" content="script-src 'self' 'unsafe-inline'">
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="early-hints-helpers.sub.js"></script>
 <body>
 <script>

diff --git a/loading/early-hints/resources/modulepreload-in-early-hints.html b/loading/early-hints/resources/modulepreload-in-early-hints.html
@@ -1,7 +1,6 @@
 <!DOCTYPE html>
 <meta charset=utf-8>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="early-hints-helpers.sub.js"></script>
 <body>
 <script>

diff --git a/loading/early-hints/resources/multiple-early-hints-responses.html b/loading/early-hints/resources/multiple-early-hints-responses.html
@@ -1,7 +1,6 @@
 <!DOCTYPE html>
 <meta charset=utf-8>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="early-hints-helpers.sub.js"></script>
 <body>
 <script>

diff --git a/loading/early-hints/resources/preconnect-in-early-hints.html b/loading/early-hints/resources/preconnect-in-early-hints.html
@@ -1,7 +1,6 @@
 <!DOCTYPE html>
 <meta charset=utf-8>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="early-hints-helpers.sub.js"></script>
 <body>
 <script>

diff --git a/loading/early-hints/resources/preload-as-test.html b/loading/early-hints/resources/preload-as-test.html
@@ -1,7 +1,6 @@
 <!DOCTYPE html>
 <meta charset=utf-8>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="early-hints-helpers.sub.js"></script>
 <body>
 <script>

diff --git a/loading/early-hints/resources/preload-fetch.html b/loading/early-hints/resources/preload-fetch.html
@@ -1,7 +1,6 @@
 <!DOCTYPE html>
 <meta charset=utf-8>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="early-hints-helpers.sub.js"></script>
 <body>
 <script>

diff --git a/loading/early-hints/resources/preload-fetchpriority.html b/loading/early-hints/resources/preload-fetchpriority.html
@@ -1,7 +1,6 @@
 <!DOCTYPE html>
 <meta charset=utf-8>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="early-hints-helpers.sub.js"></script>
 <body>
 <script>

diff --git a/loading/early-hints/resources/preload-finished-before-final-response.html b/loading/early-hints/resources/preload-finished-before-final-response.html
@@ -1,7 +1,6 @@
 <!DOCTYPE html>
 <meta charset=utf-8>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="early-hints-helpers.sub.js"></script>
 <body>
 <script>

diff --git a/loading/early-hints/resources/preload-finished-while-receiving-final-response-body.html b/loading/early-hints/resources/preload-finished-while-receiving-final-response-body.html
@@ -1,7 +1,6 @@
 <!DOCTYPE html>
 <meta charset=utf-8>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="early-hints-helpers.sub.js"></script>
 <body>
 <script>

diff --git a/loading/early-hints/resources/preload-in-flight-when-consumed.html b/loading/early-hints/resources/preload-in-flight-when-consumed.html
@@ -1,7 +1,6 @@
 <!DOCTYPE html>
 <meta charset=utf-8>
 <script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
 <script src="early-hints-helpers.sub.js"></script>
 <body>
 <script>