Skip to content

Commit

Permalink
network.https.window.html?11-15 failed due to harness error
Browse files Browse the repository at this point in the history
Error message: Tried to run in a non-testharness window
without a call to set_test_context

setCookie uses a test driver call to delete the cookies. Set
test context fixed the issue.

Bug: 338066470
Change-Id: I334c3f422127b689434c117a8f949d3b80b6a402
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5895659
Reviewed-by: Russ Hamilton <[email protected]>
Commit-Queue: Weizhong Xia <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1361833}
  • Loading branch information
WeizhongX authored and chromium-wpt-export-bot committed Sep 30, 2024
1 parent 8b5024d commit 4c897e8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions fledge/tentative/network.https.window.js
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ subsetTest(promise_test, async test => {
subsetTest(promise_test, async test => {
const uuid = generateUuid(test);
let cookieFrame = await createFrame(test, OTHER_ORIGIN1);
await runInFrame(test, cookieFrame, `await setCookie(test_instance)`);
await runInFrame(test, cookieFrame, `test_driver.set_test_context(window.parent); await setCookie(test_instance)`);

await joinGroupAndRunBasicFledgeTestExpectingWinner(
test,
Expand Down Expand Up @@ -315,7 +315,7 @@ subsetTest(promise_test, async test => {
subsetTest(promise_test, async test => {
const uuid = generateUuid(test);
let cookieFrame = await createFrame(test, OTHER_ORIGIN1);
await runInFrame(test, cookieFrame, `await setCookie(test_instance)`);
await runInFrame(test, cookieFrame, `test_driver.set_test_context(window.parent); await setCookie(test_instance)`);

let renderURL = createRenderURL(uuid, /*script=*/null, /*signalsParam=*/'headers,cors');

Expand Down

0 comments on commit 4c897e8

Please sign in to comment.