Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add discouraged mutation events #2518

Merged
merged 5 commits into from
Jan 14, 2025
Merged

Add discouraged mutation events #2518

merged 5 commits into from
Jan 14, 2025

Conversation

captainbrosset
Copy link
Contributor

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Jan 10, 2025
ddbeck
ddbeck reviewed Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple little ideas for you. Thanks, Patrick!

features/mutationevent.yml Outdated Show resolved Hide resolved
features/mutationevent.yml Outdated Show resolved Hide resolved
@captainbrosset captainbrosset requested a review from ddbeck January 14, 2025 09:00
@captainbrosset
Copy link
Contributor Author

Feedback addressed. Thanks.

ddbeck
ddbeck approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I noticed one little error in my suggested description—I'm going to apply it and merge it. Thank you!

features/mutation-events.yml Outdated Show resolved Hide resolved
@ddbeck ddbeck enabled auto-merge (squash) January 14, 2025 09:30
@ddbeck ddbeck merged commit ce61d18 into main Jan 14, 2025
3 checks passed
@ddbeck ddbeck deleted the mutation-events branch January 14, 2025 09:31
@ddbeck ddbeck changed the title Discouraged mutation events Add discouraged mutation events Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@captainbrosset @ddbeck