-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for misspellings in CI #1825
base: main
Are you sure you want to change the base?
Conversation
I'm impressed by how few typos our process has let through so far! My thought is that spelling checks are really helpful, but I'd prefer them as a comment in a PR, and not as a blocker that requires overrides in order to pass. That provides authors the info they need when they need it, but is a much lower long term cost. |
I see.
|
Hi @szepeviktor, thanks for opening this PR. I'm still giving some thought about how to fit in spell checks like this, with some other linting on the table. I'm not exactly sure if/when I'll be able to land this, but I do want to get your feature identifier fix into the release this week. I've opened #1918 and credited you with the |
@ddbeck Hello 👋🏻 I could rebase this PR every week and report typos to you.
|
@ddbeck new findings:
"glpyhs" |
new findings: "signficantly" |
This PR is explosive 💥
and includes file renaming