Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for misspellings in CI #1825

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Sep 23, 2024

This PR is explosive 💥

and includes file renaming

@github-actions github-actions bot added tools and infrastructure Project internal tooling, such as linters, GitHub Actions, or repo settings documentation Improvements or additions to documentation feature definition Creating or defining new features or groups of features. labels Sep 23, 2024
@szepeviktor szepeviktor marked this pull request as ready for review September 23, 2024 17:22
@jamesnw
Copy link
Collaborator

jamesnw commented Sep 24, 2024

I'm impressed by how few typos our process has let through so far!

My thought is that spelling checks are really helpful, but I'd prefer them as a comment in a PR, and not as a blocker that requires overrides in order to pass. That provides authors the info they need when they need it, but is a much lower long term cost.

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Sep 24, 2024

I see.
You may want to see #1149 too.

|| true added in the latest commit.

@ddbeck
Copy link
Collaborator

ddbeck commented Oct 7, 2024

Hi @szepeviktor, thanks for opening this PR. I'm still giving some thought about how to fit in spell checks like this, with some other linting on the table. I'm not exactly sure if/when I'll be able to land this, but I do want to get your feature identifier fix into the release this week. I've opened #1918 and credited you with the Co-authored-by: trailer.

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Oct 8, 2024

@ddbeck Hello 👋🏻

I could rebase this PR every week and report typos to you.
Recent findings include

"clonable" should be "cloneable".

@szepeviktor
Copy link
Contributor Author

@ddbeck new findings:

# 2024-10-15 — low → false — Chrome, Edge, and Safari do not implement font synthesis for missing superscript or subscript glpyhs.

"glpyhs"

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Nov 13, 2024

new findings: "signficantly"

@szepeviktor szepeviktor mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature definition Creating or defining new features or groups of features. tools and infrastructure Project internal tooling, such as linters, GitHub Actions, or repo settings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants