refactor: add tracing for make phase task #8026
Open
+55
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team
✅ Deploy Preview for rspack canceled.
|
hardfist
force-pushed
the
yj/add-tracing-for-make
branch
from
dd2730c
to
b61bce8
Compare
hardfist
force-pushed
the
yj/add-tracing-for-make
branch
from
b61bce8
to
918adbd
Compare
|
Adding tracing to the make phase task will generate very large trace files, a 10k modules project will generate more than 60k line logs. I think we should wait for the feature of filtering trace log by levels to be completed before merging this PR. |
agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add more tracing info about make phase so we can know how to optimize it
Checklist