Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support dependencies in resolve hook callback #7949

Merged
merged 11 commits into from
Oct 10, 2024

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Sep 23, 2024

Summary

Fix todo in PR to support moment-locales-webpack-plugin.

Another aspect is to prepare for supporting the Content Callback of ContextReplacementPlugin. In this callback, you can modify dependency.critical to ignore the errors that would occur during the original parsing of the ContextModule. For example: https://github.com/microsoft/vscode-dapr/blob/5b860c3e9ce120604067680aa67c844b8ac08704/webpack.config.ts#L95

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Sep 23, 2024
Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 6d3d133
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67078fd5a2fea70008c09997
😎 Deploy Preview https://deploy-preview-7949--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Sep 23, 2024
@SyMind SyMind marked this pull request as ready for review September 23, 2024 08:15
@SyMind SyMind force-pushed the feat-dependencies-in-resolve-hook branch from ea7f594 to 0b15c10 Compare September 23, 2024 08:21
@SyMind SyMind force-pushed the feat-dependencies-in-resolve-hook branch from 0b15c10 to c69a361 Compare September 23, 2024 08:26
@SyMind SyMind force-pushed the feat-dependencies-in-resolve-hook branch from f08b9da to 7d6519c Compare September 23, 2024 08:36
@SyMind SyMind force-pushed the feat-dependencies-in-resolve-hook branch from 771b014 to c1f8f8e Compare September 23, 2024 12:33
@SyMind SyMind force-pushed the feat-dependencies-in-resolve-hook branch from 65251ef to 8caa426 Compare October 9, 2024 09:44
@SyMind SyMind force-pushed the feat-dependencies-in-resolve-hook branch from 8caa426 to 183afd8 Compare October 9, 2024 10:05
@hardfist
Copy link
Contributor

what is the usecase for this

@SyMind
Copy link
Member Author

SyMind commented Oct 10, 2024

@hardfist Fix todo in PR to support moment-locales-webpack-plugin.

// TODO: Dependencies are not fully supported yet; this is a placeholder to prevent errors in moment-locales-webpack-plugin.

@SyMind
Copy link
Member Author

SyMind commented Oct 10, 2024

Another aspect is to prepare for supporting the Content Callback of ContextReplacementPlugin. In this callback, you can modify dependency.critical to ignore the errors that would occur during the original parsing of the ContextModule. For example: https://github.com/microsoft/vscode-dapr/blob/5b860c3e9ce120604067680aa67c844b8ac08704/webpack.config.ts#L95

h-a-n-a
h-a-n-a previously approved these changes Oct 10, 2024
@SyMind SyMind merged commit 27188f2 into main Oct 10, 2024
29 checks passed
@SyMind SyMind deleted the feat-dependencies-in-resolve-hook branch October 10, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants