fix

web-infra-dev · Nov 7, 2024 · d6b54d9 · d6b54d9
1 parent 34fa2fb
commit d6b54d9
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/crates/rspack_core/src/dependency/runtime_template.rs b/crates/rspack_core/src/dependency/runtime_template.rs
@@ -813,6 +813,16 @@ mod test_items_to_regexp {
       ),
       "[1234a]".to_string()
     );
+
+    assert_eq!(
+      items_to_regexp(
+        vec!["foo_js", "_js"]
+          .into_iter()
+          .map(String::from)
+          .collect::<Vec<_>>(),
+      ),
+      "(|foo)_js".to_string()
+    );
   }
 
   #[test]

diff --git a/crates/rspack_core/src/utils/compile_boolean_matcher.rs b/crates/rspack_core/src/utils/compile_boolean_matcher.rs
@@ -369,11 +369,11 @@ fn get_common_suffix<'a, I: Iterator<Item = &'a str>>(mut items: I) -> &'a str {
         let item_byte = item[p - 1];
         if suffix_byte == item_byte {
           p -= 1;
-        } else {
-          suffix = &suffix[s + 1..];
-          break;
+          continue;
         }
       }
+      suffix = &suffix[s + 1..];
+      break;
     }
   }