Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(client): remove client-side terser minification #592

Merged
merged 1 commit into from
Nov 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@
"react-markdown": "^9.0.1",
"react-router-dom": "6.4.3",
"socket.io-client": "4.6.1",
"terser": "^5.36.0",
"typescript": "^5.2.2",
"url-parse": "1.5.10"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/Layout/header.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export const Header: React.FC = () => {
src={
'https://assets.rspack.dev/rsdoctor/rsdoctor-logo-960x960.png'
}
className="web-doctor-logo"
className="rsdoctor-logo"
alt="logo"
/>
<Typography.Text
Expand Down
15 changes: 1 addition & 14 deletions packages/components/src/components/Loader/executions.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { ClockCircleOutlined } from '@ant-design/icons';
import Editor from '@monaco-editor/react';
import { Constants, SDK } from '@rsdoctor/types';
import { SDK } from '@rsdoctor/types';
import {
Badge,
Button,
Expand All @@ -18,7 +18,6 @@ import {
import type { EllipsisConfig } from 'antd/lib/typography/Base';
import type { TextProps } from 'antd/lib/typography/Text';
import dayjs from 'dayjs';
import { endsWith } from 'lodash-es';
import { PropsWithChildren, useCallback, useState } from 'react';
import { Size } from '../../constants';
import {
Expand All @@ -31,7 +30,6 @@ import { Card } from '../Card';
import { DiffViewer } from '../CodeViewer';
import { CodeOpener } from '../Opener';
import { Title } from '../Title';
import { JSIsEqualTag } from '../worker/jsequal/client';

interface LoaderExecutionsProps {
cwd: string;
Expand Down Expand Up @@ -73,17 +71,13 @@ const LoaderInfoItem = ({

const LoaderPropsItem = ({
loader,
hasError,
resource,
before,
cwd,
}: {
loader: SDK.LoaderTransformData & {
costs: number;
};
hasError: number;
resource: SDK.ResourceData;
before: string;
cwd: string;
}): JSX.Element => {
return (
Expand All @@ -97,11 +91,6 @@ const LoaderPropsItem = ({
}
>
{loader.isPitch ? <Typography.Text code>pitch</Typography.Text> : null}
{loader.isPitch ||
hasError ||
!endsWith(resource.path, Constants.JSExtension) ? null : (
<JSIsEqualTag input={before} output={loader.result || ''} />
)}
<Space
direction="vertical"
style={{ padding: Size.BasePadding, wordBreak: 'break-all' }}
Expand Down Expand Up @@ -243,9 +232,7 @@ export const LoaderExecutions = ({
children: (
<LoaderPropsItem
loader={loader}
hasError={hasError}
resource={resource}
before={before}
cwd={cwd}
/>
),
Expand Down
43 changes: 0 additions & 43 deletions packages/components/src/components/worker/jsequal/client.tsx

This file was deleted.

29 changes: 0 additions & 29 deletions packages/components/src/components/worker/jsequal/worker.js

This file was deleted.

3 changes: 0 additions & 3 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.