chore(deps): update dependency @rspack/core to v1 [security] #537
+17
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.7.5
->1.0.0
GitHub Vulnerability Alerts
GHSA-84jw-g43v-8gjm
Hi, Rspack|Webpack developer team!
Summary
We discovered a DOM Clobbering vulnerability in Webpack’s AutoPublicPathRuntimeModule. The DOM Clobbering gadget in the module can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., an img tag with an unsanitized name attribute) are present.
We found the real-world exploitation of this gadget in the Canvas LMS which allows XSS attack happens through an javascript code compiled by Webpack (the vulnerable part is from Webpack). We believe this is a severe issue. If Webpack’s code is not resilient to DOM Clobbering attacks, it could lead to significant security vulnerabilities in any web application using Webpack-compiled code.
Details
Backgrounds
DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:
[1] scnps.co/papers/sp23_domclob.pdf
[2] research.securitum.com/xss-in-amp4email-dom-clobbering
Gadgets found in Webpack | Rspack
We identified a DOM Clobbering vulnerability in Webpack’s AutoPublicPathRuntimeModule. When the output.publicPath field in the configuration is not set or is set to auto, the following code is generated in the bundle to dynamically resolve and load additional JavaScript files:
However, this code is vulnerable to a DOM Clobbering attack. The lookup on the line with document.currentScript can be shadowed by an attacker, causing it to return an attacker-controlled HTML element instead of the current script element as intended. In such a scenario, the src attribute of the attacker-controlled element will be used as the scriptUrl and assigned to webpack_require.p. If additional scripts are loaded from the server, webpack_require.p will be used as the base URL, pointing to the attacker's domain. This could lead to arbitrary script loading from the attacker's server, resulting in severe security risks.
PoC
Please note that we have identified a real-world exploitation of this vulnerability in the Canvas LMS. Once the issue has been patched, I am willing to share more details on the exploitation. For now, I’m providing a demo to illustrate the concept.
Consider a website developer with the following two scripts, entry.js and import1.js, that are compiled using Webpack:
When the developer builds these scripts into a bundle and adds it to a webpage, the page could load the import1.js file from the attacker's domain, attacker.controlled.server. The attacker only needs to insert an img tag with the name attribute set to currentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.
Impact
This vulnerability can lead to cross-site scripting (XSS) on websites that include Webpack-generated files and allow users to inject certain scriptless HTML tags with improperly sanitized name or id attributes.
Patch
A possible patch to this vulnerability could refer to the Google Closure project which makes itself resistant to DOM Clobbering attack: google/closure-library@b312823/closure/goog/base.js#L174
Please note that if we do not receive a response from the development team within three months, we will disclose this vulnerability to the CVE agent.
Release Notes
web-infra-dev/rspack (@rspack/core)
v1.0.0
Compare Source
See Announcing Rspack 1.0 for more details 🎉
What's Changed
Breaking Changes 🛠
RspackError
by @h-a-n-a in https://github.com/web-infra-dev/rspack/pull/6900SwcJsMinimizerRspackPluginOptions
by @h-a-n-a in https://github.com/web-infra-dev/rspack/pull/6950DefinePlugin
by @h-a-n-a in https://github.com/web-infra-dev/rspack/pull/7045builtins.provide
by @h-a-n-a in https://github.com/web-infra-dev/rspack/pull/7086webpack-dev-server
to v5 and no longer lock the versions by @SoonIter in https://github.com/web-infra-dev/rspack/pull/7130optimization.emitOnErrors
by @LingyuCoder in https://github.com/web-infra-dev/rspack/pull/7595Performance Improvements ⚡
compilation.entrypoints
by @chenjiahan in https://github.com/web-infra-dev/rspack/pull/7059get_scheme
allocation by @h-a-n-a in https://github.com/web-infra-dev/rspack/pull/7109TraceableError
by @h-a-n-a in https://github.com/web-infra-dev/rspack/pull/7192Stats
by @h-a-n-a in https://github.com/web-infra-dev/rspack/pull/7124ModuleRule
matching by @h-a-n-a in https://github.com/web-infra-dev/rspack/pull/7249JavascriptParser::new
by @h-a-n-a in https://github.com/web-infra-dev/rspack/pull/7286Ukey
s by @ahabhgk in https://github.com/web-infra-dev/rspack/pull/7287resource_path
is not a valid UTF-8 sequence by @h-a-n-a in https://github.com/web-infra-dev/rspack/pull/7441Exciting New Features 🎉
to
option by @9aoy in https://github.com/web-infra-dev/rspack/pull/6866factoryMeta
toJsModule
and optimizeInnerGraphPlugin
for variable decl with iife by @CPunisher in https://github.com/web-infra-dev/rspack/pull/6888DefinePlugin
by @h-a-n-a in https://github.com/web-infra-dev/rspack/pull/7108StatsError.moduleTrace
by @LingyuCoder in https://github.com/web-infra-dev/rspack/pull/7123test
,include
andexclude
options forSwcCssMinimizerRspackPlugin
by @simonxabris in https://github.com/web-infra-dev/rspack/pull/7111output.assetModuleFilename
by @xc2 in https://github.com/web-infra-dev/rspack/pull/7191__webpack_get_script_filename__
by @LingyuCoder in https://github.com/web-infra-dev/rspack/pull/7203publicPath
options with webpack by @xc2 in https://github.com/web-infra-dev/rspack/pull/7216compilation.chunkGroups
andcompilation.namedChunkGroups
by @LingyuCoder in https://github.com/web-infra-dev/rspack/pull/7254test
,include
andexclude
options forLightningCssMinimizerRspackPlugin
by @simonxabris in https://github.com/web-infra-dev/rspack/pull/7290parser.importMeta
andoutput.importMetaName
by @xc2 in https://github.com/web-infra-dev/rspack/pull/7231compilation.chunkGroup[].isInitial()
by @LingyuCoder in https://github.com/web-infra-dev/rspack/pull/7406compiler.rspack
by @LingyuCoder in https://github.com/web-infra-dev/rspack/pull/7434moduleReason.resolvedModule
by @LingyuCoder in https://github.com/web-infra-dev/rspack/pull/7467node-module
shim by @fi3ework in https://github.com/web-infra-dev/rspack/pull/7465isOverSizeLimit
in stats by @LingyuCoder in https://github.com/web-infra-dev/rspack/pull/7483stats.chunkGroup[].childAssets
by @LingyuCoder in https://github.com/web-infra-dev/rspack/pull/7517"loose-unrecognized-keys"
for config validation by @h-a-n-a in https://github.com/web-infra-dev/rspack/pull/7705Bug Fixes 🐞
ModuleFactory
is not correct by @h-a-n-a in https://github.com/web-infra-dev/rspack/pull/6946glob_match
by @shulaoda in https://github.com/web-infra-dev/rspack/pull/6668FileSystem
trait by @hardfist in https://github.com/web-infra-dev/rspack/pull/7275truthy || any
andfalsy && any
by @xc2 in https://github.com/web-infra-dev/rspack/pull/7277await
to async module export by @CPunisher in [https://github.com/fix: addawait
to async module export rspack#7308](https://redirect.github.com/web-Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.