Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(client): remove client-side terser minification #592

Merged
merged 1 commit into from
Nov 15, 2024
Merged

perf(client): remove client-side terser minification #592

merged 1 commit into from
Nov 15, 2024

Conversation

chenjiahan
Copy link
Member

Summary

Remove the JSIsEqualTag component, because:

  • It's unnecessary and has poor performance to run terser in the client side.
  • The tag is unless in most cases.
  • This change can reduce the bundle size.

Bundle size

  • before:
Screenshot 2024-11-15 at 12 55 19
  • after:
Screenshot 2024-11-15 at 13 12 20

@netlify Netlify
Copy link

netlify bot commented Nov 15, 2024 •
edited
Loading

✅ Deploy Preview for rsdoctor ready!

Name Link
🔨 Latest commit ee1ae21
🔍 Latest deploy log https://app.netlify.com/sites/rsdoctor/deploys/6736d865a63a530008faf2a8
😎 Deploy Preview https://deploy-preview-592--rsdoctor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@easy1090 easy1090 merged commit 5b9eee8 into main Nov 15, 2024
8 checks passed
@easy1090 easy1090 deleted the remove_terser_1115 branch November 15, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easy1090 easy1090 easy1090 approved these changes

Assignees
No one assigned
Labels
change: perf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenjiahan @easy1090