Bugs (#197)

web-auth · Nov 21, 2021 · a246a59 · a246a59
1 parent b03ee86
commit a246a59
Show file tree

Hide file tree

Showing 299 changed files with 709 additions and 489 deletions.
diff --git a/.github/workflows/bc-break-test.yml b/.github/workflows/bc-break-test.yml
diff --git a/.github/workflows/functional-tests.yml b/.github/workflows/functional-tests.yml
@@ -8,7 +8,7 @@ jobs:
     strategy:
       matrix:
         operating-system: [ubuntu-latest]
-        php-versions: ['7.2', '7.3', '7.4', '8.0']
+        php-versions: ['7.2', '7.3', '7.4', '8.0', '8.1']
     name: PHP ${{ matrix.php-versions }} Test on ${{ matrix.operating-system }}
 
     steps:

diff --git a/.github/workflows/mutation-tests.yml b/.github/workflows/mutation-tests.yml
@@ -32,4 +32,4 @@ jobs:
         run: git fetch --depth=1 origin $GITHUB_BASE_REF
 
       - name: Infection
-        run: ./vendor/bin/infection --logger-github --git-diff-filter=AM -s --threads=$(nproc) --min-msi=0 --min-covered-msi=0
+        run: ./vendor/bin/infection --logger-github -s --threads=$(nproc) --min-msi=30 --min-covered-msi=50
diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml
@@ -8,7 +8,7 @@ jobs:
     strategy:
       matrix:
         operating-system: [ windows-latest, ubuntu-latest, macos-latest ]
-        php-versions: [ '7.2', '7.3', '7.4', '8.0' ]
+        php-versions: ['7.2', '7.3', '7.4', '8.0' , '8.1']
     name: PHP ${{ matrix.php-versions }} Test on ${{ matrix.operating-system }}
 
     steps:

diff --git a/.gitignore b/.gitignore
@@ -2,3 +2,5 @@
 report.md
 composer.lock
 vendor
+*.cache
+*.log
diff --git a/.php_cs.dist → .php-cs-fixer.dist.php b/.php_cs.dist → .php-cs-fixer.dist.php
@@ -2,7 +2,7 @@
 
 $header = 'The MIT License (MIT)
 
-Copyright (c) 2014-2020 Spomky-Labs
+Copyright (c) 2014-2021 Spomky-Labs
 
 This software may be modified and distributed under the terms
 of the MIT license.  See the LICENSE file for details.';
@@ -12,7 +12,7 @@
     ->in(__DIR__.'/src')
 ;
 
-return PhpCsFixer\Config::create()
+return (new PhpCsFixer\Config)
     ->setRules([
         '@PSR1' => true,
         '@PSR2' => true,
@@ -50,7 +50,6 @@
             'comment_type' => 'all_multiline',
         ],
         'php_unit_test_annotation' => [
-            'case' => 'snake',
             'style' => 'annotation',
         ],
         'php_unit_test_case_static_method_calls' => true,

diff --git a/README.md b/README.md
@@ -4,8 +4,6 @@ Webauthn Framework
 ![Build Status](https://github.com/web-auth/webauthn-framework/workflows/Coding%20Standards/badge.svg)
 ![Build Status](https://github.com/web-auth/webauthn-framework/workflows/Static%20Analyze/badge.svg)
 
-![Build Status](https://github.com/web-auth/webauthn-framework/workflows/Backwards%20compatibility%20verification/badge.svg)
-
 ![Build Status](https://github.com/web-auth/webauthn-framework/workflows/Unit%20Tests/badge.svg)
 ![Build Status](https://github.com/web-auth/webauthn-framework/workflows/Functional%20Tests/badge.svg)
 ![Build Status](https://github.com/web-auth/webauthn-framework/workflows/Lowest%20versions%20tests/badge.svg)

diff --git a/composer.json b/composer.json
@@ -56,7 +56,7 @@
         "ramsey/uuid": "^3.8|^4.0",
         "spomky-labs/base64url": "^2.0",
         "spomky-labs/cbor-bundle": "^2.0",
-        "spomky-labs/cbor-php": "^1.1|^2.0",
+        "spomky-labs/cbor-php": "^1.0|^2.0",
         "symfony/config": "^4.4|^5.0",
         "symfony/dependency-injection": "^4.4|^5.0",
         "symfony/framework-bundle": "^4.4|^5.0",
@@ -88,17 +88,17 @@
         "doctrine/dbal": "^2.9|^3.0",
         "doctrine/doctrine-bundle": "^2.0",
         "doctrine/orm": "^2.6",
-        "friendsofphp/php-cs-fixer": "^2.16",
-        "infection/infection": "^0.15||^0.16||^0.17||^0.18||^0.19||^0.20||^0.21",
+        "friendsofphp/php-cs-fixer": "^3.0",
+        "infection/infection": ">=0.15|<0.24",
         "monolog/monolog": "^2.0",
         "nyholm/psr7": "^1.1",
         "php-http/curl-client": "^2.0",
         "php-http/mock-client": "^1.3",
-        "phpstan/phpstan": "^0.12",
-        "phpstan/phpstan-beberlei-assert": "^0.12",
-        "phpstan/phpstan-deprecation-rules": "^0.12",
-        "phpstan/phpstan-phpunit": "^0.12",
-        "phpstan/phpstan-strict-rules": "^0.12",
+        "phpstan/phpstan": "^1.0",
+        "phpstan/phpstan-beberlei-assert": "^1.0",
+        "phpstan/phpstan-deprecation-rules": "^1.0",
+        "phpstan/phpstan-phpunit": "^1.0",
+        "phpstan/phpstan-strict-rules": "^1.0",
         "phpunit/phpunit": "^8.0||^9.0",
         "symfony/browser-kit": "^4.4|^5.0",
         "symfony/http-client": "^4.4|^5.0",

diff --git a/phpstan.neon b/phpstan.neon
@@ -10,31 +10,36 @@ parameters:
         - '#Call to deprecated function Symfony\\Component\\DependencyInjection\\Loader\\Configurator\\ref\(\)(.*)#'
         - '#Parameter (.*) of class FG\\ASN1\\Universal\\Integer constructor expects int, string given\.#'
         - '#Instanceof between Symfony\\Component\\HttpFoundation\\Response and Symfony\\Component\\HttpFoundation\\Response will always evaluate to true\.#'
-        - '#Parameter (.*) of class Jose\\Component\\Core\\AlgorithmManager constructor expects array\<Jose\\Component\\Core\\Algorithm\>\, array\<int\, object\> given\.#'
+        - message: '#Call to deprecated method loadUserByUsername\(\) of class .*#'
+          count: 1
+          path: src/symfony/src/Security/Authentication/Provider/WebauthnProvider.php
+        - message: '#Class Webauthn\\Bundle\\Security\\Authentication\\Provider\\WebauthnProvider implements deprecated interface .*#'
+          count: 1
+          path: src/symfony/src/Security/Authentication/Provider/WebauthnProvider.php
         - message: '#Function .* is unsafe to use\. .* Please add .* at the beginning of the file to use the variant provided by the .* library\.#'
           count: 1
-          path: 'src/cose/src/Algorithm/ManagerFactory.php'
+          path: src/cose/src/Algorithm/ManagerFactory.php
         - message: '#Function .* is unsafe to use\. .* Please add .* at the beginning of the file to use the variant provided by the .* library\.#'
           count: 1
-          path: 'src/cose/src/Algorithm/Signature/ECDSA/ECDSA.php'
+          path: src/cose/src/Algorithm/Signature/ECDSA/ECDSA.php
         - message: '#Function .* is unsafe to use\. .* Please add .* at the beginning of the file to use the variant provided by the .* library\.#'
           count: 2
-          path: 'src/cose/src/Algorithm/Signature/ECDSA/ECSignature.php'
+          path: src/cose/src/Algorithm/Signature/ECDSA/ECSignature.php
         - message: '#Function .* is unsafe to use\. .* Please add .* at the beginning of the file to use the variant provided by the .* library\.#'
           count: 1
-          path: 'src/cose/src/Algorithm/Signature/RSA/PSSRSA.php'
+          path: src/cose/src/Algorithm/Signature/RSA/PSSRSA.php
         - message: '#Function .* is unsafe to use\. .* Please add .* at the beginning of the file to use the variant provided by the .* library\.#'
           count: 1
-          path: 'src/cose/src/Algorithm/Signature/RSA/RSA.php'
+          path: src/cose/src/Algorithm/Signature/RSA/RSA.php
         - message: '#Function .* is unsafe to use\. .* Please add .* at the beginning of the file to use the variant provided by the .* library\.#'
           count: 2
-          path: 'src/cose/src/Key/Ec2Key.php'
+          path: src/cose/src/Key/Ec2Key.php
         - message: '#Function .* is unsafe to use\. .* Please add .* at the beginning of the file to use the variant provided by the .* library\.#'
           count: 1
-          path: 'src/cose/src/Key/Key.php'
+          path: src/cose/src/Key/Key.php
         - message: '#Function .* is unsafe to use\. .* Please add .* at the beginning of the file to use the variant provided by the .* library\.#'
           count: 3
-          path: 'src/cose/src/Key/RsaKey.php'
+          path: src/cose/src/Key/RsaKey.php
     checkMissingIterableValueType: false
     checkGenericClassInNonGenericObjectType: false
     treatPhpDocTypesAsCertain: false

diff --git a/src/conformance-toolset/src/Controller/AssertionRequestController.php b/src/conformance-toolset/src/Controller/AssertionRequestController.php
@@ -5,7 +5,7 @@
 /*
  * The MIT License (MIT)
  *
- * Copyright (c) 2014-2020 Spomky-Labs
+ * Copyright (c) 2014-2021 Spomky-Labs
  *
  * This software may be modified and distributed under the terms
  * of the MIT license.  See the LICENSE file for details.

diff --git a/src/conformance-toolset/src/Controller/AssertionResponseController.php b/src/conformance-toolset/src/Controller/AssertionResponseController.php
@@ -5,7 +5,7 @@
 /*
  * The MIT License (MIT)
  *
- * Copyright (c) 2014-2020 Spomky-Labs
+ * Copyright (c) 2014-2021 Spomky-Labs
  *
  * This software may be modified and distributed under the terms
  * of the MIT license.  See the LICENSE file for details.

diff --git a/src/conformance-toolset/src/Controller/AssertionResponseControllerFactory.php b/src/conformance-toolset/src/Controller/AssertionResponseControllerFactory.php
@@ -5,7 +5,7 @@
 /*
  * The MIT License (MIT)
  *
- * Copyright (c) 2014-2020 Spomky-Labs
+ * Copyright (c) 2014-2021 Spomky-Labs
  *
  * This software may be modified and distributed under the terms
  * of the MIT license.  See the LICENSE file for details.

diff --git a/src/conformance-toolset/src/Controller/AttestationRequestController.php b/src/conformance-toolset/src/Controller/AttestationRequestController.php
@@ -5,7 +5,7 @@
 /*
  * The MIT License (MIT)
  *
- * Copyright (c) 2014-2020 Spomky-Labs
+ * Copyright (c) 2014-2021 Spomky-Labs
  *
  * This software may be modified and distributed under the terms
  * of the MIT license.  See the LICENSE file for details.

diff --git a/src/conformance-toolset/src/Controller/AttestationResponseController.php b/src/conformance-toolset/src/Controller/AttestationResponseController.php
@@ -5,7 +5,7 @@
 /*
  * The MIT License (MIT)
  *
- * Copyright (c) 2014-2020 Spomky-Labs
+ * Copyright (c) 2014-2021 Spomky-Labs
  *
  * This software may be modified and distributed under the terms
  * of the MIT license.  See the LICENSE file for details.

diff --git a/src/conformance-toolset/src/Controller/AttestationResponseControllerFactory.php b/src/conformance-toolset/src/Controller/AttestationResponseControllerFactory.php
@@ -5,7 +5,7 @@
 /*
  * The MIT License (MIT)
  *
- * Copyright (c) 2014-2020 Spomky-Labs
+ * Copyright (c) 2014-2021 Spomky-Labs
  *
  * This software may be modified and distributed under the terms
  * of the MIT license.  See the LICENSE file for details.

diff --git a/src/conformance-toolset/src/Dto/ServerPublicKeyCredentialCreationOptionsRequest.php b/src/conformance-toolset/src/Dto/ServerPublicKeyCredentialCreationOptionsRequest.php
@@ -5,7 +5,7 @@
 /*
  * The MIT License (MIT)
  *
- * Copyright (c) 2014-2020 Spomky-Labs
+ * Copyright (c) 2014-2021 Spomky-Labs
  *
  * This software may be modified and distributed under the terms
  * of the MIT license.  See the LICENSE file for details.

diff --git a/src/conformance-toolset/src/Dto/ServerPublicKeyCredentialRequestOptionsRequest.php b/src/conformance-toolset/src/Dto/ServerPublicKeyCredentialRequestOptionsRequest.php
@@ -5,7 +5,7 @@
 /*
  * The MIT License (MIT)
  *
- * Copyright (c) 2014-2020 Spomky-Labs
+ * Copyright (c) 2014-2021 Spomky-Labs
  *
  * This software may be modified and distributed under the terms
  * of the MIT license.  See the LICENSE file for details.

diff --git a/src/cose/src/Algorithm/Algorithm.php b/src/cose/src/Algorithm/Algorithm.php
@@ -5,7 +5,7 @@
 /*
  * The MIT License (MIT)
  *
- * Copyright (c) 2014-2020 Spomky-Labs
+ * Copyright (c) 2014-2021 Spomky-Labs
  *
  * This software may be modified and distributed under the terms
  * of the MIT license.  See the LICENSE file for details.

diff --git a/src/cose/src/Algorithm/Mac/HS256.php b/src/cose/src/Algorithm/Mac/HS256.php
@@ -5,7 +5,7 @@
 /*
  * The MIT License (MIT)
  *
- * Copyright (c) 2014-2020 Spomky-Labs
+ * Copyright (c) 2014-2021 Spomky-Labs
  *
  * This software may be modified and distributed under the terms
  * of the MIT license.  See the LICENSE file for details.

diff --git a/src/cose/src/Algorithm/Mac/HS256Truncated64.php b/src/cose/src/Algorithm/Mac/HS256Truncated64.php
@@ -5,7 +5,7 @@
 /*
  * The MIT License (MIT)
  *
- * Copyright (c) 2014-2020 Spomky-Labs
+ * Copyright (c) 2014-2021 Spomky-Labs
  *
  * This software may be modified and distributed under the terms
  * of the MIT license.  See the LICENSE file for details.

diff --git a/src/cose/src/Algorithm/Mac/HS384.php b/src/cose/src/Algorithm/Mac/HS384.php
@@ -5,7 +5,7 @@
 /*
  * The MIT License (MIT)
  *
- * Copyright (c) 2014-2020 Spomky-Labs
+ * Copyright (c) 2014-2021 Spomky-Labs
  *
  * This software may be modified and distributed under the terms
  * of the MIT license.  See the LICENSE file for details.

diff --git a/src/cose/src/Algorithm/Mac/HS512.php b/src/cose/src/Algorithm/Mac/HS512.php
@@ -5,7 +5,7 @@
 /*
  * The MIT License (MIT)
  *
- * Copyright (c) 2014-2020 Spomky-Labs
+ * Copyright (c) 2014-2021 Spomky-Labs
  *
  * This software may be modified and distributed under the terms
  * of the MIT license.  See the LICENSE file for details.

diff --git a/src/cose/src/Algorithm/Mac/Hmac.php b/src/cose/src/Algorithm/Mac/Hmac.php
@@ -5,7 +5,7 @@
 /*
  * The MIT License (MIT)
  *
- * Copyright (c) 2014-2020 Spomky-Labs
+ * Copyright (c) 2014-2021 Spomky-Labs
  *
  * This software may be modified and distributed under the terms
  * of the MIT license.  See the LICENSE file for details.

diff --git a/src/cose/src/Algorithm/Mac/Mac.php b/src/cose/src/Algorithm/Mac/Mac.php
@@ -5,7 +5,7 @@
 /*
  * The MIT License (MIT)
  *
- * Copyright (c) 2014-2020 Spomky-Labs
+ * Copyright (c) 2014-2021 Spomky-Labs
  *
  * This software may be modified and distributed under the terms
  * of the MIT license.  See the LICENSE file for details.

diff --git a/src/cose/src/Algorithm/Manager.php b/src/cose/src/Algorithm/Manager.php
@@ -5,7 +5,7 @@
 /*
  * The MIT License (MIT)
  *
- * Copyright (c) 2014-2020 Spomky-Labs
+ * Copyright (c) 2014-2021 Spomky-Labs
  *
  * This software may be modified and distributed under the terms
  * of the MIT license.  See the LICENSE file for details.

diff --git a/src/cose/src/Algorithm/ManagerFactory.php b/src/cose/src/Algorithm/ManagerFactory.php
@@ -5,7 +5,7 @@
 /*
  * The MIT License (MIT)
  *
- * Copyright (c) 2014-2020 Spomky-Labs
+ * Copyright (c) 2014-2021 Spomky-Labs
  *
  * This software may be modified and distributed under the terms
  * of the MIT license.  See the LICENSE file for details.

diff --git a/src/cose/src/Algorithm/Signature/ECDSA/ECDSA.php b/src/cose/src/Algorithm/Signature/ECDSA/ECDSA.php
@@ -5,7 +5,7 @@
 /*
  * The MIT License (MIT)
  *
- * Copyright (c) 2014-2020 Spomky-Labs
+ * Copyright (c) 2014-2021 Spomky-Labs
  *
  * This software may be modified and distributed under the terms
  * of the MIT license.  See the LICENSE file for details.

diff --git a/src/cose/src/Algorithm/Signature/ECDSA/ECSignature.php b/src/cose/src/Algorithm/Signature/ECDSA/ECSignature.php
@@ -5,7 +5,7 @@
 /*
  * The MIT License (MIT)
  *
- * Copyright (c) 2014-2020 Spomky-Labs
+ * Copyright (c) 2014-2021 Spomky-Labs
  *
  * This software may be modified and distributed under the terms
  * of the MIT license.  See the LICENSE file for details.

diff --git a/src/cose/src/Algorithm/Signature/ECDSA/ES256.php b/src/cose/src/Algorithm/Signature/ECDSA/ES256.php
@@ -5,7 +5,7 @@
 /*
  * The MIT License (MIT)
  *
- * Copyright (c) 2014-2020 Spomky-Labs
+ * Copyright (c) 2014-2021 Spomky-Labs
  *
  * This software may be modified and distributed under the terms
  * of the MIT license.  See the LICENSE file for details.

diff --git a/src/cose/src/Algorithm/Signature/ECDSA/ES256K.php b/src/cose/src/Algorithm/Signature/ECDSA/ES256K.php
@@ -5,7 +5,7 @@
 /*
  * The MIT License (MIT)
  *
- * Copyright (c) 2014-2020 Spomky-Labs
+ * Copyright (c) 2014-2021 Spomky-Labs
  *
  * This software may be modified and distributed under the terms
  * of the MIT license.  See the LICENSE file for details.

diff --git a/src/cose/src/Algorithm/Signature/ECDSA/ES384.php b/src/cose/src/Algorithm/Signature/ECDSA/ES384.php
@@ -5,7 +5,7 @@
 /*
  * The MIT License (MIT)
  *
- * Copyright (c) 2014-2020 Spomky-Labs
+ * Copyright (c) 2014-2021 Spomky-Labs
  *
  * This software may be modified and distributed under the terms
  * of the MIT license.  See the LICENSE file for details.

diff --git a/src/cose/src/Algorithm/Signature/ECDSA/ES512.php b/src/cose/src/Algorithm/Signature/ECDSA/ES512.php
@@ -5,7 +5,7 @@
 /*
  * The MIT License (MIT)
  *
- * Copyright (c) 2014-2020 Spomky-Labs
+ * Copyright (c) 2014-2021 Spomky-Labs
  *
  * This software may be modified and distributed under the terms
  * of the MIT license.  See the LICENSE file for details.

diff --git a/src/cose/src/Algorithm/Signature/EdDSA/ED256.php b/src/cose/src/Algorithm/Signature/EdDSA/ED256.php
@@ -5,7 +5,7 @@
 /*
  * The MIT License (MIT)
  *
- * Copyright (c) 2014-2020 Spomky-Labs
+ * Copyright (c) 2014-2021 Spomky-Labs
  *
  * This software may be modified and distributed under the terms
  * of the MIT license.  See the LICENSE file for details.

diff --git a/src/cose/src/Algorithm/Signature/EdDSA/ED512.php b/src/cose/src/Algorithm/Signature/EdDSA/ED512.php
@@ -5,7 +5,7 @@
 /*
  * The MIT License (MIT)
  *
- * Copyright (c) 2014-2020 Spomky-Labs
+ * Copyright (c) 2014-2021 Spomky-Labs
  *
  * This software may be modified and distributed under the terms
  * of the MIT license.  See the LICENSE file for details.
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,3 +2,5 @@ @@
     report.md
     composer.lock
     vendor
+    *.cache
+    *.log