apache2_common_site_template/default_site_template:

The variable should better contain the module name. I at first tought about default_site_template_apache2 since this variable is doing something quite different than the other ones. Now I renamed it to apache2_common_site_template. Feel free to suggest something else.
weareinteractive · Jan 29, 2020 · b116c03 · b116c03
1 parent f846a3d
commit b116c03
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -115,7 +115,7 @@ apache2_certs_path: /etc/ssl/certs
 apache2_keys_path: /etc/ssl/private
 
 # template to render sites from if no template is configured in apache2_sites...template
-default_site_template: etc/apache2/sites-available/site.j2
+apache2_common_site_template: etc/apache2/sites-available/site.j2
 
 ```
 

diff --git a/defaults/main.yml b/defaults/main.yml
@@ -63,4 +63,4 @@ apache2_certs_path: /etc/ssl/certs
 apache2_keys_path: /etc/ssl/private
 
 # template to render sites from if no template is configured in apache2_sites...template
-default_site_template: etc/apache2/sites-available/site.j2
+apache2_common_site_template: etc/apache2/sites-available/site.j2
diff --git a/tasks/manage_sites.yml b/tasks/manage_sites.yml
@@ -9,7 +9,7 @@
 
 - name: Creating sites
   template:
-    src: "{{ item.template|default(default_site_template) }}"
+    src: "{{ item.template|default(apache2_common_site_template) }}"
     dest: "/etc/apache2/sites-available/{{ item.id }}.conf"
     owner: root
     group: root