Frontend starter #19
Merged
Frontend starter #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts to ensure more symmetry between splash image and caption
This was
linked to
issues
Sep 18, 2021
jhern603
reviewed
Sep 19, 2021
jhern603
reviewed
Sep 19, 2021
There was a problem hiding this comment.
Alt text for Facebook social media button shouldn't be "Community on Discord"
Alt text for Instagram social media button shouldn't be "Community on Discord"
Alt text for LinkedIn social media button shouldn't be "Community on Discord"
Alt text for Twitter social media button shouldn't be "Community on Discord"
dvd-lara
reviewed
Sep 19, 2021
src/components/SocialMediaButtons/DiscordButton/DiscordButton.tsx
Outdated
Show resolved
Hide resolved
dvd-lara
reviewed
Sep 19, 2021
dvd-lara
reviewed
Sep 19, 2021
|
|
||
| interface Props { | ||
| downwards: boolean; | ||
| } |
There was a problem hiding this comment.
This file can be shortened by returning the SVG and replacing the d inside of path with the appropriate one depending on if you want a downwards wave or not. Same with style.
…kgroundWave to repeat less code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Starter code for our front end. Includes the Page Hero (or banner) and the Footer sections.
Test plan
E2E testing was performed to ensure that the components were rendered as expected and the page resulted visually pleasing and accessible across multiple form factors.
Closing Issues
#3 and #4.
Pending
For extremely narrow form factors (ex: Folding Phones) the background with the SVG curves might break.