-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flex components #612
Open
jasonfine
wants to merge
23
commits into
master
Choose a base branch
from
flex-components
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Flex components #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…future UI updates not require updating generated views in mounting apps
@jamesmk this can be seen here https://fae-dummy.afinesite.com/admin/content_blocks/components Keep in mind that my goal here was getting the core data modeling and new generator into the core so we have a base to iterate on UX improvements. So on the view layer this will look/function identically to what we're used to now in our apps that use components. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the typical pattern of the core of the feature being in the Fae core and the installer adds some files to the mounting app. Originally the installer was adding the core flex component route and views into the mounting app. I removed this behavior and tucked all of that into the core as well so future UI improvements won't require updating generated files in the mounting apps.
The Dummy app is now GraphQL enabled and the settingslogic gem was added so it can be used similarly to how all of our builds are set up these days.
The documentation explains the rest https://github.com/wearefine/fae/blob/040c1f1589391198ac0652c5176b94d261a366b2/docs/features/flex_components.md