queryservice: add allowlist configuration #165
Conversation
| @@ -30,6 +30,10 @@ spec: | |||
| volumeMounts: | |||
There was a problem hiding this comment.
is the volume mount of allowlist-static missing here?
There was a problem hiding this comment.
The query service doesn't directly use allowlist-static.txt. In the past, we manually created allowlist.txt by combining the endpoints in allowlist-static.txt with our Wikibase Cloud endpoints. It's still in the ConfigMap because this process will now be automated by the Platform API.
There was a problem hiding this comment.
To be clear, if I understand correctly:
- the static list is set here
- this static list is added to the dynamic list generated by the api and stored in the main allowlist
charts/argocd-config/Chart.yaml
Outdated
| @@ -2,7 +2,7 @@ apiVersion: v2 | |||
| name: argocd-config | |||
| description: Chart to deploy ArgoCD configuration (including the argocd-apps chart) | |||
| type: application | |||
| version: 1.0.5 | |||
| version: 1.1.0 | |||
There was a problem hiding this comment.
I guess this was inadvertently bumped?
|
Approve but assuming you'll fix this argcd-config oversight (can't even merge without doing so :) ) |
| name: {{ include "wdqs.fullname" . }}-allowlist | ||
| data: | ||
| allowlist-static.txt: | ||
| {{- .Values.allowListStatic | toYaml | indent 2 }} |
There was a problem hiding this comment.
Wouldn't have been surprised if you'd either hardcoded the list here but I think having the list in the deploy repo is way cleaner for when we need to update it.
I could also have seen the static list in it's own configmap separate configmap rather than a key of this map. No need to do this though.
This reverts commit 8808044.
Bug: T375384