Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White labeling/elastic license requirements 17 #21

Merged

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Jan 26, 2022

Summary

Hi Team,

this PR white labels files, classes, styles, etc to Wazuh and it's part of meeting Elastic license requirements.

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs

Closes #17

@asteriscos asteriscos requested a review from a team January 26, 2022 16:13
@asteriscos asteriscos self-assigned this Jan 26, 2022
@mauceballos
Copy link

mauceballos commented Jan 26, 2022

in the wazuh-wui have some icons, in the dark theme, that should be displayed the another way

please see the following screenshot:

header

Copy link
Member

@mpRegalado mpRegalado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non source files

There are multiple files under dot folders such as .ci or .github that reference eui and it's repository. Should these still be there?

The docs folder contains many references to the old names. It seems like it is a minified version of the documentation that may not have been updated. Should it be either updated or added to gitignore?

Documents in the wiki still reference eui and its original repository

Component names

There are still variables and components using the old name scheme

  • EuiTextColor
  • $euiSize--
  • $euiFontSize--
  • $euiFontWeight--
  • $euiColor--
  • $euiTextColor

I would recommentd running a case sensitive serch on the project after addressing the changes in wiki and docs for:

  • <Eui
  • $eui
  • Eui
  • eui

This should help locate all instances of tradenames used within the project

Icons

Review the /src/components/icon/assets directory for unused assets or assets inflicting on the license terms.
One should make sure that the elastic assets are removed.
Some of the conflicting files include:

  • logo_apm
  • logo_app_search
  • logo_beats
  • logo_business_analytics
  • logo_cloud
  • logo_cloud_ece
  • logo_code
  • logo_elasticsearch
  • logo_elastic_stack
  • logo_enterprise_search
  • logo_logging
  • logo_logstash
  • logo_maps
  • logo_metrics
  • logo_observability
  • logo_security
  • logo_site_search
  • logo_workplace_search

@Desvelao Desvelao linked an issue Jan 28, 2022 that may be closed by this pull request
6 tasks
NOTICE Show resolved Hide resolved
@Desvelao
Copy link
Member

Desvelao commented Jan 31, 2022

Changes

  • Fixed the logoWazuh icon doesn't take into account the selected theme
  • Removed logos for apps, ml and some for vis related to Elastic products
  • Removed video explaining how to use the library
  • Removed the NEW tags
  • Renamed kql icons to qry
  • Updated the tests
  • Updated the docs folder

work with @asteriscos

TODO

  • Replace the qry icons (React.js component and SVG). We need the assets.

@Desvelao
Copy link
Member

Desvelao commented Feb 1, 2022

Changes

  • Replaced the qry icons
    • Components
    • SVG

Copy link

@matiasmoreno876 matiasmoreno876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR LGTM
TEST LGTM

Copy link
Member

@mpRegalado mpRegalado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: Great job!

@matiasmoreno876 matiasmoreno876 merged commit ada6bfa into develop Feb 7, 2022
@matiasmoreno876 matiasmoreno876 deleted the white-labeling/elastic-license-requirements-17 branch February 7, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update library to meet the requirements of Elastic UI's apache license
5 participants