-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
White labeling/elastic license requirements 17 #21
White labeling/elastic license requirements 17 #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non source files
There are multiple files under dot folders such as .ci or .github that reference eui and it's repository. Should these still be there?
The docs folder contains many references to the old names. It seems like it is a minified version of the documentation that may not have been updated. Should it be either updated or added to gitignore?
Documents in the wiki still reference eui and its original repository
Component names
There are still variables and components using the old name scheme
- EuiTextColor
- $euiSize--
- $euiFontSize--
- $euiFontWeight--
- $euiColor--
- $euiTextColor
I would recommentd running a case sensitive serch on the project after addressing the changes in wiki and docs for:
- <Eui
- $eui
- Eui
- eui
This should help locate all instances of tradenames used within the project
Icons
Review the /src/components/icon/assets
directory for unused assets or assets inflicting on the license terms.
One should make sure that the elastic assets are removed.
Some of the conflicting files include:
- logo_apm
- logo_app_search
- logo_beats
- logo_business_analytics
- logo_cloud
- logo_cloud_ece
- logo_code
- logo_elasticsearch
- logo_elastic_stack
- logo_enterprise_search
- logo_logging
- logo_logstash
- logo_maps
- logo_metrics
- logo_observability
- logo_security
- logo_site_search
- logo_workplace_search
…ges related to forked library versions
…s://github.com/wazuh/wui into white-labeling/elastic-license-requirements-17
… of `@elastic/charts` library
…s://github.com/wazuh/wui into white-labeling/elastic-license-requirements-17
…s://github.com/wazuh/wui into white-labeling/elastic-license-requirements-17
…s://github.com/wazuh/wui into white-labeling/elastic-license-requirements-17
… the `docs` folder
Changes
TODO
|
Changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR LGTM
TEST LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: Great job!
Summary
Hi Team,
this PR white labels files, classes, styles, etc to Wazuh and it's part of meeting Elastic license requirements.
Checklist
Closes #17